lib/xml/kit/decryption.rb in xml-kit-0.1.11 vs lib/xml/kit/decryption.rb in xml-kit-0.1.12

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Xml
   module Kit
     # {include:file:spec/saml/xml_decryption_spec.rb}
     class Decryption
       # The list of private keys to use to attempt to decrypt the document.
@@ -11,11 +13,11 @@
 
       # Decrypts an EncryptedData section of an XML document.
       #
       # @param data [Hash] the XML document converted to a [Hash] using Hash.from_xml.
       def decrypt(data)
-        ::Xml::Kit.deprecate("decrypt is deprecated. Use decrypt_xml or decrypt_hash instead.")
+        ::Xml::Kit.deprecate('decrypt is deprecated. Use decrypt_xml or decrypt_hash instead.')
         decrypt_hash(data)
       end
 
       # Decrypts an EncryptedData section of an XML document.
       #
@@ -28,37 +30,37 @@
       #
       # @param hash [Hash] the XML document converted to a [Hash] using Hash.from_xml.
       def decrypt_hash(hash)
         encrypted_data = hash['EncryptedData']
         symmetric_key = symmetric_key_from(encrypted_data)
-        cipher_text = Base64.decode64(encrypted_data["CipherData"]["CipherValue"])
-        to_plaintext(cipher_text, symmetric_key, encrypted_data["EncryptionMethod"]['Algorithm'])
+        cipher_value = encrypted_data['CipherData']['CipherValue']
+        cipher_text = Base64.decode64(cipher_value)
+        algorithm = encrypted_data['EncryptionMethod']['Algorithm']
+        to_plaintext(cipher_text, symmetric_key, algorithm)
       end
 
       # Decrypts an EncryptedData Nokogiri::XML::Element.
       #
       # @param node [Nokogiri::XML::Element.] the XML node to decrypt.
       def decrypt_node(node)
-        return node unless !node.nil? && "EncryptedData" == node.name
+        return node unless !node.nil? && node.name == 'EncryptedData'
 
         node.parent.replace(decrypt_xml(node.to_s))[0]
       end
 
       private
 
-      def symmetric_key_from(encrypted_data)
-        encrypted_key = encrypted_data['KeyInfo']['EncryptedKey']
-        cipher_text = Base64.decode64(encrypted_key['CipherData']['CipherValue'])
-        attempts = private_keys.count
+      def symmetric_key_from(encrypted_data, attempts = private_keys.count)
+        cipher_text = Base64.decode64(encrypted_data['KeyInfo']['EncryptedKey']['CipherData']['CipherValue'])
         private_keys.each do |private_key|
           begin
             attempts -= 1
-            return to_plaintext(cipher_text, private_key, encrypted_key["EncryptionMethod"]['Algorithm'])
+            return to_plaintext(cipher_text, private_key, encrypted_data['KeyInfo']['EncryptedKey']['EncryptionMethod']['Algorithm'])
           rescue OpenSSL::PKey::RSAError
             raise if attempts.zero?
           end
         end
-        raise DecryptionError.new(private_keys)
+        raise DecryptionError, private_keys
       end
 
       def to_plaintext(cipher_text, symmetric_key, algorithm)
         Crypto.cipher_for(algorithm, symmetric_key).decrypt(cipher_text)
       end