spec/unit/connection_manager_spec.rb in websocket-rails-0.5.0 vs spec/unit/connection_manager_spec.rb in websocket-rails-0.6.0

@@ -15,17 +15,17 @@
     let(:connections) { subject.connections }
     let(:dispatcher) { subject.dispatcher }
 
     before(:each) do
       ConnectionAdapters::Base.any_instance.stub(:send)
-      @mock_socket = ConnectionAdapters::Base.new(mock_request,dispatcher)
+      @mock_socket = ConnectionAdapters::Base.new(mock_request, dispatcher)
       ConnectionAdapters.stub(:establish_connection).and_return(@mock_socket)
     end
 
     describe "#initialize" do
-      it "should create an empty connections array" do
-        subject.connections.should be_a Array
+      it "should create an empty connections hash" do
+        subject.connections.should be_a Hash
       end
 
       it "should create a new dispatcher instance" do
         subject.dispatcher.should be_a Dispatcher
       end
@@ -34,35 +34,59 @@
     context "new connections" do
       it "should add one to the total connection count" do
         expect { open_connection }.to change { connections.count }.by(1)
       end
 
-      it "should store the new connection in the @connections array" do
+      it "should store the new connection in the @connections Hash" do
         open_connection
-        connections.include?(@mock_socket).should be_true
+        connections[@mock_socket.id].should == @mock_socket
       end
 
       it "should return an Async Rack response" do
         open_connection.should == [ -1, {}, [] ]
       end
+
+      before do
+        SecureRandom.stub(:hex).and_return(1, 2)
+      end
+
+      it "gives the new connection a unique ID" do
+        @mock_socket.should_receive(:id=).with(1)
+        open_connection
+        @mock_socket.should_receive(:id=).with(2)
+        open_connection
+      end
+
+      context "user connections" do
+        before do
+          @mock_socket.stub(:user_connection?).and_return true
+          @mock_socket.stub(:user_identifier).and_return "El Jefe"
+          open_connection
+        end
+
+        it "stores the connection in the UserManager" do
+          WebsocketRails.users["El Jefe"].connections.first.should == @mock_socket
+        end
+      end
     end
 
     context "new POST event" do
       before(:each) do
-        @mock_http = ConnectionAdapters::Http.new(mock_request,dispatcher)
-        app.connections << @mock_http
+        @mock_http = ConnectionAdapters::Http.new(mock_request, dispatcher)
+        @mock_http.id = 1
+        app.connections[@mock_http.id] = @mock_http
       end
 
       it "should receive the new event for the correct connection" do
         @mock_http.should_receive(:on_message).with(encoded_message)
         post '/websocket', {:client_id => @mock_http.id, :data => encoded_message}
       end
     end
 
     context "open connections" do
       before(:each) do
-        ConnectionAdapters.stub(:establish_connection).and_return(@mock_socket,ConnectionAdapters::Base.new(mock_request,dispatcher))
+        ConnectionAdapters.stub(:establish_connection).and_return(@mock_socket, ConnectionAdapters::Base.new(mock_request, dispatcher))
         4.times { open_connection }
       end
 
       context "when receiving a new event" do
         before(:each) { open_connection }
@@ -79,11 +103,11 @@
       end
 
       context "when closing" do
         it "should remove the connection object from the @connections array" do
           @mock_socket.on_close
-          connections.include?(@mock_socket).should be_false
+          connections.has_key?(@mock_socket.id).should be_false
         end
 
         it "should decrement the connection count by one" do
           expect { @mock_socket.on_close }.to change { connections.count }.by(-1)
         end
@@ -92,9 +116,21 @@
           dispatcher.should_receive(:dispatch) do |event|
             event.name.should == :client_disconnected
             event.connection.should == @mock_socket
           end
           @mock_socket.on_close
+        end
+
+        context "user connections" do
+          before do
+            @mock_socket.stub(:user_connection?).and_return true
+            @mock_socket.stub(:user_identifier).and_return "El Jefe"
+          end
+
+          it "deletes the connection from the UserManager" do
+            @mock_socket.on_close
+            WebsocketRails.users["El Jefe"].class.should == UserManager::MissingConnection
+          end
         end
       end
 
     end