.rubocop_todo.yml in webhook_system-2.4.0 vs .rubocop_todo.yml in webhook_system-2.4.1

- old
+ new

@@ -1,177 +1,214 @@ # This configuration was generated by -# `rubocop --auto-gen-config` -# on 2022-04-27 12:05:35 UTC using RuboCop version 1.28.2. +# `rubocop --auto-gen-config --exclude-limit 180` +# on 2023-10-30 03:57:18 UTC using RuboCop version 1.57.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. # Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb Bundler/OrderedGems: Exclude: - - 'gemfiles/rails_6.1.gemfile' + - 'gemfiles/rails_7.1.gemfile' # Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: empty_lines, no_empty_lines -Layout/EmptyLinesAroundBlockBody: +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowSafeAssignment. +Lint/AssignmentInCondition: Exclude: - - 'spec/encoder_spec.rb' - -# Offense count: 2 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: space, no_space -Layout/SpaceAroundEqualsInParameterDefault: - Exclude: - - 'lib/webhook_system/base_event.rb' - - 'lib/webhook_system/job.rb' - -# Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. -# SupportedStylesForExponentOperator: space, no_space -Layout/SpaceAroundOperators: - Exclude: - 'lib/webhook_system/subscription.rb' -# Offense count: 2 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: require_no_space, require_space -Layout/SpaceInLambdaLiteral: - Exclude: - - 'lib/webhook_system/subscription.rb' - -# Offense count: 2 -# This cop supports safe auto-correction (--auto-correct). -Lint/DeprecatedOpenSSLConstant: - Exclude: - - 'lib/webhook_system/encoder.rb' - # Offense count: 1 -# This cop supports unsafe auto-correction (--auto-correct-all). -Lint/NonDeterministicRequireOrder: +# This cop supports unsafe autocorrection (--autocorrect-all). +Lint/RedundantDirGlobSort: Exclude: - 'spec/spec_helper.rb' # Offense count: 1 Lint/UnreachableCode: Exclude: - 'lib/webhook_system/job.rb' -# Offense count: 11 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. -# IgnoredMethods: refine -Metrics/BlockLength: - Max: 112 +# Offense count: 3 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. +Metrics/MethodLength: + Max: 18 # Offense count: 1 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to +# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to Naming/MethodParameterName: Exclude: - 'lib/webhook_system/encoder.rb' # Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredName. Naming/RescuedExceptionsVariableName: Exclude: - - 'lib/webhook_system/job.rb' + - 'spec/support/rails_seven_one.rb' -# Offense count: 2 -# This cop supports safe auto-correction (--auto-correct). -Security/JSONLoad: +# Offense count: 9 +# Configuration parameters: Prefixes, AllowedPatterns. +# Prefixes: when, with, without +RSpec/ContextWording: Exclude: - - 'lib/webhook_system/encoder.rb' + - 'spec/encoder_spec.rb' + - 'spec/event_log_spec.rb' + - 'spec/event_spec.rb' # Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). -Style/FileWrite: +# Configuration parameters: IgnoredMetadata. +RSpec/DescribeClass: Exclude: - - 'Rakefile' + - 'spec/dispatching_events_spec.rb' -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: literals, strict -Style/MutableConstant: +# Offense count: 7 +# Configuration parameters: CountAsOne. +RSpec/ExampleLength: + Max: 24 + +# Offense count: 4 +# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. +# Include: **/*_spec*rb*, **/spec/**/* +RSpec/FilePath: Exclude: - - 'lib/webhook_system/subscription.rb' + - 'spec/encoder_spec.rb' + - 'spec/event_log_spec.rb' + - 'spec/event_spec.rb' + - 'spec/models_spec.rb' -# Offense count: 1 -# This cop supports unsafe auto-correction (--auto-correct-all). -# Configuration parameters: EnforcedStyle, IgnoredMethods. -# SupportedStyles: predicate, comparison -Style/NumericPredicate: +# Offense count: 11 +# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns. +RSpec/IndexedLet: Exclude: - - 'spec/**/*' - - 'lib/webhook_system/job.rb' + - 'spec/dispatching_events_spec.rb' + - 'spec/encoder_spec.rb' + - 'spec/event_spec.rb' + - 'spec/integration_spec.rb' + - 'spec/models_spec.rb' -# Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). -Style/Proc: +# Offense count: 3 +RSpec/LetSetup: Exclude: - - 'lib/webhook_system/subscription.rb' + - 'spec/dispatching_events_spec.rb' + - 'spec/integration_spec.rb' -# Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). -Style/RedundantSelf: +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +RSpec/MatchArray: Exclude: - - 'lib/webhook_system/base_event.rb' + - 'spec/models_spec.rb' -# Offense count: 1 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: EnforcedStyle, AllowInnerSlashes. -# SupportedStyles: slashes, percent_r, mixed -Style/RegexpLiteral: +# Offense count: 10 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: hash, symbol +RSpec/MetadataStyle: Exclude: - 'spec/dispatching_events_spec.rb' + - 'spec/encoder_spec.rb' + - 'spec/event_log_spec.rb' + - 'spec/event_spec.rb' + - 'spec/integration_spec.rb' + - 'spec/models_spec.rb' + - 'spec/spec_helper.rb' +# Offense count: 15 +# Configuration parameters: AllowSubject. +RSpec/MultipleMemoizedHelpers: + Max: 8 + +# Offense count: 9 +# Configuration parameters: EnforcedStyle, IgnoreSharedExamples. +# SupportedStyles: always, named_only +RSpec/NamedSubject: + Exclude: + - 'spec/event_log_spec.rb' + +# Offense count: 3 +# Configuration parameters: AllowedGroups. +RSpec/NestedGroups: + Max: 4 + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +RSpec/ScatteredSetup: + Exclude: + - 'spec/models_spec.rb' + +# Offense count: 4 +# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata. +# Include: **/*_spec.rb +RSpec/SpecFilePathFormat: + Exclude: + - 'spec/encoder_spec.rb' + - 'spec/event_log_spec.rb' + - 'spec/event_spec.rb' + - 'spec/models_spec.rb' + # Offense count: 2 -# This cop supports safe auto-correction (--auto-correct). -Style/StderrPuts: +# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. +RSpec/VerifiedDoubles: Exclude: - - 'Rakefile' + - 'spec/event_log_spec.rb' # Offense count: 1 -# This cop supports unsafe auto-correction (--auto-correct-all). -# Configuration parameters: Mode. -Style/StringConcatenation: +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/RedundantPresenceValidationOnBelongsTo: Exclude: + - 'lib/webhook_system/event_log.rb' + +# Offense count: 3 +# Configuration parameters: AllowedConstants. +Style/Documentation: + Exclude: + - 'lib/webhook_system.rb' - 'lib/webhook_system/encoder.rb' + - 'lib/webhook_system/subscription_topic.rb' + - 'spec/support/rails_seven_one.rb' -# Offense count: 4 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: MinSize. -# SupportedStyles: percent, brackets -Style/SymbolArray: - EnforcedStyle: brackets +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/MultilineIfModifier: + Exclude: + - 'spec/support/rails_seven_one.rb' -# Offense count: 3 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: EnforcedStyleForMultiline. -# SupportedStylesForMultiline: comma, consistent_comma, no_comma -Style/TrailingCommaInArrayLiteral: +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, AllowedCompactTypes. +# SupportedStyles: compact, exploded +Style/RaiseArgs: Exclude: - - 'spec/dispatching_events_spec.rb' + - 'spec/support/rails_seven_one.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantConstantBase: + Exclude: - 'spec/event_spec.rb' - - 'spec/integration_spec.rb' -# Offense count: 14 -# This cop supports safe auto-correction (--auto-correct). -# Configuration parameters: EnforcedStyleForMultiline. -# SupportedStylesForMultiline: comma, consistent_comma, no_comma -Style/TrailingCommaInHashLiteral: +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantFreeze: Exclude: - - 'lib/webhook_system/base_event.rb' - - 'lib/webhook_system/encoder.rb' - - 'lib/webhook_system/event_log.rb' - 'lib/webhook_system/subscription.rb' - - 'spec/encoder_spec.rb' - - 'spec/event_spec.rb' - - 'spec/integration_spec.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed +Style/RegexpLiteral: + Exclude: + - 'spec/dispatching_events_spec.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: implicit, explicit +Style/RescueStandardError: + Exclude: + - 'spec/support/rails_seven_one.rb'