config/site.reek in veritas-sql-generator-0.0.3 vs config/site.reek in veritas-sql-generator-0.0.4

@@ -6,17 +6,20 @@
   reject:
   - !ruby/regexp /^.$/
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
 LargeClass:
-  max_methods: 22  # TODO: reduce this in UnaryRelation
+  max_methods: 26  # TODO: reduce this in UnaryRelation
   exclude: []
   enabled: true
-  max_instance_variables: 9  # TODO: reduce this in UnaryRelation
+  max_instance_variables: 12  # TODO: reduce this in UnaryRelation
 UncommunicativeMethodName:
   accept: []
-  exclude: []
+  exclude: [
+    'Date#iso8601',
+    'DateTime#iso8601'
+  ]
   enabled: true
   reject:
   - !ruby/regexp /^[a-z]$/
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
@@ -28,20 +31,19 @@
 FeatureEnvy:
   exclude: [
     # TODO: change these methods to be class methods
     'Veritas::SQL::Generator::Attribute#visit_veritas_attribute',
     'Veritas::SQL::Generator::Identifier#visit_identifier',
-    'Veritas::SQL::Generator::Literal#visit_date_time',
     'Veritas::SQL::Generator::Literal#visit_numeric',
     'Veritas::SQL::Generator::Literal#visit_string',
-    'Veritas::SQL::Generator::Literal#visit_time',
-    'Veritas::SQL::Generator::Logic#visit_veritas_logic_predicate_inequality',
-    'Veritas::SQL::Generator::Logic#exclusive_range_exclusion_sql',
-    'Veritas::SQL::Generator::Logic#exclusive_range_inclusion_sql',
-    'Veritas::SQL::Generator::Logic#new_from_enumerable_predicate',
-    'Veritas::SQL::Generator::Logic#optional?',
-    'Veritas::SQL::Generator::Relation::Unary#collapse_subquery_for?'
+    'Veritas::SQL::Generator::Function::Predicate#visit_veritas_function_predicate_inequality',
+    'Veritas::SQL::Generator::Function::Predicate#exclusive_range_exclusion_sql',
+    'Veritas::SQL::Generator::Function::Predicate#exclusive_range_inclusion_sql',
+    'Veritas::SQL::Generator::Function::Predicate#new_from_enumerable_predicate',
+    'Veritas::SQL::Generator::Function::Predicate#optional?',
+    'Veritas::SQL::Generator::Relation::Unary#collapse_subquery_for?',
+    'Veritas::SQL::Generator::Relation#column_list_for'
   ]
   enabled: true
 ClassVariable:
   exclude: []
   enabled: true
@@ -64,11 +66,11 @@
     'Veritas::SQL::Generator::Visitor#self.handlers'
   ]
   enabled: true
   max_allowed_nesting: 1
 LongMethod:
-  max_statements: 7
+  max_statements: 9
   exclude: [
     'Veritas::SQL::Generator::Relation::Unary#to_s'
   ]
   enabled: true
 Duplication:
@@ -82,15 +84,15 @@
     # TODO: change these methods to be class methods
     'Veritas::SQL::Generator::Attribute#visit_veritas_attribute',
     'Veritas::SQL::Generator::Identifier#visit_identifier',
     'Veritas::SQL::Generator::Literal#visit_numeric',
     'Veritas::SQL::Generator::Literal#visit_string',
-    'Veritas::SQL::Generator::Logic#visit_veritas_logic_predicate_inequality',
-    'Veritas::SQL::Generator::Logic#exclusive_range_exclusion_sql',
-    'Veritas::SQL::Generator::Logic#exclusive_range_inclusion_sql',
-    'Veritas::SQL::Generator::Logic#new_from_enumerable_predicate',
-    'Veritas::SQL::Generator::Logic#optional?',
+    'Veritas::SQL::Generator::Function::Predicate#visit_veritas_function_predicate_inequality',
+    'Veritas::SQL::Generator::Function::Predicate#exclusive_range_exclusion_sql',
+    'Veritas::SQL::Generator::Function::Predicate#exclusive_range_inclusion_sql',
+    'Veritas::SQL::Generator::Function::Predicate#new_from_enumerable_predicate',
+    'Veritas::SQL::Generator::Function::Predicate#optional?',
     'Veritas::SQL::Generator::Relation::Unary#collapse_subquery_for?'
   ]
   enabled: true
 Attribute:
   exclude: []
@@ -104,14 +106,14 @@
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
 SimulatedPolymorphism:
   exclude: []
   enabled: true
-  max_ifs: 1
+  max_ifs: 2
 DataClump:
   exclude: [
     # TODO: split Range handling methods into separate class/module
-    'Veritas::SQL::Generator::Logic'
+    'Veritas::SQL::Generator::Function'
   ]
   enabled: true
   max_copies: 1
   min_clump_size: 2
 ControlCouple: