lib/verdict/storage/redis_storage.rb in verdict-0.3.2 vs lib/verdict/storage/redis_storage.rb in verdict-0.4.0

@@ -1,62 +1,36 @@
 module Verdict
   module Storage
-    class RedisStorage
+    class RedisStorage < BaseStorage
       attr_accessor :redis, :key_prefix
 
       def initialize(redis = nil, options = {})
         @redis = redis
         @key_prefix = options[:key_prefix] || 'experiments/'
       end
 
-      def retrieve_assignment(experiment, subject_identifier)
-        if value = redis.hget(generate_experiment_key(experiment), subject_identifier)
-          hash = JSON.parse(value)
-          experiment.subject_assignment(
-            subject_identifier,
-            experiment.group(hash['group']),
-            DateTime.parse(hash['created_at']).to_time
-          )
-        end
+      def get(scope, key)
+        redis.hget("#{@key_prefix}#{scope}", key)
       rescue ::Redis::BaseError => e
         raise Verdict::StorageError, "Redis error: #{e.message}"
       end
 
-      def store_assignment(assignment)
-        hash = { group: assignment.handle, created_at: assignment.created_at }
-        redis.hset(generate_experiment_key(assignment.experiment), assignment.subject_identifier, JSON.dump(hash))
+      def set(scope, key, value)
+        redis.hset("#{@key_prefix}#{scope}", key, value)
       rescue ::Redis::BaseError => e
         raise Verdict::StorageError, "Redis error: #{e.message}"
       end
 
-      def remove_assignment(experiment, subject_identifier)
-        redis.hdel(generate_experiment_key(experiment), subject_identifier)
+      def remove(scope, key)
+        redis.hdel("#{@key_prefix}#{scope}", key)
+      rescue ::Redis::BaseError => e
+        raise Verdict::StorageError, "Redis error: #{e.message}"
       end
 
-      def clear_experiment(experiment)
-        redis.del(generate_experiment_key(experiment))
-        redis.del(generate_experiment_start_timestamp_key(experiment))
-      end
-
-      def retrieve_start_timestamp(experiment)
-        if started_at = redis.get(generate_experiment_start_timestamp_key(experiment))
-          DateTime.parse(started_at).to_time
-        end
-      end
-
-      def store_start_timestamp(experiment, timestamp)
-        redis.setnx(generate_experiment_start_timestamp_key(experiment), timestamp.to_s)
-      end
-
-
       private
 
-      def generate_experiment_key(experiment)
-        "#{@key_prefix}#{experiment.handle}"
-      end
-
-      def generate_experiment_start_timestamp_key(experiment)
-        "#{@key_prefix}#{experiment.handle}/started_at"
+      def generate_scope_key(scope)
+        "#{@key_prefix}#{scope}"
       end
     end
   end
 end