repository.rb in valkyrie-1.0.0.rc1

- old
+ new
@@ -1,36 +1,48 @@
 # frozen_string_literal: true
 module Valkyrie::Persistence::Solr
+  # Responsible for handling the logic for persisting or deleting multiple
+  # objects into or out of solr.
   class Repository
+    COMMIT_PARAMS = { softCommit: true }.freeze
+
     attr_reader :resources, :connection, :resource_factory
     def initialize(resources:, connection:, resource_factory:)
       @resources = resources
       @connection = connection
       @resource_factory = resource_factory
     end
 
     def persist
       documents = resources.map do |resource|
         generate_id(resource) if resource.id.blank?
+        ensure_multiple_values!(resource)
         solr_document(resource)
       end
-      connection.add documents, params: { softCommit: true }
+      connection.add documents, params: COMMIT_PARAMS
       documents.map do |document|
         resource_factory.to_resource(object: document.stringify_keys)
       end
     end
 
     def delete
-      connection.delete_by_id resources.map { |resource| "id-#{resource.id}" }, params: { softCommit: true }
+      connection.delete_by_id resources.map { |resource| resource.id.to_s }, params: COMMIT_PARAMS
       resources
     end
 
     def solr_document(resource)
       resource_factory.from_resource(resource: resource).to_h
     end
 
     def generate_id(resource)
       Valkyrie.logger.warn "The Solr adapter is not meant to persist new resources, but is now generating an ID."
       resource.id = SecureRandom.uuid
+    end
+
+    def ensure_multiple_values!(resource)
+      bad_keys = resource.attributes.except(:internal_resource, :created_at, :updated_at, :new_record, :id).select do |_k, v|
+        !v.nil? && !v.is_a?(Array)
+      end
+      raise ::Valkyrie::Persistence::UnsupportedDatatype, "#{resource}: #{bad_keys.keys} have non-array values, which can not be persisted by Valkyrie. Cast to arrays." unless bad_keys.keys.empty?
     end
   end
 end