test/unit/vagrant/util/ssh_test.rb in vagrant-unbundled-1.9.5.1 vs test/unit/vagrant/util/ssh_test.rb in vagrant-unbundled-1.9.7.1

- old
+ new

@@ -25,6 +25,164 @@ described_class.check_key_permissions(key_path) expect(key_path.stat.mode).to eq(0100600) end end + + describe "#exec" do + let(:ssh_info) {{ + host: "localhost", + port: 2222, + username: "vagrant", + private_key_path: [temporary_file], + compression: true, + dsa_authentication: true + }} + + it "raises an exception if there is no ssh" do + allow(Vagrant::Util::Which).to receive(:which).and_return(nil) + + expect { described_class.exec(ssh_info) }. + to raise_error Vagrant::Errors::SSHUnavailable + end + + it "raises an exception if there is no ssh and platform is windows" do + allow(Vagrant::Util::Which).to receive(:which).and_return(nil) + allow(Vagrant::Util::Platform).to receive(:windows?).and_return(true) + + expect { described_class.exec(ssh_info) }. + to raise_error Vagrant::Errors::SSHUnavailableWindows + end + + it "raises an exception if the platform is windows and uses PuTTY Link" do + allow(Vagrant::Util::Platform).to receive(:windows?).and_return(true) + allow(Vagrant::Util::Subprocess).to receive(:execute). + and_return(double("output", stdout: 'PuTTY Link')) + + expect { described_class.exec(ssh_info) }. + to raise_error Vagrant::Errors::SSHIsPuttyLink + end + + it "invokes SSH with options if subprocess is not allowed" do + allow(Vagrant::Util::SafeExec).to receive(:exec).and_return(nil) + + expect(described_class.exec(ssh_info)).to eq(nil) + expect(Vagrant::Util::SafeExec).to have_received(:exec) + .with("ssh", "vagrant@localhost", "-p", "2222", "-o", "LogLevel=FATAL","-o", "Compression=yes", "-o", "DSAAuthentication=yes", "-o", "StrictHostKeyChecking=no", "-o", "UserKnownHostsFile=/dev/null", "-i", anything) + end + + context "when disabling compression or dsa_authentication flags" do + let(:ssh_info) {{ + host: "localhost", + port: 2222, + username: "vagrant", + private_key_path: [temporary_file], + compression: false, + dsa_authentication: false + }} + + it "does not include compression or dsa_authentication flags if disabled" do + allow(Vagrant::Util::SafeExec).to receive(:exec).and_return(nil) + + expect(described_class.exec(ssh_info)).to eq(nil) + expect(Vagrant::Util::SafeExec).to have_received(:exec) + .with("ssh", "vagrant@localhost", "-p", "2222", "-o", "LogLevel=FATAL", "-o", "StrictHostKeyChecking=no", "-o", "UserKnownHostsFile=/dev/null", "-i", anything) + end + end + + context "when paranoid is true" do + let(:ssh_info) {{ + host: "localhost", + port: 2222, + username: "vagrant", + private_key_path: [temporary_file], + paranoid: true + }} + + it "does not disable StrictHostKeyChecking or set UserKnownHostsFile" do + allow(Vagrant::Util::SafeExec).to receive(:exec).and_return(nil) + + expect(described_class.exec(ssh_info)).to eq(nil) + expect(Vagrant::Util::SafeExec).to have_received(:exec) + .with("ssh", "vagrant@localhost", "-p", "2222", "-o", "LogLevel=FATAL", "-i", anything) + end + end + + context "when not on solaris not using plain mode or with keys_only enabled" do + let(:ssh_info) {{ + host: "localhost", + port: 2222, + username: "vagrant", + private_key_path: [temporary_file], + keys_only: true + }} + + it "adds IdentitiesOnly as an option for ssh" do + allow(Vagrant::Util::SafeExec).to receive(:exec).and_return(nil) + allow(Vagrant::Util::Platform).to receive(:solaris?).and_return(false) + + expect(described_class.exec(ssh_info, {plain_mode: true})).to eq(nil) + expect(Vagrant::Util::SafeExec).to have_received(:exec) + .with("ssh", "localhost", "-p", "2222", "-o", "LogLevel=FATAL", "-o", "StrictHostKeyChecking=no", "-o", "UserKnownHostsFile=/dev/null") + end + end + + context "when forward_x11 is enabled" do + let(:ssh_info) {{ + host: "localhost", + port: 2222, + username: "vagrant", + private_key_path: [temporary_file], + forward_x11: true + }} + + it "enables ForwardX11 options" do + allow(Vagrant::Util::SafeExec).to receive(:exec).and_return(nil) + + expect(described_class.exec(ssh_info)).to eq(nil) + expect(Vagrant::Util::SafeExec).to have_received(:exec) + .with("ssh", "vagrant@localhost", "-p", "2222", "-o", "LogLevel=FATAL", "-o", "StrictHostKeyChecking=no", "-o", "UserKnownHostsFile=/dev/null", "-i", anything,"-o", "ForwardX11=yes", "-o", "ForwardX11Trusted=yes") + end + end + + context "when forward_agent is enabled" do + let(:ssh_info) {{ + host: "localhost", + port: 2222, + username: "vagrant", + private_key_path: [temporary_file], + forward_agent: true + }} + + it "enables agent forwarding options" do + allow(Vagrant::Util::SafeExec).to receive(:exec).and_return(nil) + + expect(described_class.exec(ssh_info)).to eq(nil) + expect(Vagrant::Util::SafeExec).to have_received(:exec) + .with("ssh", "vagrant@localhost", "-p", "2222", "-o", "LogLevel=FATAL", "-o", "StrictHostKeyChecking=no", "-o", "UserKnownHostsFile=/dev/null", "-i", anything,"-o", "ForwardAgent=yes") + end + end + + context "with subprocess enabled" do + let(:ssh_info) {{ + host: "localhost", + port: 2222, + username: "vagrant", + private_key_path: [temporary_file], + }} + + it "executes SSH in a subprocess with options and returns an exit code Fixnum" do + # mock out ChildProcess + process = double() + allow(ChildProcess).to receive(:build).and_return(process) + allow(process).to receive(:io).and_return(true) + allow(process.io).to receive(:inherit!).and_return(true) + allow(process).to receive(:start).and_return(true) + allow(process).to receive(:wait).and_return(true) + + allow(process).to receive(:exit_code).and_return(0) + + expect(described_class.exec(ssh_info, {subprocess: true})).to eq(0) + end + end + end end