lib/usps_flags/helpers.rb in usps_flags-0.3.4 vs lib/usps_flags/helpers.rb in usps_flags-0.3.5

@@ -87,16 +87,12 @@
     # @private
     def log(*messages)
       ::FileUtils.mkdir_p(USPSFlags::Config.log_path)
       outputs = [STDOUT]
 
-      begin
-        log_file = File.open("#{USPSFlags::Config.log_path}/flag.log", 'a')
-        outputs << log_file
-      rescue Errno::EACCES => e
-        puts "\nError accessing log file." unless USPSFlags::Config.log_fail_quietly
-      end
+      log_file = File.open("#{USPSFlags::Config.log_path}/flag.log", 'a')
+      outputs << log_file
 
       messages.each do |message|
         outputs.each { |f| f.write(message) }
       end
 
@@ -205,16 +201,13 @@
       else
         1
       end
     end
 
-    def flag_type(rank)
-      if rank == "PORTCAP"
-        :pc
-      elsif rank == "FLEETCAP"
-        :fc
-      elsif rank == "STFC"
-        :stf
+    def flag_type(rank) # Complexity
+      specifics = {"PORTCAP" => :pc, "FLEETCAP" => :fc, "STFC" => :stf}
+      if specifics.keys.include?(rank)
+        specifics[rank]
       elsif rank.match /.AIDE/
         :a
       elsif rank.match /.?FLT/
         :f
       else