lib/triangular/solid.rb in triangular-0.0.2 vs lib/triangular/solid.rb in triangular-0.1.1

@@ -1,91 +1,89 @@
+# frozen_string_literal: true
+
 module Triangular
   class Solid
-    
     attr_accessor :name, :facets, :units
-    
+
     def initialize(name, *args)
       @name = name
       @facets = args
       @units = units
     end
-    
+
     def to_s
-      output = "solid #{@name || ""}\n"
+      output = "solid #{@name || ''}\n"
       @facets.each do |facet|
-        output << "facet normal #{facet.normal.x.to_f} #{facet.normal.y.to_f} #{facet.normal.z.to_f}\n"
-        output << "outer loop\n"
+        output += "facet normal #{facet.normal.x.to_f} #{facet.normal.y.to_f} #{facet.normal.z.to_f}\n"
+        output += "outer loop\n"
         facet.vertices.each do |vertex|
-          output <<"vertex #{vertex.x.to_f} #{vertex.y.to_f} #{vertex.z.to_f}\n"
+          output += "vertex #{vertex.x.to_f} #{vertex.y.to_f} #{vertex.z.to_f}\n"
         end
-        output << "endloop\n"
-        output << "endfacet\n"
+        output += "endloop\n"
+        output += "endfacet\n"
       end
-      output << "endsolid #{@name || ""}\n"
-      
+      output += "endsolid #{@name || ''}\n"
+
       output
     end
-    
-    def get_bounds
+
+    def bounds
       largest_x = @facets[0].vertices[0].x
       largest_y = @facets[0].vertices[0].y
       largest_z = @facets[0].vertices[0].z
-      
+
       smallest_x = @facets[0].vertices[0].x
       smallest_y = @facets[0].vertices[0].y
       smallest_z = @facets[0].vertices[0].z
-      
+
       @facets.each do |facet|
         facet.vertices.each do |vertex|
           largest_x = vertex.x if vertex.x > largest_x
           largest_y = vertex.y if vertex.y > largest_y
           largest_z = vertex.z if vertex.z > largest_z
-          
+
           smallest_x = vertex.x if vertex.x < smallest_x
           smallest_y = vertex.y if vertex.y < smallest_y
           smallest_z = vertex.z if vertex.z < smallest_z
         end
       end
-      
+
       [Point.new(smallest_x, smallest_y, smallest_z), Point.new(largest_x, largest_y, largest_z)]
     end
-    
+
     def align_to_origin!
-      bounds = self.get_bounds
-      self.translate!(-bounds[0].x, -bounds[0].y, -bounds[0].z)
+      translate!(-bounds[0].x, -bounds[0].y, -bounds[0].z)
     end
-    
+
     def center!
-      bounds = self.get_bounds
-      
       x_translation = ((bounds[1].x - bounds[0].x).abs / 2) + -bounds[1].x
       y_translation = ((bounds[1].y - bounds[0].y).abs / 2) + -bounds[1].y
       z_translation = ((bounds[1].z - bounds[0].z).abs / 2) + -bounds[1].z
-      
-      self.translate!(x_translation, y_translation, z_translation)
+
+      translate!(x_translation, y_translation, z_translation)
     end
-    
+
     def slice_at_z(z_plane)
-      lines = @facets.map {|facet| facet.intersection_at_z(z_plane) }
+      lines = @facets.map { |facet| facet.intersection_at_z(z_plane) }
       lines.compact!
-      
+
       Polyline.new(lines)
     end
-    
+
     def translate!(x, y, z)
       @facets.each do |facet|
         facet.translate!(x, y, z)
       end
     end
-    
+
     def self.parse(string)
-      partial_pattern = /\s* solid\s+ (?<name> [a-zA-Z0-9\-\_\.]+)?/x
+      partial_pattern = /\s* solid\s+ (?<name> [a-zA-Z0-9\-_.]+)?/x
       match_data = string.match(partial_pattern)
-      
-      solid = self.new(match_data[:name])
-      
-      solid.facets = Facet.parse(string.gsub(partial_pattern, ""))
-      
+
+      solid = new(match_data[:name])
+
+      solid.facets = Facet.parse(string.gsub(partial_pattern, ''))
+
       solid
     end
   end
 end