runner.rb in trailblazer-activity-0.6.0

- old
+ new

@@ -7,22 +7,24 @@
     module Runner
       # Runner signature: call( task, direction, options, static_wraps )
       #
       # @api private
       # @interface Runner
-      def self.call(task, args, **circuit_options)
+      def self.call(task, args, circuit_options)
         wrap_ctx = { task: task }
 
         # this activity is "wrapped around" the actual `task`.
         task_wrap_activity = merge_static_with_runtime(task, circuit_options)
 
         # We save all original args passed into this Runner.call, because we want to return them later after this wrap
         # is finished.
         original_args = [ args, circuit_options ]
+
         # call the wrap {Activity} around the task.
         wrap_end_signal, ( wrap_ctx, _ ) = task_wrap_activity.(
-          [ wrap_ctx, original_args ] # we omit circuit_options here on purpose, so the wrapping activity uses the default, plain Runner.
+          [ wrap_ctx, original_args ], # we omit circuit_options here on purpose, so the wrapping activity uses the default, plain Runner.
+          {}
         )
 
         # don't return the wrap's end signal, but the one from call_task.
         # return all original_args for the next "real" task in the circuit (this includes circuit_options).
 
@@ -35,18 +37,26 @@
       #
       # NOTE: this is for performance reasons: we could have only one hash containing everything but that'd mean
       # unnecessary computations at `call`-time since steps might not even be executed.
       # TODO: make this faster.
       def self.merge_static_with_runtime(task, wrap_runtime:, **circuit_options)
-        wrap_activity = TaskWrap.wrap_static_for(task, circuit_options)  # find static wrap for this specific task, or default wrap activity.
+        wrap_activity = TaskWrap.wrap_static_for(
+          task,
+          circuit_options
+        )  # find static wrap for this specific task, or default wrap activity.
 
         # Apply runtime alterations.
         # Grab the additional wirings for the particular `task` from `wrap_runtime` (returns default otherwise).
         wrap_runtime[task] ? Trailblazer::Activity::Path::Plan.merge(wrap_activity, wrap_runtime[task]) : wrap_activity
       end
     end # Runner
 
-    def self.wrap_static_for(task, wrap_static:, default_activity: TaskWrap.initial_activity, **)
+    # Retrieve the static wrap config from {activity}.
+    # I do not like this part too much, I'd prefer computing the {:wrap_static} at compile-time for the entire
+    # object graph (including nesteds) and simply pass it through to all Runner calls.
+    # TODO: simplify that. See above
+    def self.wrap_static_for(task, activity:, default_activity: TaskWrap.initial_activity, **)
+      wrap_static = activity[:wrap_static] || {}
       wrap_static[task] || default_activity
     end
   end
 end