trackoid_spec.rb in trackoid-0.4.0

- old
+ new

@@ -7,45 +7,41 @@
   field :name   # Dummy field
   track :visits
 end
 
 describe Mongoid::Tracking do
-  before(:all) do
-    @trackoid_version = File.read(File.expand_path("../VERSION", File.dirname(__FILE__)))
+  it "should ensure allow_dynamic_fields option is turned off" do
+    Mongoid::Config.settings[:allow_dynamic_fields].should == false
   end
 
-  it "should expose the same version as the VERSION file" do
-    Mongoid::Tracking::VERSION.should == @trackoid_version
-  end
-  
   it "should raise error when used in a class not of class Mongoid::Document" do
-    lambda {
+    -> {
       class NotMongoidClass
         include Mongoid::Tracking
         track :something
       end
-    }.should raise_error Mongoid::Errors::NotMongoid
+    }.should raise_error Mongoid::Tracking::Errors::NotMongoid
   end
 
   it "should not raise error when used in a class of class Mongoid::Document" do
-    lambda {
+    -> {
       class MongoidedDocument
         include Mongoid::Document
         include Mongoid::Tracking
         track :something
       end
     }.should_not raise_error
   end
 
   it "should not raise errors when using to/as_json" do
-    mock = Test.new(:name => "Trackoid")
+    test = Test.new(:name => "Trackoid")
     json_as = {}
     json_to = ""
 
-    lambda {
-      json_as = mock.as_json(:except => :_id)
-      json_to = mock.to_json(:except => :_id)
+    -> {
+      json_as = test.as_json(:except => :_id)
+      json_to = test.to_json(:except => :_id)
     }.should_not raise_error
 
     json_as.should == { "name" => "Trackoid" }
     json_to.should == "{\"name\":\"Trackoid\"}"
   end
@@ -53,29 +49,18 @@
   describe "when creating a new field with stats" do
     before(:all) do
       @mock = Test.new
     end
 
-    it "should deny access to the underlying mongoid field" do
-      lambda { @mock.visits_data }.should raise_error NoMethodError
-      lambda { @mock.visits_data = {} }.should raise_error NoMethodError
-    end
-
     it "should create a method for accesing the stats" do
       @mock.respond_to?(:visits).should be_true
     end
 
     it "should NOT create an index for the stats field" do
       @mock.class.index_options.should_not include(:visits_data)
     end
 
-    it "should respond 'false' to field_changed? method" do
-      # Ok, this test is not very relevant since it will return false even
-      # if Trackoid does not override it.
-      @mock.visits_changed?.should be_false
-    end
-
     it "should create a method for accesing the stats of the proper class" do
       @mock.visits.class.should == Mongoid::Tracking::Tracker
     end
 
     it "should create an array in the class with all tracking fields" do
@@ -88,11 +73,11 @@
       end
       @mock.class.tracked_fields.should == [ :visits, :something_else ]
     end
 
     it "should not update stats when new record" do
-      lambda { @mock.visits.inc }.should raise_error Mongoid::Errors::ModelNotSaved
+      -> { @mock.visits.inc }.should raise_error Mongoid::Tracking::Errors::ModelNotSaved
     end
 
     it "should create an empty hash as the internal representation" do
       @mock.visits.send(:_original_hash).should == {}
     end
@@ -111,129 +96,140 @@
 
     it "should not be aggregated" do
       @mock.aggregated?.should be_false
     end
   end
-  
+
   describe "when using a model in the database" do
-    before(:all) do
-      Test.delete_all
-      Test.create(:name => "test")
-      @object_id = Test.first.id
-    end
+    let(:test) { Test.create(:name => "test") }
 
     before do
-      @mock = Test.find(@object_id)
       @today = Time.now
     end
 
     it "should increment visits stats for today" do
-      @mock.visits.inc
-      @mock.visits.today.should == 1
+      test.visits.inc
+      test.visits.today.should == 1
     end
 
     it "should increment another visits stats for today for a total of 2" do
-      @mock.visits.inc
-      @mock.visits.today.should == 2
+      test.visits.inc
+      test.visits.inc
+      test.visits.today.should == 2
     end
 
     it "should also work for yesterday" do
-      @mock.visits.inc(@today - 1.day)
-      @mock.visits.yesterday.should == 1
+      test.visits.inc(@today - 1.day)
+      test.visits.yesterday.should == 1
     end
 
     it "should also work for yesterday if adding another visit (for a total of 2)" do
-      @mock.visits.inc(@today - 1.day)
-      @mock.visits.yesterday.should == 2
+      test.visits.inc(@today - 1.day)
+      test.visits.inc(@today - 1.day)
+      test.visits.yesterday.should == 2
     end
-    
+
     it "then, the visits of today + yesterday must be the same" do
-      @mock.visits.last_days(2).should == [2, 2]
+      test.visits.inc
+      test.visits.inc
+      test.visits.inc(@today - 1.day)
+      test.visits.inc(@today - 1.day)
+      test.visits.last_days(2).should == [2, 2]
     end
 
     it "should have 4 visits for this test" do
-      @mock.visits.last_days(2).sum.should == 4
+      test.visits.inc
+      test.visits.inc
+      test.visits.inc(@today - 1.day)
+      test.visits.inc(@today - 1.day)
+      test.visits.last_days(2).sum.should == 4
     end
 
     it "should correctly handle the 7 days" do
-      @mock.visits.last_days.should == [0, 0, 0, 0, 0, 2, 2]
+      test.visits.inc
+      test.visits.inc
+      test.visits.inc(@today - 1.day)
+      test.visits.inc(@today - 1.day)
+      test.visits.last_days.should == [0, 0, 0, 0, 0, 2, 2]
     end
 
     it "string dates should work" do
-      @mock.visits.inc("2010-07-11")
-      @mock.visits.on("2010-07-11").should == 1
+      test.visits.inc("2010-07-11")
+      test.visits.on("2010-07-11").should == 1
     end
 
     it "should give the first date with first_date" do
+      test.visits.inc("2010-07-11")
       t = Time.parse("2010-07-11")
-      f = @mock.visits.first_date
+      f = test.visits.first_date
       [f.year, f.month, f.day, f.hour].should == [t.year, t.month, t.day, t.hour]
     end
 
     it "should give the last date with last_date" do
       future = @today + 1.month
-      @mock.visits.set(22, future)
-      f = @mock.visits.last_date
+      test.visits.set(22, future)
+      f = test.visits.last_date
       [f.year, f.month, f.day, f.hour].should == [future.year, future.month, future.day, future.hour]
     end
 
     it "should give the first value" do
-      @mock.visits.first_value.should == 1
+      test.visits.inc("2010-07-11")
+      test.visits.first_value.should == 1
     end
 
     it "should give the last value" do
-      @mock.visits.last_value.should == 22
+      future = @today + 1.month
+      test.visits.set(22, future)
+      test.visits.last_value.should == 22
     end
   end
 
   context "testing reader operations without reloading models" do
-    before(:all) do
-      Test.delete_all
-      Test.create(:name => "test")
-      @object_id = Test.first.id
-    end
+    let(:test) { Test.create(name: "test") }
+    let(:object_id) { test.id }
 
-    before do
-      @mock = Test.find(@object_id)
-    end
-
     it "'set' operator must work" do
-      @mock.visits.set(5)
-      @mock.visits.today.should == 5
-      Test.find(@object_id).visits.today.should == 5
+      test.visits.set(5)
+      test.visits.today.should == 5
+      Test.find(object_id).visits.today.should == 5
     end
 
     it "'set' operator must work on arbitrary days" do
-      @mock.visits.set(5, Time.parse("2010-05-01"))
-      @mock.visits.on(Time.parse("2010-05-01")).should == 5
-      Test.find(@object_id).visits.on(Time.parse("2010-05-01")).should == 5
+      test.visits.set(5, Time.parse("2010-05-01"))
+      test.visits.on(Time.parse("2010-05-01")).should == 5
+      Test.find(object_id).visits.on(Time.parse("2010-05-01")).should == 5
     end
 
     it "'add' operator must work" do
-      @mock.visits.add(5)
-      @mock.visits.today.should == 10   # Remember 5 set on previous test
-      Test.find(@object_id).visits.today.should == 10
+      test.visits.set(5)
+      test.visits.add(5)
+      test.visits.today.should == 10
+      Test.find(object_id).visits.today.should == 10
     end
 
     it "'add' operator must work on arbitrary days" do
-      @mock.visits.add(5, Time.parse("2010-05-01"))
-      @mock.visits.on(Time.parse("2010-05-01")).should == 10
-      Test.find(@object_id).visits.on(Time.parse("2010-05-01")).should == 10
+      test.visits.set(5, Time.parse("2010-05-01"))
+      test.visits.add(5, Time.parse("2010-05-01"))
+      test.visits.on(Time.parse("2010-05-01")).should == 10
+      Test.find(object_id).visits.on(Time.parse("2010-05-01")).should == 10
     end
 
     it "on() accessor must work on dates as String" do
-      # We have data for today as previous tests populated the visits field
-      @mock.visits.on("2010-05-01").should == 10
+      test.visits.set(5, Time.parse("2010-05-01"))
+      test.visits.add(5, Time.parse("2010-05-01"))
+      test.visits.on("2010-05-01").should == 10
     end
 
     it "on() accessor must work on Date descendants" do
-      # We have data for today as previous tests populated the visits field
-      @mock.visits.on(Date.parse("2010-05-01")).should == 10
+      test.visits.set(5, Time.parse("2010-05-01"))
+      test.visits.add(5, Time.parse("2010-05-01"))
+      test.visits.on(Date.parse("2010-05-01")).should == 10
     end
 
     it "on() accessor must work on dates as Ranges" do
-      # We have data for today as previous tests populated the visits field
-      @mock.visits.on(Time.parse("2010-04-30")..Time.parse("2010-05-02")).should == [0, 10, 0]
+      test.visits.set(5, Time.parse("2010-05-01"))
+      test.visits.add(5, Time.parse("2010-05-01"))
+      test.visits.on(Time.parse("2010-04-30")..Time.parse("2010-05-02")).should == [0, 10, 0]
     end
   end
 
   context "regression test for github issues" do
     it "should not raise undefined method [] for nil:NilClass when adding a new track into an existing object" do