tracks/java/exercises/phone-number/src/test/java/PhoneNumberTest.java in trackler-2.2.1.137 vs tracks/java/exercises/phone-number/src/test/java/PhoneNumberTest.java in trackler-2.2.1.138

- old
+ new

@@ -4,47 +4,47 @@ import org.junit.rules.ExpectedException; import static org.junit.Assert.assertEquals; public class PhoneNumberTest { - private final static String wrongLengthExceptionMessage = "Number must be 10 or 11 digits"; - private final static String numberIs11DigitsButDoesNotStartWith1ExceptionMessage = + private static String wrongLengthExceptionMessage = "Number must be 10 or 11 digits"; + private static String numberIs11DigitsButDoesNotStartWith1ExceptionMessage = "Can only have 11 digits if number starts with '1'"; - private final static String illegalCharacterExceptionMessage = + private static String illegalCharacterExceptionMessage = "Illegal character in phone number. Only digits, spaces, parentheses, hyphens or dots accepted."; - private final static String illegalAreaOrExchangeCodeMessage = + private static String illegalAreaOrExchangeCodeMessage = "Illegal Area Or Exchange Code. Only 2-9 are valid digits"; @Rule public ExpectedException expectedException = ExpectedException.none(); @Test public void cleansTheNumber() { - final String expectedNumber = "2234567890"; - final String actualNumber = new PhoneNumber("(223) 456-7890").getNumber(); + String expectedNumber = "2234567890"; + String actualNumber = new PhoneNumber("(223) 456-7890").getNumber(); assertEquals( expectedNumber, actualNumber ); } @Ignore("Remove to run test") @Test public void cleansNumbersWithDots() { - final String expectedNumber = "2234567890"; - final String actualNumber = new PhoneNumber("223.456.7890").getNumber(); + String expectedNumber = "2234567890"; + String actualNumber = new PhoneNumber("223.456.7890").getNumber(); assertEquals( expectedNumber, actualNumber ); } @Ignore("Remove to run test") @Test public void cleansNumbersWithMultipleSpaces() { - final String expectedNumber = "2234567890"; - final String actualNumber = new PhoneNumber("223 456 7890 ").getNumber(); + String expectedNumber = "2234567890"; + String actualNumber = new PhoneNumber("223 456 7890 ").getNumber(); assertEquals( expectedNumber, actualNumber ); } @@ -66,22 +66,22 @@ } @Ignore("Remove to run test") @Test public void validWhen11DigitsAndStartingWith1() { - final String expectedNumber = "2234567890"; - final String actualNumber = new PhoneNumber("12234567890").getNumber(); + String expectedNumber = "2234567890"; + String actualNumber = new PhoneNumber("12234567890").getNumber(); assertEquals( expectedNumber, actualNumber ); } @Ignore("Remove to run test") @Test public void validWhen11DigitsAndStartingWith1EvenWithPunctuation() { - final String expectedNumber = "2234567890"; - final String actualNumber = new PhoneNumber("+1 (223) 456-7890").getNumber(); + String expectedNumber = "2234567890"; + String actualNumber = new PhoneNumber("+1 (223) 456-7890").getNumber(); assertEquals( expectedNumber, actualNumber ); }