spec/season_spec.rb in timely-0.0.2 vs spec/season_spec.rb in timely-0.1.0

@@ -4,56 +4,53 @@
   before do
     # 1st and 3rd Quarter
     @simple_low_season = Timely::Season.new
     @simple_low_season.date_groups.build(:start_date => '2009-01-01'.to_date, :end_date => '2009-03-31'.to_date)
     @simple_low_season.date_groups.build(:start_date => '2009-07-01'.to_date, :end_date => '2009-09-30'.to_date)
-    @simple_low_season.save!
 
     # 2nd and 4th Quarter
     @simple_high_season = Timely::Season.new
     @simple_high_season.date_groups.build(:start_date => '2009-04-01'.to_date, :end_date => '2009-06-30'.to_date)
     @simple_high_season.date_groups.build(:start_date => '2009-10-01'.to_date, :end_date => '2009-12-31'.to_date)
-    @simple_high_season.save!
   end
 
   it "be able to tell if a date is in or out of its season" do
     low_season_date = '2009-02-22'.to_date
     high_season_date = '2009-04-22'.to_date
 
-    @simple_low_season.includes_date?(low_season_date).should be_true
-    @simple_high_season.includes_date?(low_season_date).should_not be_true
+    expect(@simple_low_season.includes_date?(low_season_date)).to be true
+    expect(@simple_high_season.includes_date?(low_season_date)).to_not be true
 
-    @simple_low_season.includes_date?(high_season_date).should_not be_true
-    @simple_high_season.includes_date?(high_season_date).should be_true
+    expect(@simple_low_season.includes_date?(high_season_date)).to_not be true
+    expect(@simple_high_season.includes_date?(high_season_date)).to be true
   end
 
   it "should be able to tell the boundary range (the range including the absolute first and last date) of itself" do
-    @simple_low_season.boundary_range.should eql('2009-01-01'.to_date..'2009-09-30'.to_date)
-    @simple_high_season.boundary_range.should eql('2009-04-01'.to_date..'2009-12-31'.to_date)
+    expect(@simple_low_season.boundary_range).to eq('2009-01-01'.to_date..'2009-09-30'.to_date)
+    expect(@simple_high_season.boundary_range).to eq('2009-04-01'.to_date..'2009-12-31'.to_date)
   end
 end
 
 
 describe Timely::Season, 'when asked to build season for given dates' do
-  before do
-    @dates = [Date.current + 1, Date.current + 4, Date.current + 5]
-  end
+  subject(:season) { Timely::Season.build_season_for(dates) }
 
-  it "should generate proper season" do
-    season = Timely::Season.build_season_for(@dates)
-    season.class.should == Timely::Season
-    season.date_groups.size.should == 3
-    season.date_groups.first.start_date.should == (Date.current + 1)
-    season.date_groups.last.start_date.should == (Date.current + 5)
-    season.date_groups.last.end_date.should == (Date.current + 5)
-    @dates = []
-    season = Timely::Season.build_season_for(@dates)
-    season.class.should == Timely::Season
-    season.date_groups.size.should == 0
+  context 'when three dates' do
+    let(:dates) { [Date.current + 1, Date.current + 4, Date.current + 5] }
+    its(:class) { should eq Timely::Season }
+    its('date_groups.size') { should eq 3 }
+
+    it "should generate proper date groups" do
+      expect(season.date_groups.first.start_date).to eq (Date.current + 1)
+      expect(season.date_groups.last.start_date).to eq (Date.current + 5)
+      expect(season.date_groups.last.end_date).to eq (Date.current + 5)
+    end
   end
 
-
-
+  context 'when dates are empty' do
+    let(:dates) { [] }
+    its(:date_groups) { should be_empty }
+  end
 end
 
 
 # == Schema Information
 #