instrumentation_spec.rb in teaspoon-0.9.0

- old
+ new
@@ -5,99 +5,105 @@
 
 describe Teaspoon::Instrumentation do
 
   subject { Teaspoon::Instrumentation }
 
-  let(:asset) { double(source: source, pathname: 'path/to/instrument.js') }
+  let(:asset) { double(source: source, pathname: "path/to/instrument.js") }
   let(:source) { "function add(a, b) { return a + b } // ☃ " }
-  let(:response) { [200, {"Content-Type" => "application/javascript"}, asset] }
-  let(:env) { {"QUERY_STRING" => "instrument=true"} }
+  let(:response) { [200, { "Content-Type" => "application/javascript" }, asset] }
+  let(:env) { { "QUERY_STRING" => "instrument=true" } }
 
   describe ".add_to" do
 
     before do
-      Teaspoon::Instrumentation.stub(:executable).and_return("/path/to/istanbul")
+      allow(Teaspoon::Instrumentation).to receive(:executable).and_return("/path/to/istanbul")
     end
 
     before do
-      Teaspoon::Instrumentation.stub(:add?).and_return(true)
-      asset.should_receive(:clone).and_return(asset)
+      allow(Teaspoon::Instrumentation).to receive(:add?).and_return(true)
+      expect(asset).to receive(:clone).and_return(asset)
 
-      File.stub(:open)
-      subject.any_instance.stub(:instrument).and_return(source + " // instrumented")
+      allow(File).to receive(:open)
+      allow_any_instance_of(subject).to receive(:instrument).and_return(source + " // instrumented")
 
       path = nil
       Dir.mktmpdir { |p| path = p }
-      Dir.stub(:mktmpdir).and_yield(path)
+      allow(Dir).to receive(:mktmpdir).and_yield(path)
       @output = File.join(path, "instrument.js")
     end
 
     it "writes the file to a tmp path" do
-      file = double('file')
-      File.should_receive(:open).with(@output, "w").and_yield(file)
-      file.should_receive(:write).with("function add(a, b) { return a + b } // ☃ ")
+      file = double("file")
+      expect(File).to receive(:open).with(@output, "w").and_yield(file)
+      expect(file).to receive(:write).with("function add(a, b) { return a + b } // ☃ ")
       subject.add_to(response, env)
     end
 
     it "instruments the javascript file" do
-      subject.any_instance.should_receive(:instrument).with(@output).and_return("_instrumented_")
+      expect_any_instance_of(subject).to receive(:instrument).with(@output).and_return("_instrumented_")
       subject.add_to(response, env)
     end
 
     it "replaces the response array with the appropriate information" do
-      response = [666, {"Content-Type" => "application/javascript"}, asset]
-      expected = [666, {"Content-Type" => "application/javascript", "Content-Length" => "59"}, asset]
+      response = [666, { "Content-Type" => "application/javascript" }, asset]
+      expected = [666, { "Content-Type" => "application/javascript", "Content-Length" => "59" }, asset]
 
       expect(subject.add_to(response, env)).to eq(expected)
     end
 
+    it "raises an exception if istanbul fails" do
+      `(exit 1)`
+      allow(subject).to receive(:`)
+      allow_any_instance_of(subject).to receive(:instrument).and_call_original
+      expect { subject.add_to(response, env) }.to raise_error(
+        Teaspoon::DependencyFailure, "Could not generate instrumentation for instrument.js."
+      )
+    end
+
   end
 
   describe ".add?" do
 
     before do
-      Teaspoon::Instrumentation.stub(:executable).and_return("/path/to/istanbul")
+      allow(Teaspoon::Instrumentation).to receive(:executable).and_return("/path/to/istanbul")
     end
 
     it "returns true when everything is good" do
-      expect(subject.add?(response, {"QUERY_STRING" => "instrument=true"})).to be(true)
-      expect(subject.add?(response, {"QUERY_STRING" => "instrument=1"})).to be(true)
+      expect(subject.add?(response, "QUERY_STRING" => "instrument=true")).to be(true)
+      expect(subject.add?(response, "QUERY_STRING" => "instrument=1")).to be(true)
     end
 
     it "doesn't if the query param isn't set (or isn't something we care about)" do
       expect(subject.add?(response, {})).to_not be(true)
-      expect(subject.add?(response, {"QUERY_STRING" => "instrument=foo"})).to_not be(true)
+      expect(subject.add?(response, "QUERY_STRING" => "instrument=foo")).to_not be(true)
     end
 
     it "doesn't if response isn't 200" do
-      expect(subject.add?([404, {"Content-Type" => "application/javascript"}, asset], env)).to_not be(true)
+      expect(subject.add?([404, { "Content-Type" => "application/javascript" }, asset], env)).to_not be(true)
     end
 
     it "doesn't when the content type isn't application/javascript" do
-      expect(subject.add?([200, {"Content-Type" => "foo/bar"}, asset], env)).to_not be(true)
+      expect(subject.add?([200, { "Content-Type" => "foo/bar" }, asset], env)).to_not be(true)
     end
 
     it "doesn't if there's no executable" do
-      subject.should_receive(:executable).and_return(false)
+      expect(subject).to receive(:executable).and_return(false)
       expect(subject.add?(response, env)).to_not be(true)
     end
 
     it "doesn't if there's no asset" do
-      expect(subject.add?([404, {"Content-Type" => "application/javascript"}, []], env)).to_not be(true)
+      expect(subject.add?([404, { "Content-Type" => "application/javascript" }, []], env)).to_not be(true)
     end
 
   end
 
   describe "integration" do
 
-    let(:asset) { Rails.application.assets.find_asset('instrumented1.coffee') }
+    let(:asset) { Rails.application.assets.find_asset("instrumented1.coffee") }
 
-    before do
-      pending("needs istanbul to be installed") unless Teaspoon::Instrumentation.executable
-    end
-
     it "instruments a file" do
-      status, headers, asset = subject.add_to(response, {"QUERY_STRING" => "instrument=true"})
+      pending("needs istanbul to be installed") unless Teaspoon::Instrumentation.executable
+      status, headers, asset = subject.add_to(response, "QUERY_STRING" => "instrument=true")
       expect(status).to eq(200)
       expect(headers).to include("Content-Type" => "application/javascript")
       expect(asset.source).to match(/var __cov_.+ = \(Function\('return this'\)\)\(\);/)
     end
 