.rubocop_todo.yml in stanford-mods-2.6.1 vs .rubocop_todo.yml in stanford-mods-2.6.2

@@ -1,48 +1,28 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-11-14 11:35:35 -0800 using RuboCop version 0.60.0.
+# on 2020-03-13 16:37:30 -0700 using RuboCop version 0.80.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
-# Include: **/*.gemfile, **/Gemfile, **/gems.rb
-Bundler/OrderedGems:
-  Exclude:
-    - 'Gemfile'
-
-# Offense count: 1
-# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: outdent, indent
 Layout/AccessModifierIndentation:
   Exclude:
     - 'lib/stanford-mods/origin_info.rb'
 
 # Offense count: 22
 # Cop supports --auto-correct.
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
     - 'spec/imprint_spec.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
-  Exclude:
-    - 'spec/fixtures/searchworks_imprint_data.rb'
-    - 'spec/fixtures/searchworks_pub_date_data.rb'
-    - 'spec/fixtures/spotlight_pub_date_data.rb'
-
 # Offense count: 12
 # Cop supports --auto-correct.
 Layout/BlockEndNewline:
   Exclude:
     - 'spec/name_spec.rb'
@@ -69,15 +49,27 @@
 Layout/EmptyLineAfterMagicComment:
   Enabled: false
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
 
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'spec/fixtures/searchworks_imprint_data.rb'
+    - 'spec/fixtures/searchworks_pub_date_data.rb'
+    - 'spec/fixtures/spotlight_pub_date_data.rb'
+
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
 Layout/MultilineArrayBraceLayout:
@@ -118,11 +110,12 @@
   Exclude:
     - 'spec/imprint_spec.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
 Layout/SpaceAroundOperators:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
 
 # Offense count: 2
@@ -139,13 +132,13 @@
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
     - 'spec/searchworks_spec.rb'
 
-# Offense count: 32
+# Offense count: 31
 Metrics/AbcSize:
-  Max: 58
+  Max: 57
 
 # Offense count: 97
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
@@ -158,16 +151,10 @@
 
 # Offense count: 18
 Metrics/CyclomaticComplexity:
   Max: 32
 
-# Offense count: 116
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 199
-
 # Offense count: 31
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 52
 
@@ -181,61 +168,55 @@
 Naming/FileName:
   Exclude:
     - 'lib/stanford-mods.rb'
 
 # Offense count: 24
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'spec/geo_spatial_spec.rb'
     - 'spec/name_spec.rb'
     - 'spec/origin_info_spec.rb'
     - 'spec/physical_location_spec.rb'
     - 'spec/searchworks_basic_spec.rb'
 
 # Offense count: 3
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, IgnoredPatterns.
 # SupportedStyles: snake_case, camelCase
 Naming/MethodName:
   Exclude:
     - 'lib/stanford-mods/origin_info.rb'
     - 'lib/stanford-mods/searchworks.rb'
 
 # Offense count: 2
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/stanford-mods/imprint.rb'
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'lib/stanford-mods/origin_info.rb'
 
-# Offense count: 2
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
-  Exclude:
-    - 'lib/stanford-mods/imprint.rb'
-
-# Offense count: 8
+# Offense count: 30
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: snake_case, camelCase
 Naming/VariableName:
   Exclude:
     - 'lib/stanford-mods/imprint.rb'
     - 'lib/stanford-mods/origin_info.rb'
     - 'lib/stanford-mods/searchworks.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Performance/UnneededSort:
-  Exclude:
-    - 'lib/stanford-mods/origin_info.rb'
-
 # Offense count: 3
 RSpec/AnyInstance:
   Exclude:
     - 'spec/date_parsing_spec.rb'
 
@@ -250,11 +231,11 @@
     - 'spec/searchworks_spec.rb'
     - 'spec/searchworks_subject_raw_spec.rb'
     - 'spec/searchworks_subject_spec.rb'
     - 'spec/searchworks_title_spec.rb'
 
-# Offense count: 134
+# Offense count: 137
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Exclude:
     - 'spec/date_parsing_spec.rb'
@@ -296,11 +277,11 @@
     - 'spec/name_spec.rb'
     - 'spec/origin_info_spec.rb'
     - 'spec/physical_location_spec.rb'
     - 'spec/sw_publication_spec.rb'
 
-# Offense count: 133
+# Offense count: 134
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Exclude:
     - 'spec/date_parsing_spec.rb'
     - 'spec/imprint_spec.rb'
@@ -337,11 +318,11 @@
 # Configuration parameters: .
 # SupportedStyles: implicit, each, example
 RSpec/HookArgument:
   EnforcedStyle: each
 
-# Offense count: 931
+# Offense count: 935
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Exclude:
     - 'spec/physical_location_spec.rb'
     - 'spec/searchworks_basic_spec.rb'
@@ -372,10 +353,11 @@
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 9
 
 # Offense count: 2
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Exclude:
     - 'spec/lib/stanford-mods/coordinate_spec.rb'
 
 # Offense count: 36
@@ -405,12 +387,12 @@
   Exclude:
     - 'lib/stanford-mods/origin_info.rb'
 
 # Offense count: 30
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
 # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
 # FunctionalMethods: let, let!, subject, watch
 # IgnoredMethods: lambda, proc, it
 Style/BlockDelimiters:
   Exclude:
@@ -478,10 +460,17 @@
 # Cop supports --auto-correct.
 Style/ExpandPathArguments:
   Exclude:
     - 'stanford-mods.gemspec'
 
+# Offense count: 36
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 # Offense count: 3
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
     - 'lib/stanford-mods/date_parsing.rb'
@@ -531,17 +520,18 @@
 # SupportedOctalStyles: zero_with_o, zero_only
 Style/NumericLiteralPrefix:
   Exclude:
     - 'spec/date_parsing_spec.rb'
 
-# Offense count: 1
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
     - 'spec/**/*'
+    - 'lib/stanford-mods/origin_info.rb'
     - 'lib/stanford-mods/searchworks.rb'
 
 # Offense count: 8
 # Cop supports --auto-correct.
 Style/PerlBackrefs:
@@ -554,10 +544,30 @@
 # SupportedStyles: short, verbose
 Style/PreferredHashMethods:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
 
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/RedundantCondition:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'lib/stanford-mods/date_parsing.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantSort:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
 Style/RegexpLiteral:
@@ -578,10 +588,21 @@
 # SupportedStyles: implicit, explicit
 Style/RescueStandardError:
   Exclude:
     - 'lib/stanford-mods/imprint.rb'
 
+# Offense count: 18
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# AllowedMethods: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/stanford-mods/date_parsing.rb'
+    - 'lib/stanford-mods/imprint.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'lib/stanford-mods/searchworks_subjects.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: only_raise, only_fail, semantic
 Style/SignalException:
@@ -615,26 +636,27 @@
 Style/SymbolProc:
   Exclude:
     - 'lib/stanford-mods/searchworks.rb'
     - 'lib/stanford-mods/searchworks_subjects.rb'
 
-# Offense count: 5
+# Offense count: 1
 # Cop supports --auto-correct.
-Style/UnneededCondition:
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArrayLiteral:
   Exclude:
-    - 'lib/stanford-mods/origin_info.rb'
-    - 'lib/stanford-mods/searchworks.rb'
+    - 'spec/date_parsing_spec.rb'
 
-# Offense count: 124
+# Offense count: 125
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize, WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
   EnforcedStyle: brackets
 
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: all_comparison_operators, equality_operators_only
+# SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only
 Style/YodaCondition:
   Exclude:
     - 'lib/stanford-mods/date_parsing.rb'