checkout_controller_spec.rb in spree-last-address-2.2.1

- old
+ new

@@ -1,8 +1,6 @@
-require 'spec_helper'
-
-describe Spree::CheckoutController do
+RSpec.describe Spree::CheckoutController, type: :controller do
   stub_authorization!
 
   let(:token) { 'some_token' }
   let(:user)  { create(:user, email: 'ryan@example.com') }
   let(:order) { create(:order_with_totals) }
@@ -11,41 +9,40 @@
     address = build(:address)
     address.attributes.except('created_at', 'updated_at')
   end
 
   before do
-    controller.stub spree_current_user: user
-    controller.stub current_order: order
+    allow(controller).to receive(:spree_current_user) { user }
+    allow(controller).to receive(:current_order) { order }
   end
 
   context '#before_address' do
-    it 'return nil if order.bill_address is not nil' do
+    it 'returns nil if order.bill_address is not nil' do
       order.bill_address = create(:address)
       spree_get :edit, state: 'address'
-      expect(controller.instance_eval{ @before_address }).to be_nil
+      expect(controller.instance_eval { before_address }).to be_nil
     end
 
-    it 'return nil if order.ship_address is not nil' do
+    it 'returns nil if order.ship_address is not nil' do
       order.ship_address = create(:address)
       spree_get :edit, state: 'address'
-      expect(controller.instance_eval{ @before_address }).to be_nil
+      expect(controller.instance_eval { before_address }).to be_nil
     end
 
-    it 'return last saved bill_address and ship_address of order' do
-      # save the last address when you visit checkout/delivery
-      spree_post :update, {
-        state: 'address',
-        order: {
-          bill_address_attributes: address_params,
-          use_billing: true
-        }
-      }
+    it 'returns last saved bill_address and ship_address of order' do
+      # Save the last address when you visit checkout/delivery.
+      spree_post  :update,
+                  state: 'address',
+                  order: {
+                    bill_address_attributes: address_params,
+                    use_billing: true
+                  }
 
-      # if you visit checkout/address, then last address will be appeared
+      # If you visit checkout/address, then last address will be appeared.
       order.bill_address = nil
       order.ship_address = nil
       spree_get :edit, state: 'address'
-      controller.instance_eval{ @before_address }
+      controller.instance_eval { before_address }
       expect(order.bill_address).not_to be_nil
     end
   end
 end