lib/split/goals_collection.rb in split-4.0.1 vs lib/split/goals_collection.rb in split-4.0.2

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
 module Split
   class GoalsCollection
-
-    def initialize(experiment_name, goals=nil)
+    def initialize(experiment_name, goals = nil)
       @experiment_name = experiment_name
       @goals = goals
     end
 
     def load_from_redis
@@ -13,34 +12,33 @@
     end
 
     def load_from_configuration
       goals = Split.configuration.experiment_for(@experiment_name)[:goals]
 
-      if goals.nil?
-        goals = []
-      else
+      if goals
         goals.flatten
+      else
+        []
       end
     end
 
     def save
       return false if @goals.nil?
       RedisInterface.new.persist_list(goals_key, @goals)
     end
 
     def validate!
       unless @goals.nil? || @goals.kind_of?(Array)
-        raise ArgumentError, 'Goals must be an array'
+        raise ArgumentError, "Goals must be an array"
       end
     end
 
     def delete
       Split.redis.del(goals_key)
     end
 
     private
-
-    def goals_key
-      "#{@experiment_name}:goals"
-    end
+      def goals_key
+        "#{@experiment_name}:goals"
+      end
   end
 end