.rubocop_todo.yml in split-3.4.1 vs .rubocop_todo.yml in split-4.0.0.pre

- old
+ new

@@ -1,94 +1,45 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2019-10-21 18:09:14 -0300 using RuboCop version 0.75.1. +# on 2020-07-05 01:43:26 UTC using RuboCop version 0.86.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: TreatCommentsAsGroupSeparators, Include. -# Include: **/*.gemspec -Gemspec/OrderedDependencies: - Exclude: - - 'split.gemspec' - # Offense count: 1 -# Configuration parameters: Include. -# Include: **/*.gemspec, -Gemspec/RequiredRubyVersion: - Exclude: - - 'split.gemspec' - -# Offense count: 2 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: with_first_argument, with_fixed_indentation -Layout/AlignArguments: - Exclude: - - 'lib/split.rb' - - 'lib/split/experiment_catalog.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. -# SupportedHashRocketStyles: key, separator, table -# SupportedColonStyles: key, separator, table -# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit -Layout/AlignHash: - Exclude: - - 'lib/split/helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. Layout/CommentIndentation: Exclude: - 'lib/split/experiment.rb' -# Offense count: 5 +# Offense count: 1 # Cop supports --auto-correct. Layout/ElseAlignment: Exclude: - - 'lib/split.rb' - - 'lib/split/helper.rb' - - 'lib/split/trial.rb' + - 'lib/split/experiment.rb' -# Offense count: 20 +# Offense count: 14 # Cop supports --auto-correct. -Layout/EmptyLineAfterGuardClause: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: around, only_before +Layout/EmptyLinesAroundAccessModifier: Exclude: - - 'lib/split.rb' - - 'lib/split/algorithms/weighted_sample.rb' + - 'lib/split/algorithms/block_randomization.rb' + - 'lib/split/algorithms/whiplash.rb' - 'lib/split/alternative.rb' - - 'lib/split/combined_experiments_helper.rb' - 'lib/split/configuration.rb' + - 'lib/split/dashboard/pagination_helpers.rb' + - 'lib/split/encapsulated_helper.rb' - 'lib/split/experiment.rb' - - 'lib/split/experiment_catalog.rb' - 'lib/split/goals_collection.rb' - - 'lib/split/helper.rb' + - 'lib/split/persistence/cookie_adapter.rb' + - 'lib/split/persistence/dual_adapter.rb' + - 'lib/split/redis_interface.rb' + - 'lib/split/trial.rb' - 'lib/split/user.rb' -# Offense count: 25 -# Cop supports --auto-correct. -Layout/EmptyLineAfterMagicComment: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines. -Layout/EmptyLineBetweenDefs: - Exclude: - - 'lib/split/helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Layout/EmptyLines: - Exclude: - - 'lib/split/helper.rb' - # Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only Layout/EmptyLinesAroundClassBody: @@ -114,83 +65,52 @@ # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines Layout/EmptyLinesAroundModuleBody: Exclude: - 'lib/split/encapsulated_helper.rb' -# Offense count: 3 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity. # SupportedStylesAlignWith: keyword, variable, start_of_line Layout/EndAlignment: Exclude: - - 'lib/split.rb' - - 'lib/split/helper.rb' + - 'lib/split/configuration.rb' + - 'lib/split/experiment.rb' - 'lib/split/trial.rb' -# Offense count: 4 +# Offense count: 17 # Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. -Layout/ExtraSpacing: - Exclude: - - 'lib/split/algorithms/whiplash.rb' - - 'lib/split/dashboard.rb' - - 'lib/split/metric.rb' - - 'lib/split/trial.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: special_inside_parentheses, consistent, align_braces -Layout/IndentFirstHashElement: - Exclude: - - 'split.gemspec' - -# Offense count: 3 -# Cop supports --auto-correct. # Configuration parameters: Width, IgnoredPatterns. Layout/IndentationWidth: Exclude: - - 'lib/split.rb' - - 'lib/split/helper.rb' - - 'lib/split/trial.rb' - -# Offense count: 10 -# Cop supports --auto-correct. -Layout/SpaceAfterComma: - Exclude: - - 'lib/split/algorithms/weighted_sample.rb' + - 'lib/split/algorithms/block_randomization.rb' + - 'lib/split/algorithms/whiplash.rb' + - 'lib/split/alternative.rb' - 'lib/split/configuration.rb' + - 'lib/split/dashboard/pagination_helpers.rb' - 'lib/split/encapsulated_helper.rb' - 'lib/split/experiment.rb' - - 'lib/split/metric.rb' + - 'lib/split/goals_collection.rb' + - 'lib/split/persistence/cookie_adapter.rb' + - 'lib/split/persistence/dual_adapter.rb' + - 'lib/split/redis_interface.rb' + - 'lib/split/trial.rb' - 'lib/split/user.rb' -# Offense count: 5 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space Layout/SpaceAroundEqualsInParameterDefault: Exclude: - 'lib/split/goals_collection.rb' - 'lib/split/persistence/dual_adapter.rb' - 'lib/split/persistence/redis_adapter.rb' - - 'lib/split/trial.rb' - 'lib/split/user.rb' -# Offense count: 24 +# Offense count: 15 # Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment. -Layout/SpaceAroundOperators: - Exclude: - - 'lib/split/algorithms/whiplash.rb' - - 'lib/split/alternative.rb' - - 'lib/split/metric.rb' - - 'lib/split/trial.rb' - - 'lib/split/zscore.rb' - -# Offense count: 14 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space # SupportedStylesForEmptyBraces: space, no_space Layout/SpaceBeforeBlockBraces: Exclude: @@ -198,26 +118,18 @@ - 'lib/split/experiment.rb' - 'lib/split/experiment_catalog.rb' - 'lib/split/helper.rb' - 'lib/split/trial.rb' -# Offense count: 2 +# Offense count: 35 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. -# SupportedStyles: space, no_space, compact -# SupportedStylesForEmptyBrackets: space, no_space -Layout/SpaceInsideArrayLiteralBrackets: - Exclude: - - 'lib/split/dashboard/helpers.rb' - -# Offense count: 31 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space # SupportedStylesForEmptyBraces: space, no_space Layout/SpaceInsideBlockBraces: Exclude: + - 'lib/split.rb' - 'lib/split/configuration.rb' - 'lib/split/experiment.rb' - 'lib/split/experiment_catalog.rb' - 'lib/split/helper.rb' - 'lib/split/trial.rb' @@ -236,444 +148,79 @@ # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: final_newline, final_blank_line -Layout/TrailingBlankLines: +Layout/TrailingEmptyLines: Exclude: - 'Rakefile' -# Offense count: 8 -# Configuration parameters: AllowSafeAssignment. -Lint/AssignmentInCondition: - Exclude: - - 'lib/split/combined_experiments_helper.rb' - - 'lib/split/configuration.rb' - - 'lib/split/persistence/cookie_adapter.rb' - - 'lib/split/persistence/dual_adapter.rb' - - 'lib/split/persistence/redis_adapter.rb' - -# Offense count: 4 +# Offense count: 3 # Cop supports --auto-correct. -# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. -Lint/UnusedBlockArgument: +# Configuration parameters: AllowInHeredoc. +Layout/TrailingWhitespace: Exclude: - - 'lib/split/algorithms/block_randomization.rb' - - 'lib/split/configuration.rb' - - 'lib/split/engine.rb' - - 'lib/split/metric.rb' + - 'lib/split/helper.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. -Lint/UnusedMethodArgument: - Exclude: - - 'lib/split/dashboard/helpers.rb' - - 'lib/split/persistence/cookie_adapter.rb' - # Offense count: 1 Lint/UselessAssignment: Exclude: - 'lib/split/goals_collection.rb' -# Offense count: 19 -Metrics/AbcSize: - Max: 47 - -# Offense count: 3 -# Configuration parameters: CountComments. -Metrics/ClassLength: - Max: 377 - -# Offense count: 6 -Metrics/CyclomaticComplexity: - Max: 14 - -# Offense count: 23 -# Configuration parameters: CountComments, ExcludedMethods. -Metrics/MethodLength: - Max: 66 - # Offense count: 1 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 134 - -# Offense count: 8 -Metrics/PerceivedComplexity: - Max: 16 - -# Offense count: 4 -Naming/AccessorMethodName: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/experiment.rb' - - 'lib/split/persistence/cookie_adapter.rb' - -# Offense count: 1 -Naming/BinaryOperatorParameterName: - Exclude: - - 'lib/split/experiment.rb' - -# Offense count: 4 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. -# NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? -# MethodDefinitionMacros: define_method, define_singleton_method -Naming/PredicateName: - Exclude: - - 'spec/**/*' - - 'lib/split/experiment.rb' - - 'lib/split/helper.rb' - -# Offense count: 5 -# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: io, id, to, by, on, in, at, ip, db -Naming/UncommunicativeMethodParamName: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/zscore.rb' - -# Offense count: 6 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: snake_case, normalcase, non_integer -Naming/VariableNumber: - Exclude: - - 'lib/split/zscore.rb' - -# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, conditionals Style/AndOr: Exclude: - 'lib/split/experiment_catalog.rb' -# Offense count: 2 -# Configuration parameters: AllowedChars. -Style/AsciiComments: - Exclude: - - 'lib/split/zscore.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: percent_q, bare_percent -Style/BarePercentLiterals: - Exclude: - - 'lib/split/dashboard/pagination_helpers.rb' - -# Offense count: 8 -Style/CaseEquality: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/experiment_catalog.rb' - - 'lib/split/helper.rb' - - 'lib/split/metric.rb' - -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: is_a?, kind_of? -Style/ClassCheck: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/configuration.rb' - - 'lib/split/experiment.rb' - - 'lib/split/goals_collection.rb' - - 'lib/split/trial.rb' - # Offense count: 1 # Cop supports --auto-correct. Style/ColonMethodCall: Exclude: - 'lib/split/combined_experiments_helper.rb' # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: Keywords. -# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW -Style/CommentAnnotation: - Exclude: - - 'lib/split/configuration.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. -# SupportedStyles: assign_to_condition, assign_inside_condition -Style/ConditionalAssignment: - Exclude: - - 'lib/split/dashboard.rb' - - 'lib/split/persistence/redis_adapter.rb' - -# Offense count: 1 -# Cop supports --auto-correct. Style/DefWithParentheses: Exclude: - 'lib/split/helper.rb' -# Offense count: 29 -Style/Documentation: - Enabled: false - -# Offense count: 3 +# Offense count: 23 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: empty, nil, both -Style/EmptyElse: - Exclude: - - 'lib/split/experiment.rb' - - 'lib/split/metric.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/Encoding: - Exclude: - - 'split.gemspec' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/ExpandPathArguments: - Exclude: - - 'split.gemspec' - -# Offense count: 13 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/configuration.rb' - - 'lib/split/experiment.rb' - - 'lib/split/goals_collection.rb' - - 'lib/split/helper.rb' - - 'lib/split/persistence/dual_adapter.rb' - - 'lib/split/trial.rb' - -# Offense count: 25 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys Style/HashSyntax: Exclude: - 'Rakefile' - - 'lib/split.rb' - 'lib/split/experiment.rb' - 'lib/split/experiment_catalog.rb' - 'lib/split/helper.rb' - 'lib/split/metric.rb' - 'lib/split/persistence.rb' - 'lib/split/persistence/redis_adapter.rb' -# Offense count: 4 -Style/IdenticalConditionalBranches: - Exclude: - - 'lib/split/configuration.rb' - - 'lib/split/experiment.rb' - -# Offense count: 14 -# Cop supports --auto-correct. -Style/IfUnlessModifier: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/experiment.rb' - - 'lib/split/experiment_catalog.rb' - - 'lib/split/goals_collection.rb' - - 'lib/split/metric.rb' - - 'lib/split/trial.rb' - - 'lib/split/user.rb' - # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline Style/MethodDefParentheses: Exclude: - 'lib/split/configuration.rb' -# Offense count: 1 +# Offense count: 9 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, Autocorrect. -# SupportedStyles: module_function, extend_self -Style/ModuleFunction: - Exclude: - - 'lib/split.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: literals, strict -Style/MutableConstant: - Exclude: - - 'lib/split/experiment.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: both, prefix, postfix -Style/NegatedIf: - Exclude: - - 'lib/split/user.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: IncludeSemanticChanges. -Style/NonNilCheck: - Exclude: - - 'lib/split/configuration.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/Not: - Exclude: - - 'lib/split/experiment_catalog.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: Strict. -Style/NumericLiterals: - MinDigits: 9 - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. -# SupportedStyles: predicate, comparison -Style/NumericPredicate: - Exclude: - - 'spec/**/*' - - 'lib/split/experiment.rb' - - 'lib/split/trial.rb' - - 'lib/split/user.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/ParallelAssignment: - Exclude: - - 'lib/split/experiment_catalog.rb' - - 'lib/split/persistence/cookie_adapter.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: short, verbose -Style/PreferredHashMethods: - Exclude: - - 'lib/split/configuration.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: compact, exploded -Style/RaiseArgs: - Exclude: - - 'lib/split/configuration.rb' - - 'lib/split/experiment.rb' - -# Offense count: 6 -# Cop supports --auto-correct. -Style/RedundantParentheses: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/zscore.rb' - -# Offense count: 11 -# Cop supports --auto-correct. # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Exclude: - 'lib/split/alternative.rb' - 'lib/split/experiment.rb' - - 'lib/split/experiment_catalog.rb' - 'lib/split/helper.rb' - - 'lib/split/metric.rb' - 'lib/split/zscore.rb' -# Offense count: 21 +# Offense count: 258 # Cop supports --auto-correct. -Style/RedundantSelf: - Exclude: - - 'lib/split.rb' - - 'lib/split/alternative.rb' - - 'lib/split/configuration.rb' - - 'lib/split/experiment.rb' - - 'lib/split/extensions/string.rb' - - 'lib/split/metric.rb' - - 'lib/split/persistence/dual_adapter.rb' - - 'lib/split/persistence/redis_adapter.rb' - - 'lib/split/trial.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -Style/RescueModifier: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/configuration.rb' - -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: implicit, explicit -Style/RescueStandardError: - Exclude: - - 'lib/split/alternative.rb' - - 'lib/split/experiment.rb' - - 'lib/split/helper.rb' - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist. -# Whitelist: present?, blank?, presence, try, try! -Style/SafeNavigation: - Exclude: - - 'lib/split/configuration.rb' - - 'lib/split/helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Exclude: - - 'lib/split/algorithms/whiplash.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: . -# SupportedStyles: use_perl_names, use_english_names -Style/SpecialGlobalVars: - EnforcedStyle: use_perl_names - -# Offense count: 86 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: IgnoredMethods. -# IgnoredMethods: respond_to, define_method -Style/SymbolProc: - Exclude: - - 'lib/split/experiment.rb' - - 'lib/split/experiment_catalog.rb' - - 'lib/split/metric.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: AllowNamedUnderscoreVariables. -Style/TrailingUnderscoreVariable: - Exclude: - - 'lib/split/helper.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/ZeroLengthPredicate: - Exclude: - - 'lib/split/user.rb' - -# Offense count: 74 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 183