tunes_client.rb in spaceship-0.26.1

- old
+ new

@@ -569,10 +569,14 @@
         current["whatsNew"]["value"] = whats_new if whats_new
         current["description"]["value"] = description if description
         current["feedbackEmail"]["value"] = feedback_email if feedback_email
       end
 
+      review_user_name = build_info['reviewUserName']['value']
+      review_password = build_info['reviewPassword']['value']
+      build_info['reviewAccountRequired']['value'] = (review_user_name.to_s + review_password.to_s).length > 0
+
       # Now send everything back to iTC
       r = request(:post) do |req| # same URL, but a POST request
         req.url url
         req.body = build_info.to_json
         req.headers['Content-Type'] = 'application/json'
@@ -616,10 +620,10 @@
       build_info['significantChange']['value'] = significant_change
       build_info['testInfo']['reviewFirstName']['value'] = first_name if first_name
       build_info['testInfo']['reviewLastName']['value'] = last_name if last_name
       build_info['testInfo']['reviewPhone']['value'] = phone_number if phone_number
       build_info['testInfo']['reviewEmail']['value'] = review_email if review_email
-      build_info['testInfo']['reviewAccountRequired']['value'] = ((review_user_name || "").to_s + (review_password || "").to_s).length > 0
+      build_info['testInfo']['reviewAccountRequired']['value'] = (review_user_name.to_s + review_password.to_s).length > 0
       build_info['testInfo']['reviewUserName']['value'] = review_user_name if review_user_name
       build_info['testInfo']['reviewPassword']['value'] = review_password if review_password
       build_info['testInfo']['reviewNotes']['value'] = review_notes if review_notes
 
       r = request(:post) do |req| # same URL, but a POST request