lib/spaceship/tunes/tester.rb in spaceship-0.3.0 vs lib/spaceship/tunes/tester.rb in spaceship-0.3.1
- old
+ new
@@ -88,20 +88,18 @@
# Create new tester in iTunes Connect
# @param email (String) (required): The email of the new tester
# @param first_name (String) (optional): The first name of the new tester
# @param last_name (String) (optional): The last name of the new tester
- # @param group (String) (optional): The name of the group this tester should be added to
# @example
# Spaceship::Tunes::Tester.external.create!(email: "tester@mathiascarignani.com", first_name: "Cary", last_name:"Bennett")
# @return (Tester): The newly created tester
- def create!(email: nil, first_name: nil, last_name: nil, group: nil)
+ def create!(email: nil, first_name: nil, last_name: nil)
data = client.create_tester!(tester: self,
email: email,
first_name: first_name,
- last_name: last_name,
- group: group)
+ last_name: last_name)
self.factory(data)
end
#####################################################
# @!group App
@@ -124,10 +122,9 @@
end
# Add all testers to the app received
# @param app_id (String) (required): The app id to filter the testers
def add_all_to_app!(app_id)
- # TODO: Change to not make one request for each tester
all.each do |tester|
begin
tester.add_to_app!(app_id)
rescue => ex
if ex.to_s.include?"testerEmailExistsInternal" or ex.to_s.include?"duplicate.email"
\ No newline at end of file