build.rb in spaceship-0.20.0

- old
+ new

@@ -147,17 +147,15 @@
       #     review_user_name: nil,
       #     review_password: nil,
       #     encryption: false
       #  }
       def submit_for_beta_review!(metadata)
-        # First, enable beta testing for this train (per iTC requirement)
-        self.build_train.update_testing_status!(true, 'external')
-
         parameters = {
           app_id: self.build_train.application.apple_id,
           train: self.build_train.version_string,
           build_number: self.build_version,
+          platform: self.platform,
 
           # Required Metadata:
           changelog: "No changelog provided",
           description: "No app description provided",
           feedback_email: "contact@company.com",
@@ -175,10 +173,13 @@
           encryption: false
         }.merge(metadata)
 
         client.submit_testflight_build_for_review!(parameters)
 
+        # Last, enable beta testing for this train (per iTC requirement). This will fail until the app has been approved for beta testing
+        self.build_train.update_testing_status!(true, 'external', self)
+
         return parameters
       end
 
       # @return [String] A nicely formatted string about the state of this build
       # @examples:
@@ -198,10 +199,11 @@
 
       # This will cancel the review process for this TestFlight build
       def cancel_beta_review!
         client.remove_testflight_build_from_review!(app_id: self.build_train.application.apple_id,
                                                      train: self.build_train.version_string,
-                                              build_number: self.build_version)
+                                              build_number: self.build_version,
+                                                  platform: self.platform)
       end
     end
   end
 end
 