lib/spaceship/tunes/app_version.rb in spaceship-0.3.4 vs lib/spaceship/tunes/app_version.rb in spaceship-0.4.0

@@ -122,11 +122,10 @@
       attr_reader :marketing_url
 
       # @return (Hash) Represents the screenshots of this app version (read-only)
       attr_reader :screenshots
 
-
       attr_mapping({
         'canBetaTest' => :can_beta_test,
         'canPrepareForUpload' => :can_prepare_for_upload,
         'canRejectVersion' => :can_reject_version,
         'canSendVersionLive' => :can_send_version_live,
@@ -227,11 +226,10 @@
       # @return (String) An URL to this specific resource. You can enter this URL into your browser
       def url
         "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/app/#{self.application.apple_id}/" + (self.is_live? ? "cur" : "")
       end
 
-
       # Private methods
       def setup
         # Properly parse the AppStatus
         status = raw_data['status']
         @app_status = Tunes::AppStatus.get_from_string(status)
@@ -242,11 +240,10 @@
           # Now that's one language right here
           @screenshots[row['language']] = setup_screenshots(row)
         end
       end
 
-
       # Prefill name, keywords, etc...
       def unfold_languages
         {
           name: :name,
           keywords: :keywords,
@@ -269,66 +266,62 @@
       def supports_apple_watch
         (super != nil)
       end
 
       def primary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
-      def primary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
-        super(value)
-      end
-
       def primary_first_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def primary_second_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def secondary_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def secondary_first_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       def secondary_second_sub_category=(value)
-        value = "MZGenre.#{value}" unless value.include?"MZGenre"
+        value = "MZGenre.#{value}" unless value.include? "MZGenre"
         super(value)
       end
 
       private
+
         # generates the nested data structure to represent screenshots
-        def setup_screenshots(row)
-          screenshots = row.fetch('screenshots', {}).fetch('value', nil)
-          return [] unless screenshots
+      def setup_screenshots(row)
+        screenshots = row.fetch('screenshots', {}).fetch('value', nil)
+        return [] unless screenshots
 
-          result = []
+        result = []
 
-          screenshots.each do |device_type, value|
-            value['value'].each do |screenshot|
-              screenshot = screenshot['value']
-              result << Tunes::AppScreenshot.new({
-                url: screenshot['url'],
-                thumbnail_url: screenshot['thumbNailUrl'],
-                sort_order: screenshot['sortOrder'],
-                original_file_name: screenshot['originalFileName'],
-                device_type: device_type,
-                language: row['language']
-              })
-            end
+        screenshots.each do |device_type, value|
+          value['value'].each do |screenshot|
+            screenshot = screenshot['value']
+            result << Tunes::AppScreenshot.new({
+              url: screenshot['url'],
+              thumbnail_url: screenshot['thumbNailUrl'],
+              sort_order: screenshot['sortOrder'],
+              original_file_name: screenshot['originalFileName'],
+              device_type: device_type,
+              language: row['language']
+            })
           end
-
-          return result
         end
+
+        return result
+      end
     end
   end
 end