lib/spaceship/client.rb in spaceship-0.3.2 vs lib/spaceship/client.rb in spaceship-0.3.3

@@ -18,16 +18,20 @@
 
     attr_reader :client
     attr_accessor :cookie
 
     # The logger in which all requests are logged
-    # /tmp/spaceship.log by default
+    # /tmp/spaceship[time].log by default
     attr_accessor :logger
 
     # Invalid user credentials were provided
     class InvalidUserCredentialsError < StandardError; end
 
+    # Raised when no user credentials were passed at all
+    class NoUserCredentialsError < StandardError; end
+
+
     class UnexpectedResponse < StandardError; end
 
     # Authenticates with Apple's web services. This method has to be called once
     # to generate a valid session. The session will automatically be used from then
     # on.
@@ -69,18 +73,18 @@
         end
       end
     end
 
     # The logger in which all requests are logged
-    # /tmp/spaceship.log by default
+    # /tmp/spaceship[time].log by default
     def logger
       unless @logger
         if $verbose || ENV["VERBOSE"]
           @logger = Logger.new(STDOUT)
         else
           # Log to file by default
-          path = "/tmp/spaceship.log"
+          path = "/tmp/spaceship#{Time.now.to_i}.log"
           @logger = Logger.new(path)
         end
 
         @logger.formatter = proc do |severity, datetime, progname, msg|
           string = "[#{datetime.strftime('%H:%M:%S')}]: #{msg}\n"
@@ -139,11 +143,11 @@
         data = CredentialsManager::PasswordManager.shared_manager(user, false)
         user ||= data.username
         password ||= data.password
       end
 
-      if user.to_s.empty? or password.to_s.empty?
-        raise InvalidUserCredentialsError.new("No login data provided")
+      if user.to_s.strip.empty? or password.strip.to_s.empty?
+        raise NoUserCredentialsError.new("No login data provided")
       end
 
       send_login_request(user, password) # different in subclasses
     end