spec/acceptance/solutions_spec.rb in solve-0.8.2 vs spec/acceptance/solutions_spec.rb in solve-1.0.0.rc1

- old
+ new

@@ -1,63 +1,63 @@ require 'spec_helper' describe "Solutions" do it "chooses the correct artifact for the demands" do graph = Solve::Graph.new - graph.artifacts("mysql", "2.0.0") - graph.artifacts("mysql", "1.2.0") - graph.artifacts("nginx", "1.0.0").depends("mysql", "= 1.2.0") + graph.artifact("mysql", "2.0.0") + graph.artifact("mysql", "1.2.0") + graph.artifact("nginx", "1.0.0").depends("mysql", "= 1.2.0") result = Solve.it!(graph, [['nginx', '= 1.0.0'], ['mysql']]) result.should eql("nginx" => "1.0.0", "mysql" => "1.2.0") end it "chooses the best artifact for the demands" do graph = Solve::Graph.new - graph.artifacts("mysql", "2.0.0") - graph.artifacts("mysql", "1.2.0") - graph.artifacts("nginx", "1.0.0").depends("mysql", ">= 1.2.0") + graph.artifact("mysql", "2.0.0") + graph.artifact("mysql", "1.2.0") + graph.artifact("nginx", "1.0.0").depends("mysql", ">= 1.2.0") result = Solve.it!(graph, [['nginx', '= 1.0.0'], ['mysql']]) result.should eql("nginx" => "1.0.0", "mysql" => "2.0.0") end it "raises NoSolutionError when a solution cannot be found" do graph = Solve::Graph.new - graph.artifacts("mysql", "1.2.0") + graph.artifact("mysql", "1.2.0") lambda { Solve.it!(graph, ['mysql', '>= 2.0.0']) }.should raise_error(Solve::Errors::NoSolutionError) end it "find the correct solution when backtracking in variables introduced via demands" do graph = Solve::Graph.new - graph.artifacts("D", "1.2.0") - graph.artifacts("D", "1.3.0") - graph.artifacts("D", "1.4.0") - graph.artifacts("D", "2.0.0") - graph.artifacts("D", "2.1.0") + graph.artifact("D", "1.2.0") + graph.artifact("D", "1.3.0") + graph.artifact("D", "1.4.0") + graph.artifact("D", "2.0.0") + graph.artifact("D", "2.1.0") - graph.artifacts("C", "2.0.0").depends("D", "= 1.2.0") - graph.artifacts("C", "2.1.0").depends("D", ">= 2.1.0") - graph.artifacts("C", "2.2.0").depends("D", "> 2.0.0") + graph.artifact("C", "2.0.0").depends("D", "= 1.2.0") + graph.artifact("C", "2.1.0").depends("D", ">= 2.1.0") + graph.artifact("C", "2.2.0").depends("D", "> 2.0.0") - graph.artifacts("B", "1.0.0").depends("D", "= 1.0.0") - graph.artifacts("B", "1.1.0").depends("D", "= 1.0.0") - graph.artifacts("B", "2.0.0").depends("D", ">= 1.3.0") - graph.artifacts("B", "2.1.0").depends("D", ">= 2.0.0") + graph.artifact("B", "1.0.0").depends("D", "= 1.0.0") + graph.artifact("B", "1.1.0").depends("D", "= 1.0.0") + graph.artifact("B", "2.0.0").depends("D", ">= 1.3.0") + graph.artifact("B", "2.1.0").depends("D", ">= 2.0.0") - graph.artifacts("A", "1.0.0").depends("B", "> 2.0.0") - graph.artifacts("A", "1.0.0").depends("C", "= 2.1.0") - graph.artifacts("A", "1.0.1").depends("B", "> 1.0.0") - graph.artifacts("A", "1.0.1").depends("C", "= 2.1.0") - graph.artifacts("A", "1.0.2").depends("B", "> 1.0.0") - graph.artifacts("A", "1.0.2").depends("C", "= 2.0.0") + graph.artifact("A", "1.0.0").depends("B", "> 2.0.0") + graph.artifact("A", "1.0.0").depends("C", "= 2.1.0") + graph.artifact("A", "1.0.1").depends("B", "> 1.0.0") + graph.artifact("A", "1.0.1").depends("C", "= 2.1.0") + graph.artifact("A", "1.0.2").depends("B", "> 1.0.0") + graph.artifact("A", "1.0.2").depends("C", "= 2.0.0") result = Solve.it!(graph, [['A', '~> 1.0.0'], ['D', ">= 2.0.0"]]) result.should eql("A" => "1.0.1", @@ -67,13 +67,13 @@ end it "finds the correct solution when there is a circular dependency" do graph = Solve::Graph.new - graph.artifacts("A", "1.0.0").depends("B", "1.0.0") - graph.artifacts("B", "1.0.0").depends("C", "1.0.0") - graph.artifacts("C", "1.0.0").depends("A", "1.0.0") + graph.artifact("A", "1.0.0").depends("B", "1.0.0") + graph.artifact("B", "1.0.0").depends("C", "1.0.0") + graph.artifact("C", "1.0.0").depends("A", "1.0.0") result = Solve.it!(graph, [["A", "1.0.0"]]) result.should eql("A" => "1.0.0", "B" => "1.0.0", @@ -81,13 +81,13 @@ end it "finds the correct solution when there is a p shaped depenency chain" do graph = Solve::Graph.new - graph.artifacts("A", "1.0.0").depends("B", "1.0.0") - graph.artifacts("B", "1.0.0").depends("C", "1.0.0") - graph.artifacts("C", "1.0.0").depends("B", "1.0.0") + graph.artifact("A", "1.0.0").depends("B", "1.0.0") + graph.artifact("B", "1.0.0").depends("C", "1.0.0") + graph.artifact("C", "1.0.0").depends("B", "1.0.0") result = Solve.it!(graph, [["A", "1.0.0"]]) result.should eql("A" => "1.0.0", "B" => "1.0.0", @@ -95,32 +95,66 @@ end it "finds the correct solution when there is a diamond shaped dependency" do graph = Solve::Graph.new - graph.artifacts("A", "1.0.0") + graph.artifact("A", "1.0.0") .depends("B", "1.0.0") .depends("C", "1.0.0") - graph.artifacts("B", "1.0.0") + graph.artifact("B", "1.0.0") .depends("D", "1.0.0") - graph.artifacts("C", "1.0.0") + graph.artifact("C", "1.0.0") .depends("D", "1.0.0") - graph.artifacts("D", "1.0.0") + graph.artifact("D", "1.0.0") result = Solve.it!(graph, [["A", "1.0.0"]]) result.should eql("A" => "1.0.0", "B" => "1.0.0", "C" => "1.0.0", "D" => "1.0.0") end + it "solves when packages and constraints have prerelease elements" do + graph = Solve::Graph.new + + graph.artifact("A", "1.0.0") + .depends("B", ">= 1.0.0-alpha") + graph.artifact("B", "1.0.0-alpha") + .depends("C", "1.0.0") + graph.artifact("C", "1.0.0") + + result = Solve.it!(graph, [["A", "1.0.0"]]) + + result.should eql("A" => "1.0.0", + "B" => "1.0.0-alpha", + "C" => "1.0.0") + + end + + it "solves when packages and constraints have build elements" do + graph = Solve::Graph.new + + graph.artifact("A", "1.0.0") + .depends("B", ">= 1.0.0+build") + graph.artifact("B", "1.0.0+build") + .depends("C", "1.0.0") + graph.artifact("C", "1.0.0") + + result = Solve.it!(graph, [["A", "1.0.0"]]) + + result.should eql("A" => "1.0.0", + "B" => "1.0.0+build", + "C" => "1.0.0") + + end + it "fails with a self dependency" do graph = Solve::Graph.new - graph.artifacts("bottom", "1.0.0") - graph.artifacts("middle", "1.0.0").depends("top", "= 1.0.0").depends("middle") + graph.artifact("bottom", "1.0.0") + graph.artifact("middle", "1.0.0").depends("top", "= 1.0.0").depends("middle") demands = [["bottom", "1.0.0"],["middle", "1.0.0"]] expect { Solve.it!(graph, demands, { :sorted => true } ) }.to raise_error { |error| error.should be_a(Solve::Errors::NoSolutionError) @@ -135,32 +169,32 @@ it "tries all combinations until it finds a solution" do graph = Solve::Graph.new - graph.artifacts("A", "1.0.0").depends("B", "~> 1.0.0") - graph.artifacts("A", "1.0.1").depends("B", "~> 1.0.0") - graph.artifacts("A", "1.0.2").depends("B", "~> 1.0.0") + graph.artifact("A", "1.0.0").depends("B", "~> 1.0.0") + graph.artifact("A", "1.0.1").depends("B", "~> 1.0.0") + graph.artifact("A", "1.0.2").depends("B", "~> 1.0.0") - graph.artifacts("B", "1.0.0").depends("C", "~> 1.0.0") - graph.artifacts("B", "1.0.1").depends("C", "~> 1.0.0") - graph.artifacts("B", "1.0.2").depends("C", "~> 1.0.0") + graph.artifact("B", "1.0.0").depends("C", "~> 1.0.0") + graph.artifact("B", "1.0.1").depends("C", "~> 1.0.0") + graph.artifact("B", "1.0.2").depends("C", "~> 1.0.0") - graph.artifacts("C", "1.0.0").depends("D", "1.0.0") - graph.artifacts("C", "1.0.1").depends("D", "1.0.0") - graph.artifacts("C", "1.0.2").depends("D", "1.0.0") + graph.artifact("C", "1.0.0").depends("D", "1.0.0") + graph.artifact("C", "1.0.1").depends("D", "1.0.0") + graph.artifact("C", "1.0.2").depends("D", "1.0.0") # ensure we can't find a solution in the above - graph.artifacts("D", "1.0.0").depends("A", "< 0.0.0") + graph.artifact("D", "1.0.0").depends("A", "< 0.0.0") # Add a solution to the graph that should be reached only after # all of the others have been tried # it must be circular to ensure that no other branch can find it - graph.artifacts("A", "0.0.0").depends("B", "0.0.0") - graph.artifacts("B", "0.0.0").depends("C", "0.0.0") - graph.artifacts("C", "0.0.0").depends("D", "0.0.0") - graph.artifacts("D", "0.0.0").depends("A", "0.0.0") + graph.artifact("A", "0.0.0").depends("B", "0.0.0") + graph.artifact("B", "0.0.0").depends("C", "0.0.0") + graph.artifact("C", "0.0.0").depends("D", "0.0.0") + graph.artifact("D", "0.0.0").depends("A", "0.0.0") demands = [["A"]] result = Solve.it!(graph, demands) @@ -172,48 +206,55 @@ end it "correctly resolves when a resolution exists but it is not the latest" do graph = Solve::Graph.new - graph.artifacts("get-the-old-one", "1.0.0") + graph.artifact("get-the-old-one", "1.0.0") .depends("locked-mid-1", ">= 0.0.0") .depends("locked-mid-2", ">= 0.0.0") - graph.artifacts("get-the-old-one", "0.5.0") + graph.artifact("get-the-old-one", "0.5.0") - graph.artifacts("locked-mid-1", "2.0.0").depends("old-bottom", "= 2.0.0") - graph.artifacts("locked-mid-1", "1.3.0").depends("old-bottom", "= 0.5.0") - graph.artifacts("locked-mid-1", "1.0.0") + graph.artifact("locked-mid-1", "2.0.0").depends("old-bottom", "= 2.0.0") + graph.artifact("locked-mid-1", "1.3.0").depends("old-bottom", "= 0.5.0") + graph.artifact("locked-mid-1", "1.0.0") - graph.artifacts("locked-mid-2", "2.0.0").depends("old-bottom", "= 2.1.0") - graph.artifacts("locked-mid-2", "1.4.0").depends("old-bottom", "= 0.5.0") - graph.artifacts("locked-mid-2", "1.0.0") + graph.artifact("locked-mid-2", "2.0.0").depends("old-bottom", "= 2.1.0") + graph.artifact("locked-mid-2", "1.4.0").depends("old-bottom", "= 0.5.0") + graph.artifact("locked-mid-2", "1.0.0") - graph.artifacts("old-bottom", "2.1.0") - graph.artifacts("old-bottom", "2.0.0") - graph.artifacts("old-bottom", "1.0.0") - graph.artifacts("old-bottom", "0.5.0") + graph.artifact("old-bottom", "2.1.0") + graph.artifact("old-bottom", "2.0.0") + graph.artifact("old-bottom", "1.0.0") + graph.artifact("old-bottom", "0.5.0") demands = [["get-the-old-one"]] result = Solve.it!(graph, demands) + # ruby solver result: + # + # "get-the-old-one" => "1.0.0", + # "locked-mid-1" => "2.0.0", + # "locked-mid-2" => "1.0.0", + # "old-bottom" => "2.0.0" + result.should eql({ "get-the-old-one" => "1.0.0", - "locked-mid-1" => "2.0.0", - "locked-mid-2" => "1.0.0", - "old-bottom" => "2.0.0" + "locked-mid-1" => "1.0.0", + "locked-mid-2" => "2.0.0", + "old-bottom" => "2.1.0" }) end describe "when options[:sorted] is true" do describe "with a simple list of dependencies" do it "returns a sorted list of dependencies" do graph = Solve::Graph.new - graph.artifacts("A", "1.0.0").depends("B", "= 1.0.0") - graph.artifacts("B", "1.0.0").depends("C", "= 1.0.0") - graph.artifacts("C", "1.0.0") + graph.artifact("A", "1.0.0").depends("B", "= 1.0.0") + graph.artifact("B", "1.0.0").depends("C", "= 1.0.0") + graph.artifact("C", "1.0.0") demands = [["A"]] result = Solve.it!(graph, demands, { :sorted => true }) @@ -229,15 +270,15 @@ # in the solver's variable_table. This must not determine the sort order describe "with a constraint that depends upon an earlier constrained artifact" do it "returns a sorted list of dependencies" do graph = Solve::Graph.new - graph.artifacts("B", "1.0.0").depends("A", "= 1.0.0") - graph.artifacts("A", "1.0.0").depends("C", "= 1.0.0") - graph.artifacts("C", "1.0.0") + graph.artifact("B", "1.0.0").depends("A", "= 1.0.0") + graph.artifact("A", "1.0.0").depends("C", "= 1.0.0") + graph.artifact("C", "1.0.0") - demands = [["A"],["B"]] + demands = [["A"],["B"]] result = Solve.it!(graph, demands, { :sorted => true } ) result.should eql([ ["C", "1.0.0"], @@ -249,12 +290,12 @@ describe "when the solution is cyclic" do it "raises a Solve::Errors::UnsortableSolutionError which contains the unsorted solution" do graph = Solve::Graph.new - graph.artifacts("A", "1.0.0").depends("B", "= 1.0.0") - graph.artifacts("B", "1.0.0").depends("C", "= 1.0.0") - graph.artifacts("C", "1.0.0").depends("A", "= 1.0.0") + graph.artifact("A", "1.0.0").depends("B", "= 1.0.0") + graph.artifact("B", "1.0.0").depends("C", "= 1.0.0") + graph.artifact("C", "1.0.0").depends("A", "= 1.0.0") demands = [["A"]] expect { Solve.it!(graph, demands, { :sorted => true } ) }.to raise_error { |error| error.should be_a(Solve::Errors::UnsortableSolutionError)