.rubocop.yml in solidus_paypal_braintree-1.0.0 vs .rubocop.yml in solidus_paypal_braintree-1.1.0
- old
+ new
@@ -1,11 +1,11 @@
require:
- solidus_dev_support/rubocop
AllCops:
NewCops: enable
- TargetRubyVersion: 2.4
+ TargetRubyVersion: 2.5
Layout/FirstArgumentIndentation:
EnforcedStyle: consistent
Layout/FirstArrayElementIndentation:
@@ -15,10 +15,13 @@
EnforcedStyle: consistent
Layout/MultilineMethodCallIndentation:
EnforcedStyle: indented
+Naming/VariableNumber:
+ Enabled: false
+
# We use this extensively, the alternatives are not viable or desirable.
RSpec/AnyInstance:
Enabled: false
# No need to make the code more complex for no real gain.
@@ -35,10 +38,14 @@
# Let's set this to some really exagerate value.
RSpec/NestedGroups:
Max: 8
+# We don't use the FactoryBot mixin
+RSpec/FactoryBot/SyntaxMethods:
+ Enabled: false
+
RSpec/VerifiedDoubles:
# Sometimes you really need an "anything" double
IgnoreSymbolicNames: true
Style/FrozenStringLiteralComment:
@@ -64,5 +71,6 @@
Exclude:
- spec/models/solidus_paypal_braintree/transaction_import_spec.rb
- spec/models/solidus_paypal_braintree/response_spec.rb
- spec/models/solidus_paypal_braintree/gateway_spec.rb
- spec/controllers/solidus_paypal_braintree/client_tokens_controller_spec.rb
+ - spec/features/frontend/braintree_credit_card_checkout_spec.rb