spec/tasks_spec.rb in slackistrano-0.1.6 vs spec/tasks_spec.rb in slackistrano-0.1.7

@@ -21,11 +21,11 @@
     set :slack_run_failed, ->{ true }
     expect(Slackistrano).to receive :post
     Rake::Task['deploy:failed'].execute
   end
 
-  shared_examples_for "slack notification" do |stage, color = nil|
+  %w[starting finished failed].each do |stage|
     it "posts to slack on slack:deploy:#{stage}" do
       set "slack_run_#{stage}".to_sym, ->{ true }
       expect(Slackistrano).to receive :post
       Rake::Task["slack:deploy:#{stage}"].execute
     end
@@ -33,48 +33,50 @@
     it "does not post to slack on slack:deploy:#{stage} when disabled" do
       set "slack_run_#{stage}".to_sym, ->{ false }
       expect(Slackistrano).not_to receive :post
       Rake::Task["slack:deploy:#{stage}"].execute
     end
+  end
 
-    it "calls Slackistrano.post with all the right arguments on slack:deploy:#{stage}" do
-      set :"slack_run_#{stage}", ->{ true }
-      set :slack_team,         ->{ 'team' }
-      set :slack_token,        ->{ 'token' }
-      set :slack_webhook,      ->{ 'webhook' }
-      set :slack_channel,      ->{ 'channel' }
-      set :slack_icon_url,     ->{ 'http://icon.url' }
-      set :slack_icon_emoji,   ->{ ':emoji:' }
-      set :"slack_msg_#{stage}", ->{ 'text message' }
+  [ # stage, color, channel
+    ['starting', nil, nil],
+    ['finished', 'good', nil],
+    ['failed', 'danger', nil],
+    ['starting', nil, 'starting_channel'],
+    ['finished', 'good', 'finished_channel'],
+    ['failed', 'danger', 'failed_channel'],
+  ].each do |stage, color, channel_for_stage|
+  
+    it "calls Slackistrano.post with the right arguments for stage=#{stage}, color=#{color}, channel_for_stage=#{channel_for_stage}" do
+      set :"slack_run_#{stage}", -> { true }
+      set :slack_team,           -> { 'team' }
+      set :slack_token,          -> { 'token' }
+      set :slack_webhook,        -> { 'webhook' }
+      set :slack_channel,        -> { 'channel' }
+      set :slack_icon_url,       -> { 'http://icon.url' }
+      set :slack_icon_emoji,     -> { ':emoji:' }
+      set :"slack_msg_#{stage}", -> { 'text message' }
 
-      attachment = {text: 'text message'}
-      attachment[:color] = color unless color.nil?
+      set :"slack_channel_#{stage}", -> { channel_for_stage }
+      expected_channel = channel_for_stage || 'channel'
 
+      attachment = {text: 'text message', color: color}.reject{|k,v| v.nil?}
+
       expect(Slackistrano).to receive(:post).with(
         team: 'team',
         token: 'token',
         webhook: 'webhook',
         via_slackbot: false,
         payload: {
-          channel: 'channel',
+          channel: expected_channel,
           username: 'Slackistrano',
           icon_url: 'http://icon.url',
           icon_emoji: ':emoji:',
           attachments: [attachment]
         }
       )
       Rake::Task["slack:deploy:#{stage}"].execute
     end
   end
 
-  describe 'build is starting' do
-    it_should_behave_like "slack notification", :starting
-  end
 
-  describe 'build has finished' do
-    it_should_behave_like "slack notification", :finished, 'good'
-  end
-
-  describe 'build has failed' do
-    it_should_behave_like "slack notification", :failed, 'danger'
-  end
 end