lib/sitehub/collection/split_route_collection.rb in sitehub-0.4.2 vs lib/sitehub/collection/split_route_collection.rb in sitehub-0.4.3

@@ -1,41 +1,44 @@
 require_relative '../collection'
 require_relative 'split_route_collection/split'
 class SiteHub
   class Collection < Hash
     class SplitRouteCollection < Collection
-      class InvalidSplitException < Exception;
+      class InvalidSplitException < Exception
       end
 
-      def initialize(hash={})
+      FIXNUM_ERR_MSG = 'splits must be a Fixnum'.freeze
+      SPLIT_ERR_MSG = 'total split percentages can not be greater than 100%'.freeze
+
+      def initialize(hash = {})
         hash.each do |value, percentage|
           add(value.id, value, percentage)
         end
       end
 
-      def add id, value, percentage
-        raise InvalidSplitException, 'splits must be a Fixnum' unless percentage.is_a?(Fixnum)
+      def add(id, value, percentage)
+        raise InvalidSplitException, FIXNUM_ERR_MSG unless percentage.is_a?(Fixnum)
         lower = values.last ? values.last.upper : 0
         upper = lower + percentage
 
-        raise InvalidSplitException, 'total split percentages can not be greater than 100%' if upper > 100
+        raise InvalidSplitException, SPLIT_ERR_MSG if upper > 100
         self[id] = Split.new(lower, upper, value)
       end
 
       def resolve(*args)
         random = rand(100)
         result = values.find { |split| random >= split.lower && random < split.upper }
-        result ? result.value : nil
+        result ? result.value.resolve(*args) : nil
       end
 
-      def transform &block
+      def transform
         values.each do |split|
-          split.value = block.call(split.value)
+          split.value = yield(split.value)
         end
       end
 
-      def [] key
-        result = super
+      def [](key)
+        result = super(key)
         result && result.value
       end
 
       def valid?
         last = values.last