spec/notifier_spec.rb in simple_deploy-0.7.2 vs spec/notifier_spec.rb in simple_deploy-0.7.3

@@ -1,57 +1,45 @@
 require 'spec_helper'
 
-describe SimpleDeploy do
+describe SimpleDeploy::Notifier do
+  include_context 'stubbed config'
+  include_context 'stubbed stack', :name        => 'stack_name',
+                                   :environment => 'test'
 
   describe "with valid settings" do
     before do
-      @config_mock = mock 'config mock'
-      @logger_mock = mock 'logger mock'
-      SimpleDeploy::Config.should_receive(:new).
-                           with(:logger => @logger_mock).
-                           and_return @config_mock
-                   
       @config_mock.should_receive(:notifications).
                    exactly(1).times.
                    and_return({ 'campfire' => 'settings' })
-      @config_mock.should_receive(:logger).
-                   and_return @logger_mock
       @notifier = SimpleDeploy::Notifier.new :stack_name  => 'stack_name',
-                                             :environment => 'test',
-                                             :logger      => @logger_mock
+                                             :environment => 'test'
     end
 
+    after do
+      SimpleDeploy.release_config
+    end
+
     it "should support a basic start message" do
       campfire_mock = mock 'campfire mock'
 
-      @config_mock.should_receive(:region).with('test').and_return('us-west-1')
+      @config_mock.stub(:region).and_return('us-west-1')
 
       SimpleDeploy::Notifier::Campfire.should_receive(:new).and_return campfire_mock
       campfire_mock.should_receive(:send).with "Deployment to stack_name in us-west-1 started."
       
       @notifier.send_deployment_start_message
     end
 
     it "should include the github app & chef links in the completed message" do
-      stack_mock = mock 'stack'
       campfire_mock = mock 'campfire mock'
       environment_mock = mock 'environment mock'
-      @config_mock.should_receive(:environment).
-                   with('test').
-                   and_return environment_mock
-      @config_mock.should_receive(:region).with('test').and_return('us-west-1')
-      Stackster::Stack.should_receive(:new).
-                       with(:environment => 'test',
-                            :name        => 'stack_name',
-                            :config      => environment_mock,
-                            :logger      => @logger_mock).
-                       and_return stack_mock
-      stack_mock.should_receive(:attributes).
-                 and_return({ 'app_github_url'       => 'http://github.com/user/app',
-                              'chef_repo_github_url' => 'http://github.com/user/chef_repo',
-                              'app'                  => 'appsha',
-                              'chef_repo'            => 'chefsha' })
+      @config_mock.stub(:region).and_return('us-west-1')
+      @stack_mock.should_receive(:attributes).
+                  and_return({ 'app_github_url'       => 'http://github.com/user/app',
+                               'chef_repo_github_url' => 'http://github.com/user/chef_repo',
+                               'app'                  => 'appsha',
+                               'chef_repo'            => 'chefsha' })
       SimpleDeploy::Notifier::Campfire.should_receive(:new).
                                        and_return campfire_mock
       campfire_mock.should_receive(:send).
                     with "Deployment to stack_name in us-west-1 complete. App: http://github.com/user/app/commit/appsha Chef: http://github.com/user/chef_repo/commit/chefsha"
       @notifier.send_deployment_complete_message
@@ -59,32 +47,22 @@
 
     it "should send a message to each listed notification endpoint" do
       campfire_mock = mock 'campfire mock'
       SimpleDeploy::Notifier::Campfire.should_receive(:new).
                                        with(:environment => 'test',
-                                            :stack_name  => 'stack_name',
-                                            :config      => @config_mock).
+                                            :stack_name  => 'stack_name').
                                        and_return campfire_mock
       campfire_mock.should_receive(:send).with 'heh you guys!'
       @notifier.send 'heh you guys!'
     end
 
   end
 
   it "should not blow up if the notification section is missing" do
-    @config_mock = mock 'config mock'
-    @logger_mock = mock 'logger mock'
-    SimpleDeploy::Config.should_receive(:new).
-                         with(:logger => @logger_mock).
-                         and_return @config_mock
-                 
     @config_mock.should_receive(:notifications).
                  and_return nil
-    @config_mock.should_receive(:logger).
-                 and_return @logger_mock
     @notifier = SimpleDeploy::Notifier.new :stack_name  => 'stack_name',
-                                           :environment => 'test',
-                                           :logger      => @logger_mock
+                                           :environment => 'test'
     @notifier.send 'heh you guys!'
   end
 
 end