test/signore/repo_test.rb in signore-0.4.2 vs test/signore/repo_test.rb in signore-0.5.0

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 require 'pathname'
 require 'tempfile'
 require 'tmpdir'
 require_relative '../test_helper'
@@ -7,12 +9,21 @@
 require_relative '../../lib/signore/signature'
 require_relative '../../lib/signore/tags'
 
 module Signore
   describe Repo do
+    let(:path) { Pathname.new(Tempfile.new('').path) }
+
+    describe '.new' do
+      it 'rewrites legacy file to hashes on first access' do
+        FileUtils.cp Pathname.new('test/fixtures/signatures.legacy.yml'), path
+        Repo.new(path: path)
+        _(path.read).wont_include 'Signore::Signature'
+      end
+    end
+
     describe '#<<' do
-      let(:path) { Pathname.new(Tempfile.new('').path)                     }
       let(:sig)  { Signature.new(text: text)                               }
       let(:text) { 'Normaliser Unix c’est comme pasteuriser le camembert.' }
 
       it 'saves the provided signature to disk' do
         Repo.new(path: path) << sig
@@ -24,26 +35,37 @@
         Repo.new(path: path) << sig
         _(path.read).wont_include 'Signore::Signature'
       end
     end
 
+    describe '#empty?' do
+      it 'is true when a repo is empty' do
+        assert Repo.new(path: path).empty?
+      end
+
+      it 'is false when a repo is not empty' do
+        FileUtils.cp Pathname.new('test/fixtures/signatures.legacy.yml'), path
+        refute Repo.new(path: path).empty?
+      end
+    end
+
     describe '#find' do
       let(:path)       { Pathname.new('test/fixtures/signatures.yml') }
       let(:repo)       { Repo.new(path: path, sig_finder: sig_finder) }
-      let(:sig_finder) { fake(:sig_finder, as: :class)                }
+      let(:sig_finder) { fake(SigFinder)                              }
       let(:sigs)       { repo.sigs                                    }
       let(:store)      { YAML::Store.new(path)                        }
 
       it 'returns a random signature by default' do
         stub(sig_finder).find(sigs, tags: Tags.new) { sigs.last }
         _(repo.find).must_equal sigs.last
       end
 
       it 'returns a random signature based on required and forbidden tags' do
-        tags = Tags.new(forbidden: %w(tech), required: %w(programming security))
-        stub(sig_finder).find(sigs, tags: tags) { sigs.last }
-        _(repo.find(tags: tags)).must_equal sigs.last
+        tags = Tags.new(forbidden: %w(programming security), required: %w(tech))
+        stub(sig_finder).find(sigs, tags: tags) { sigs.first }
+        _(repo.find(tags: tags)).must_equal sigs.first
       end
 
       it 'doesn’t blow up if the path is missing' do
         begin
           tempdir = Dir.mktmpdir
@@ -53,11 +75,12 @@
           FileUtils.rmtree tempdir
         end
       end
 
       it 'keeps working with legacy YAML files' do
-        path = Pathname.new('test/fixtures/signatures.legacy.yml')
+        path = Pathname.new(Tempfile.new('').path)
+        FileUtils.cp Pathname.new('test/fixtures/signatures.legacy.yml'), path
         repo = Repo.new(path: path, sig_finder: sig_finder)
         stub(sig_finder).find(sigs, tags: Tags.new) { sigs.last }
         _(repo.find).must_equal sigs.last
       end
     end
@@ -65,10 +88,10 @@
     describe '#sigs' do
       it 'returns all the Signatures from the Repo' do
         path = Pathname.new('test/fixtures/signatures.yml')
         sigs = Repo.new(path: path).sigs
         _(sigs.size).must_equal 6
-        _(sigs.first.author).must_equal 'Clive James'
+        _(sigs.first.author).must_equal 'Gary Barnes'
         _(sigs.last.subject).must_equal 'Star Wars ending explained'
       end
     end
   end
 end