test_exception_handler.rb in sidekiq-3.0.0

- old
+ new

@@ -1,7 +1,6 @@
 require 'helper'
-require 'sidekiq'
 require 'sidekiq/exception_handler'
 require 'stringio'
 require 'logger'
 
 ExceptionHandlerTestException = Class.new(StandardError)
@@ -31,108 +30,26 @@
 
     it "logs the exception to Sidekiq.logger" do
       Component.new.invoke_exception(:a => 1)
       @str_logger.rewind
       log = @str_logger.readlines
-      assert_match /a=>1/, log[0], "didn't include the context"
-      assert_match /Something didn't work!/, log[1], "didn't include the exception message"
-      assert_match /test\/test_exception_handler.rb/, log[2], "didn't include the backtrace"
+      assert_match(/a=>1/, log[0], "didn't include the context")
+      assert_match(/Something didn't work!/, log[1], "didn't include the exception message")
+      assert_match(/test\/test_exception_handler.rb/, log[2], "didn't include the backtrace")
     end
 
     describe "when the exception does not have a backtrace" do
       it "does not fail" do
         exception = ExceptionHandlerTestException.new
         assert_nil exception.backtrace
 
         begin
           Component.new.handle_exception exception
           pass
-        rescue => e
+        rescue StandardError
           flunk "failed handling a nil backtrace"
         end
       end
     end
   end
 
-  describe "with fake Airbrake" do
-    before do
-      ::Airbrake = Minitest::Mock.new
-    end
-
-    after do
-      Object.__send__(:remove_const, "Airbrake") # HACK should probably inject Airbrake etc into this class in the future
-    end
-
-    it "notifies Airbrake" do
-      ::Airbrake.expect(:notify_or_ignore,nil,[TEST_EXCEPTION,:parameters => { :a => 1 }])
-      Component.new.invoke_exception(:a => 1)
-      ::Airbrake.verify
-    end
-  end
-
-  describe "with fake Honeybadger" do
-    before do
-      ::Honeybadger = Minitest::Mock.new
-    end
-
-    after do
-      Object.__send__(:remove_const, "Honeybadger") # HACK should probably inject Honeybadger etc into this class in the future
-    end
-
-    it "notifies Honeybadger" do
-      ::Honeybadger.expect(:notify_or_ignore,nil,[TEST_EXCEPTION,:parameters => { :a => 1 }])
-      Component.new.invoke_exception(:a => 1)
-      ::Honeybadger.verify
-    end
-  end
-
-  describe "with fake ExceptionNotifier" do
-    before do
-      ::ExceptionNotifier = MiniTest::Mock.new
-    end
-
-    after do
-      Object.__send__(:remove_const, "ExceptionNotifier")
-    end
-
-    it "notifies ExceptionNotifier" do
-      ::ExceptionNotifier.expect(:notify_exception,true,[TEST_EXCEPTION, :data => { :message => { :b => 2 } }])
-      Component.new.invoke_exception(:b => 2)
-      ::ExceptionNotifier.verify
-    end
-  end
-
-  describe "with fake Exceptional" do
-    before do
-      ::Exceptional = Class.new do
-
-        def self.context(msg)
-          @msg = msg
-        end
-
-        def self.check_context
-          @msg
-        end
-      end
-
-      ::Exceptional::Config = Minitest::Mock.new
-      ::Exceptional::Remote = Minitest::Mock.new
-      ::Exceptional::ExceptionData = Minitest::Mock.new
-    end
-
-    after do
-      Object.__send__(:remove_const, "Exceptional")
-    end
-
-    it "notifies Exceptional" do
-      ::Exceptional::Config.expect(:should_send_to_api?,true)
-      exception_data = Object.new
-      ::Exceptional::Remote.expect(:error,nil,[exception_data])
-      ::Exceptional::ExceptionData.expect(:new,exception_data,[TEST_EXCEPTION])
-      Component.new.invoke_exception(:c => 3)
-      assert_equal({:c => 3},::Exceptional.check_context,"did not record arguments properly")
-      ::Exceptional::Config.verify
-      ::Exceptional::Remote.verify
-      ::Exceptional::ExceptionData.verify
-    end
-  end
 end