spec/scss_lint/linter_spec.rb in scss-lint-0.33.0 vs spec/scss_lint/linter_spec.rb in scss-lint-0.34.0

@@ -10,10 +10,15 @@
         def visit_prop(node)
           return unless node.value.to_sass.strip == 'fail1'
           add_lint(node, 'everything offends me')
         end
 
+        def visit_class(klass)
+          return unless klass.to_s == '.badClass'
+          add_lint(klass, 'a bad class was used')
+        end
+
         # Bypasses the visit order so a control comment might not be reached before a lint is
         # added
         def visit_rule(node)
           node.children
               .select { |child| child.is_a?(Sass::Tree::PropNode) }
@@ -26,70 +31,70 @@
         end
       end
     end
 
     context 'when a disable is not present' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border: fail1;
 
           a {
             border: fail1;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
 
     context 'when a disable is present at the top level' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable Fake
         p {
           border: fail1;
 
           a {
             border: fail1;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when a disable is present at the top level for another linter' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable Bogus
         p {
           border: fail1;
         }
         p {
           border: bogus;
         }
-      CSS
+      SCSS
 
       it { should report_lint lint: 3 }
     end
 
     context 'when a linter is disabled then enabled again' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable Fake
         p {
           border: fail1;
         }
         // scss-lint:enable Fake
         p {
           border: fail1;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint line: 3 }
       it { should report_lint line: 7 }
     end
 
     context 'when a linter is disabled within a rule' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           // scss-lint:disable Fake
           border: fail1;
 
           a {
@@ -98,127 +103,127 @@
         }
 
         p {
           border: fail1;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint line: 3 }
       it { should_not report_lint line: 6 }
       it { should report_lint line: 11 }
     end
 
     context 'when more than one linter is disabled' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable Bogus, Fake
         p {
           border: fail1;
         }
 
         p {
           border: bogus;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when more than one linter is disabled without spaces between the linter names' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable Fake,Bogus
         p {
           border: fail1;
         }
 
         p {
           border: Bogus;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when more than one linter is disabled without commas between the linter names' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable Fake Bogus
         p {
           border: fail1;
         }
 
         p {
           border: bogus;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when two linters are disabled and only one is reenabled' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable Fake, Bogus
         p {
           border: fail1;
         }
         // scss-lint:enable Fake
 
         p {
           margin: fail1;
           border: bogus;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint line: 3 }
       it { should report_lint line: 8 }
     end
 
     context 'when all linters are disabled' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable all
         p {
           border: fail1;
         }
 
         p {
           margin: fail1;
           border: bogus;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when all linters are disabled and then one is re-enabled' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         // scss-lint:disable all
         p {
           border: fail1;
         }
         // scss-lint:enable Fake
 
         p {
           margin: fail1;
           border: bogus;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint line: 3 }
       it { should report_lint line: 8 }
     end
 
     context 'when a linter is bypassing the visit tree order' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           // scss-lint:disable Fake
           border: fail2;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when the command comment is next to other comments' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           // scss-lint:disable Fake
           // more comments
           border: fail2;
         }
@@ -226,23 +231,62 @@
         p {
           // more comments
           // scss-lint:disable Fake
           border: fail2;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when the command comment is at the end of a statement' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border: fail1; // scss-lint:disable Fake
           border: fail1;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'when global disable comes before an @include' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Fake
+        p {
+          border: fail1;
+        }
+
+        @include mixin(param) {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when // control comment appears in the middle of a comma sequence' do
+      let(:scss) { <<-SCSS }
+        .badClass, // scss-lint:disable Fake
+        .good-selector {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint line: 1 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'when /* control comment appears in the middle of a comma sequence' do
+      let(:scss) { <<-SCSS }
+        .badClass, /* scss-lint:disable Fake */
+        .good-selector {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint line: 1 }
       it { should report_lint line: 3 }
     end
   end
 end