lib/screengrab/runner.rb in screengrab-0.4.0 vs lib/screengrab/runner.rb in screengrab-0.5.0
- old
+ new
@@ -218,11 +218,11 @@
test_output = @executor.execute(command: instrument_command.join(" \\\n"),
print_all: true,
print_command: true)
- UI.user_error! "Tests failed" if test_output.include?("FAILURES!!!")
+ UI.user_error!("Tests failed", show_github_issues: false) if test_output.include?("FAILURES!!!")
end
end
def pull_screenshots_from_device(device_serial, device_screenshots_paths, device_type_dir_name)
UI.message "Pulling captured screenshots from the device"
@@ -301,9 +301,12 @@
return if @executor.execute(command: "adb -s #{device_serial} shell ls #{device_path}",
print_all: false,
print_command: false).include?('No such file')
yield device_path
+ rescue
+ # Some versions of ADB will have a non-zero exit status for this, which will cause the executor to raise.
+ # We can safely ignore that and treat it as if it returned 'No such file'
end
def open_screenshots_summary(device_type_dir_name)
unless @config[:skip_open_summary]
UI.message "Opening screenshots summary"