base.rb in sapience-2.5.0

- old
+ new

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 module Sapience
   # rubocop:disable ClassLength
   class Base
     # Class name to be logged
     attr_accessor :name, :filter
@@ -73,22 +74,22 @@
     def tagged(*tags, &block)
       Sapience.tagged(*tags, &block)
     end
 
     # :nodoc:
-    alias_method :with_tags, :tagged
+    alias with_tags tagged
 
     # :nodoc:
     def tags
       Sapience.tags
     end
 
     # :nodoc:
     def push_tags(*tags)
       Sapience.push_tags(*tags)
     end
-    alias_method :tags=, :push_tags
+    alias tags= push_tags
 
     # :nodoc:
     def pop_tags(quantity = 1)
       Sapience.pop_tags(quantity)
     end
@@ -266,11 +267,11 @@
         log.metric_amount = payload.delete(:metric_amount) || 1
         if (duration = payload.delete(:duration))
           return false if duration <= min_duration
           log.duration = duration
         end
-        log.payload = payload if payload.size > 0
+        log.payload = payload unless payload.empty?
       end
       self.log(log) if include_message?(log)
     end
     # rubocop:enable AbcSize, PerceivedComplexity, CyclomaticComplexity, LineLength
 
@@ -278,11 +279,11 @@
 
     def merge_tags_with_payload(payload = {})
       merged_tags = tags.dup
       if payload.is_a?(Hash)
         payload_tags = payload.delete(:tags) || []
-        merged_tags.concat(payload_tags) if payload_tags.size > 0
+        merged_tags.concat(payload_tags) unless payload_tags.empty?
       end
       merged_tags.uniq
     end
 
     # Extract the callers backtrace leaving out Sapience
@@ -295,9 +296,10 @@
     end
 
     # Measure the supplied block and log the message
     # rubocop:disable AbcSize, PerceivedComplexity, CyclomaticComplexity, LineLength
     def measure_internal(level, index, message, params)
+      params.dup
       start     = Time.now
       exception = nil
       begin
         if block_given?
           result    =