REEK in sanitize_email-1.1.6 vs REEK in sanitize_email-1.1.7

@@ -1,48 +1,37 @@
-lib/sanitize_email.rb -- 3 warnings:
-  SanitizeEmail#self.sanitary calls SanitizeEmail::Config.config twice (DuplicateMethodCall)
-  SanitizeEmail#self.sanitary has approx 6 statements (TooManyStatements)
-  SanitizeEmail::MissingBlockParameter has no descriptive comment (IrresponsibleModule)
-lib/sanitize_email/bleach.rb -- 5 warnings:
-  SanitizeEmail::Bleach#delivering_email has approx 6 statements (TooManyStatements)
-  SanitizeEmail::Bleach#delivering_email has the variable name 'o' (UncommunicativeVariableName)
-  SanitizeEmail::Bleach#delivering_email refers to message more than self (FeatureEnvy)
-  SanitizeEmail::Bleach#delivering_email refers to o more than self (FeatureEnvy)
-  SanitizeEmail::Bleach#sanitize_engaged? has approx 6 statements (TooManyStatements)
-lib/sanitize_email/config.rb -- 4 warnings:
-  SanitizeEmail::Config has no descriptive comment (IrresponsibleModule)
-  SanitizeEmail::Config#self.configure calls @config[:force_sanitize] twice (DuplicateMethodCall)
-  SanitizeEmail::Config#self.configure calls @config[:sanitized_recipients] twice (DuplicateMethodCall)
-  SanitizeEmail::Config#self.configure has approx 7 statements (TooManyStatements)
-lib/sanitize_email/deprecation.rb -- 2 warnings:
-  SanitizeEmail::Deprecation takes parameters [name, replacement] to 3 methods (DataClump)
-  SanitizeEmail::Deprecation#deprecation is controlled by argument replacement (ControlParameter)
-lib/sanitize_email/engine.rb -- 1 warning:
-  SanitizeEmail::Engine has no descriptive comment (IrresponsibleModule)
-lib/sanitize_email/mail_header_tools.rb -- 8 warnings:
-  SanitizeEmail::MailHeaderTools#self.add_original_addresses_as_headers has the variable name 'k' (UncommunicativeVariableName)
-  SanitizeEmail::MailHeaderTools#self.add_original_addresses_as_headers has the variable name 'v' (UncommunicativeVariableName)
-  SanitizeEmail::MailHeaderTools#self.prepend_environment_to_subject calls Rails.env twice (DuplicateMethodCall)
-  SanitizeEmail::MailHeaderTools#self.update_header calls (index + 1) twice (DuplicateMethodCall)
-  SanitizeEmail::MailHeaderTools#self.update_header has the parameter name 'k' (UncommunicativeParameterName)
-  SanitizeEmail::MailHeaderTools#self.update_header has the parameter name 'v' (UncommunicativeParameterName)
-  SanitizeEmail::MailHeaderTools#self.update_header has the variable name 'a' (UncommunicativeVariableName)
-  SanitizeEmail::MailHeaderTools#self.update_header is controlled by argument v (ControlParameter)
+lib/sanitize_email/bleach.rb -- 1 warning:
+  [59]:SanitizeEmail::Bleach#sanitize_engaged? performs a nil-check (NilCheck)
+lib/sanitize_email/config.rb -- 3 warnings:
+  [64, 72]:SanitizeEmail::Config#self.configure calls @config[:force_sanitize] 2 times (DuplicateMethodCall)
+  [58, 62]:SanitizeEmail::Config#self.configure calls @config[:sanitized_recipients] 2 times (DuplicateMethodCall)
+  [64]:SanitizeEmail::Config#self.configure performs a nil-check (NilCheck)
+lib/sanitize_email/deprecation.rb -- 1 warning:
+  [18, 29, 40]:SanitizeEmail::Deprecation takes parameters [name, replacement] to 3 methods (DataClump)
+lib/sanitize_email/mail_header_tools.rb -- 1 warning:
+  [41, 42]:SanitizeEmail::MailHeaderTools#self.prepend_custom_subject calls message.subject 2 times (DuplicateMethodCall)
 lib/sanitize_email/overridden_addresses.rb -- 7 warnings:
-  SanitizeEmail::OverriddenAddresses has no descriptive comment (IrresponsibleModule)
-  SanitizeEmail::OverriddenAddresses#inject_user_names contains iterators nested 2 deep (NestedIterators)
-  SanitizeEmail::OverriddenAddresses#inject_user_names doesn't depend on instance state (UtilityFunction)
-  SanitizeEmail::OverriddenAddresses#inject_user_names refers to real_recipient more than self (FeatureEnvy)
-  SanitizeEmail::OverriddenAddresses#override_email has approx 10 statements (TooManyStatements)
-  SanitizeEmail::OverriddenAddresses::MissingTo has no descriptive comment (IrresponsibleModule)
-  SanitizeEmail::OverriddenAddresses::UnknownOverride has no descriptive comment (IrresponsibleModule)
-lib/sanitize_email/railtie.rb -- 1 warning:
-  SanitizeEmail::Railtie has no descriptive comment (IrresponsibleModule)
-lib/sanitize_email/rspec_matchers.rb -- 2 warnings:
-  SanitizeEmail::RspecMatchers#get_username doesn't depend on instance state (UtilityFunction)
-  SanitizeEmail::RspecMatchers#get_username refers to email_message more than self (FeatureEnvy)
-lib/sanitize_email/test_helpers.rb -- 4 warnings:
-  SanitizeEmail::TestHelpers takes parameters [mail_or_part, matcher, part] to 3 methods (DataClump)
-  SanitizeEmail::TestHelpers#array_matching refers to mail_or_part more than self (FeatureEnvy)
-  SanitizeEmail::TestHelpers#string_matching refers to mail_or_part more than self (FeatureEnvy)
-  SanitizeEmail::TestHelpers::UnexpectedMailType has no descriptive comment (IrresponsibleModule)
-lib/sanitize_email/version.rb -- 0 warnings
+  [6]:SanitizeEmail::OverriddenAddresses has at least 8 instance variables (TooManyInstanceVariables)
+  [25, 26, 27, 28, 29]:SanitizeEmail::OverriddenAddresses#initialize calls SanitizeEmail::Config.config 5 times (DuplicateMethodCall)
+  [109]:SanitizeEmail::OverriddenAddresses#inject_user_names contains iterators nested 2 deep (NestedIterators)
+  [103]:SanitizeEmail::OverriddenAddresses#inject_user_names doesn't depend on instance state (UtilityFunction)
+  [105]:SanitizeEmail::OverriddenAddresses#inject_user_names performs a nil-check (NilCheck)
+  [56]:SanitizeEmail::OverriddenAddresses#override_email has approx 10 statements (TooManyStatements)
+  [125]:SanitizeEmail::OverriddenAddresses#sanitize_addresses is controlled by argument type (ControlParameter)
+lib/sanitize_email/rspec_matchers.rb -- 1 warning:
+  [35]:SanitizeEmail::RspecMatchers#get_username doesn't depend on instance state (UtilityFunction)
+lib/sanitize_email/test_helpers.rb -- 3 warnings:
+  [11, 15, 28, 33]:SanitizeEmail::TestHelpers takes parameters [mail_or_part, matcher, part] to 4 methods (DataClump)
+  [29, 29]:SanitizeEmail::TestHelpers#array_matching refers to mail_or_part more than self (FeatureEnvy)
+  [16, 18, 20]:SanitizeEmail::TestHelpers#string_matching refers to mail_or_part more than self (FeatureEnvy)
+lib/sanitize_email.rb -- 1 warning:
+  [84, 85]:SanitizeEmail#self.sanitary calls SanitizeEmail::Config.config 2 times (DuplicateMethodCall)
+spec/sanitize_email_spec.rb -- 9 warnings:
+  [57, 57]:configure_sanitize_email calls options[:force_sanitize] 2 times (DuplicateMethodCall)
+  [55, 55]:configure_sanitize_email calls options[:local_environments] 2 times (DuplicateMethodCall)
+  [56, 56]:configure_sanitize_email calls options[:sanitized_recipients] 2 times (DuplicateMethodCall)
+  [41]:configure_sanitize_email doesn't depend on instance state (UtilityFunction)
+  [41]:configure_sanitize_email has approx 15 statements (TooManyStatements)
+  [57]:configure_sanitize_email performs a nil-check (NilCheck)
+  [68]:funky_config contains iterators nested 2 deep (NestedIterators)
+  [62]:funky_config doesn't depend on instance state (UtilityFunction)
+  [62]:funky_config has approx 10 statements (TooManyStatements)
+27 total warnings