generic_reference.rb in ruby-jss-1.5.1

- old
+ new

@@ -23,10 +23,18 @@
 #
 #
 
 module Jamf
 
+  # TODO:  This class and the referable mixin should be removed -
+  # According to the Jamf Pro API Styleguide/Specs:
+  #
+  #   - Objects which reference other objects MUST only reference by its Jamf Pro-assigned numerical ID.
+  #
+  # and in newer endpoints that is what we're seeing, e.g. fields like
+  # 'siteId' and 'categoryId'
+
   # This class is a reference to an individual API object from some other
   # API object.
   #
   # This class is subclassed automatically when the {Jamf::Referable} module
   # is included into a class.
@@ -51,10 +59,10 @@
     #####################################
 
     OBJECT_MODEL = {
 
       id: {
-        class: :integer,
+        class: :j_id,
         identifier: :primary,
         readonly: true
       },
 
       name: {