lib/rubocop/cop/lint/useless_assignment.rb in rubocop-0.82.0 vs lib/rubocop/cop/lint/useless_assignment.rb in rubocop-0.83.0
- old
+ new
@@ -29,11 +29,10 @@
# def some_method
# some_var = 1
# do_something(some_var)
# end
class UselessAssignment < Cop
- include NameSimilarity
MSG = 'Useless assignment to variable - `%<variable>s`.'
def join_force?(force_class)
force_class == VariableForce
end
@@ -92,10 +91,12 @@
" Use `#{assignment.operator.sub(/=$/, '')}` " \
"instead of `#{assignment.operator}`."
end
def similar_name_message(variable)
- similar_name = find_similar_name(variable.name, variable.scope)
+ variable_like_names = collect_variable_like_names(variable.scope)
+ similar_name = NameSimilarity.find_similar_name(variable.name,
+ variable_like_names)
" Did you mean `#{similar_name}`?" if similar_name
end
# TODO: More precise handling (rescue, ensure, nested begin, etc.)
def return_value_node_of_scope(scope)