spec/rubocop/cop/rspec/verified_doubles_spec.rb in rubocop-rspec-1.4.1 vs spec/rubocop/cop/rspec/verified_doubles_spec.rb in rubocop-rspec-1.5.0

@@ -1,15 +1,53 @@
 # encoding: utf-8
 
-describe RuboCop::Cop::RSpec::VerifiedDoubles do
-  subject(:cop) { described_class.new }
+describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
+  subject(:cop) { described_class.new(config) }
 
-  it 'finds `double` instead of a verifying double' do
+  it 'finds a `double` instead of an `instance_double`' do
     inspect_source(cop, ['it do',
                          '  foo = double("Widget")',
                          'end'])
     expect(cop.messages)
       .to eq(['Prefer using verifying doubles over normal doubles.'])
     expect(cop.highlights).to eq(['double("Widget")'])
     expect(cop.offenses.map(&:line).sort).to eq([2])
+  end
+
+  it 'finds a `spy` instead of an `instance_spy`' do
+    inspect_source(cop, ['it do',
+                         '  foo = spy("Widget")',
+                         'end'])
+    expect(cop.messages)
+      .to eq(['Prefer using verifying doubles over normal doubles.'])
+    expect(cop.highlights).to eq(['spy("Widget")'])
+    expect(cop.offenses.map(&:line).sort).to eq([2])
+  end
+
+  it 'find doubles whose name is a symbol' do
+    inspect_source(cop, ['it do',
+                         '  foo = double(:widget)',
+                         'end'])
+    expect(cop.messages)
+      .to eq(['Prefer using verifying doubles over normal doubles.'])
+    expect(cop.highlights).to eq(['double(:widget)'])
+    expect(cop.offenses.map(&:line).sort).to eq([2])
+  end
+
+  context 'when configured to ignore symbolic names' do
+    let(:cop_config) { { 'IgnoreSymbolicNames' => true } }
+
+    it 'ignores doubles whose name is a symbol' do
+      inspect_source(cop, ['it do',
+                           '  foo = double(:widget)',
+                           'end'])
+      expect(cop.messages).to be_empty
+    end
+  end
+
+  it 'ignores doubles without a name' do
+    inspect_source(cop, ['it do',
+                         '  foo = double',
+                         'end'])
+    expect(cop.messages).to be_empty
   end
 end