spec/rubocop/cop/rspec/leading_subject_spec.rb in rubocop-rspec-1.15.1 vs spec/rubocop/cop/rspec/leading_subject_spec.rb in rubocop-rspec-1.16.0

- old
+ new

@@ -2,33 +2,33 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do subject(:cop) { described_class.new } it 'checks subject below let' do - expect_violation(<<-RUBY) + expect_offense(<<-RUBY) RSpec.describe User do let(:params) { foo } subject { described_class.new } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations. end RUBY end it 'checks subject below let!' do - expect_violation(<<-RUBY) + expect_offense(<<-RUBY) RSpec.describe User do let!(:params) { foo } subject { described_class.new } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations. end RUBY end it 'approves of subject above let' do - expect_no_violations(<<-RUBY) + expect_no_offenses(<<-RUBY) RSpec.describe User do context 'blah' do end subject { described_class.new } @@ -37,11 +37,11 @@ end RUBY end it 'handles subjects in contexts' do - expect_no_violations(<<-RUBY) + expect_no_offenses(<<-RUBY) RSpec.describe User do let(:params) { foo } context "when something happens" do subject { described_class.new } @@ -49,10 +49,10 @@ end RUBY end it 'handles subjects in tests' do - expect_no_violations(<<-RUBY) + expect_no_offenses(<<-RUBY) RSpec.describe User do # This shouldn't really ever happen in a sane codebase but I still # want to avoid false positives it "doesn't mind me calling a method called subject in the test" do let(foo)