spec/rubocop/cop/rspec/instance_variable_spec.rb in rubocop-rspec-1.15.1 vs spec/rubocop/cop/rspec/instance_variable_spec.rb in rubocop-rspec-1.16.0
- old
+ new
@@ -1,46 +1,46 @@
RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
subject(:cop) { described_class.new }
it 'finds an instance variable inside a describe' do
- expect_violation(<<-RUBY)
+ expect_offense(<<-RUBY)
describe MyClass do
before { @foo = [] }
it { expect(@foo).to be_empty }
^^^^ Use `let` instead of an instance variable.
end
RUBY
end
it 'ignores non-spec blocks' do
- expect_no_violations(<<-RUBY)
+ expect_no_offenses(<<-RUBY)
not_rspec do
before { @foo = [] }
it { expect(@foo).to be_empty }
end
RUBY
end
it 'finds an instance variable inside a shared example' do
- expect_violation(<<-RUBY)
+ expect_offense(<<-RUBY)
shared_examples 'shared example' do
it { expect(@foo).to be_empty }
^^^^ Use `let` instead of an instance variable.
end
RUBY
end
it 'ignores an instance variable without describe' do
- expect_no_violations(<<-RUBY)
+ expect_no_offenses(<<-RUBY)
@foo = []
@foo.empty?
RUBY
end
# Regression test for nevir/rubocop-rspec#115
it 'ignores instance variables outside of specs' do
- expect_no_violations(<<-RUBY, filename: 'lib/source_code.rb')
+ expect_no_offenses(<<-RUBY, 'lib/source_code.rb')
feature do
@foo = bar
@foo
end
@@ -53,20 +53,20 @@
let(:cop_config) do
{ 'AssignmentOnly' => true }
end
it 'flags an instance variable when it is also assigned' do
- expect_violation(<<-RUBY)
+ expect_offense(<<-RUBY)
describe MyClass do
before { @foo = [] }
it { expect(@foo).to be_empty }
^^^^ Use `let` instead of an instance variable.
end
RUBY
end
it 'ignores an instance variable when it is not assigned' do
- expect_no_violations(<<-RUBY)
+ expect_no_offenses(<<-RUBY)
describe MyClass do
it { expect(@foo).to be_empty }
end
RUBY
end