spec/rubocop/cop/rspec/example_wording_spec.rb in rubocop-rspec-1.12.0 vs spec/rubocop/cop/rspec/example_wording_spec.rb in rubocop-rspec-1.13.0
- old
+ new
@@ -1,13 +1,13 @@
-describe RuboCop::Cop::RSpec::ExampleWording, :config do
+RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
subject(:cop) { described_class.new(config) }
context 'with configuration' do
let(:cop_config) do
{
'CustomTransform' => { 'have' => 'has', 'not' => 'does not' },
- 'IgnoredWords' => %w(only really)
+ 'IgnoredWords' => %w(only really)
}
end
it 'ignores non-example blocks' do
expect_no_violations('foo "should do something" do; end')
@@ -35,19 +35,38 @@
^^^^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
end
RUBY
end
+ it 'finds leading its' do
+ expect_violation(<<-RUBY)
+ it "it does something" do
+ ^^^^^^^^^^^^^^^^^ Do not repeat 'it' when describing your tests.
+ end
+ RUBY
+ end
+
+ it "skips words beginning with 'it'" do
+ expect_no_violations(<<-RUBY)
+ it 'itemizes items' do
+ end
+ RUBY
+ end
+
it 'skips descriptions without `should` at the beginning' do
expect_no_violations(<<-RUBY)
it 'finds no should here' do
end
RUBY
end
include_examples 'autocorrect',
'it "should only have trait" do end',
'it "only has trait" do end'
+
+ include_examples 'autocorrect',
+ 'it "it does something" do end',
+ 'it "does something" do end'
end
context 'when configuration is empty' do
include_examples 'autocorrect',
'it "should have trait" do end',