spec/rubocop/cop/rspec/example_length_spec.rb in rubocop-rspec-1.12.0 vs spec/rubocop/cop/rspec/example_length_spec.rb in rubocop-rspec-1.13.0

- old
+ new

@@ -1,6 +1,6 @@ -describe RuboCop::Cop::RSpec::ExampleLength, :config do +RSpec.describe RuboCop::Cop::RSpec::ExampleLength, :config do subject(:cop) { described_class.new(config) } let(:cop_config) { { 'Max' => 3 } } it 'ignores non-spec blocks' do @@ -40,33 +40,15 @@ line 3 end RUBY end - shared_examples 'large example violation' do - before do - inspect_source(cop, source, 'spec/foo_spec.rb') - end - - it 'flags an offense' do - expect(cop.offenses.size).to eq(1) - end - - it 'registers the offense on line 1' do - expect(cop.offenses.map(&:line)).to eq([1]) - end - - it 'adds a message saying the example has too many lines' do - expect(cop.messages).to eq(['Example has too many lines. [4/3]']) - end - end - context 'when inspecting large examples' do it 'flags the example' do expect_violation(<<-RUBY) it do - ^^^^^ Example has too many lines. [4/3] + ^^^^^ Example has too many lines [4/3]. line 1 line 2 line 3 line 4 end @@ -77,24 +59,13 @@ context 'with CountComments enabled' do let(:cop_config) do { 'Max' => 3, 'CountComments' => true } end - let(:source) do - [ - 'it do', - ' line 1', - ' line 2', - ' # comment', - ' line 3', - 'end' - ] - end - it 'flags the example' do expect_violation(<<-RUBY) it do - ^^^^^ Example has too many lines. [4/3] + ^^^^^ Example has too many lines [4/3]. line 1 line 2 # comment line 3 end