lib/rubocop/cop/rspec/instance_spy.rb in rubocop-rspec-1.41.0 vs lib/rubocop/cop/rspec/instance_spy.rb in rubocop-rspec-1.42.0

@@ -17,10 +17,12 @@
       #     foo = instance_spy(Foo)
       #     expect(foo).to have_received(:bar)
       #   end
       #
       class InstanceSpy < Cop
+        extend AutoCorrector
+
         MSG = 'Use `instance_spy` when you check your double '\
               'with `have_received`.'
 
         def_node_search :null_double, <<-PATTERN
           (lvasgn $_
@@ -41,25 +43,29 @@
         def on_block(node)
           return unless example?(node)
 
           null_double(node) do |var, receiver|
             have_received_usage(node) do |expected|
-              add_offense(receiver) if expected == var
+              next if expected != var
+
+              add_offense(receiver) do |corrector|
+                autocorrect(corrector, receiver)
+              end
             end
           end
         end
 
-        def autocorrect(node)
-          lambda do |corrector|
-            replacement = 'instance_spy'
-            corrector.replace(node.loc.selector, replacement)
+        private
 
-            double_source_map = node.parent.loc
-            as_null_object_range = double_source_map
-              .dot
-              .join(double_source_map.selector)
-            corrector.remove(as_null_object_range)
-          end
+        def autocorrect(corrector, node)
+          replacement = 'instance_spy'
+          corrector.replace(node.loc.selector, replacement)
+
+          double_source_map = node.parent.loc
+          as_null_object_range = double_source_map
+            .dot
+            .join(double_source_map.selector)
+          corrector.remove(as_null_object_range)
         end
       end
     end
   end
 end