lib/rubocop/cop/rspec/describe_class.rb in rubocop-rspec-1.18.0 vs lib/rubocop/cop/rspec/describe_class.rb in rubocop-rspec-1.19.0
- old
+ new
@@ -21,15 +21,15 @@
MSG = 'The first argument to describe should be '\
'the class or module being tested.'.freeze
def_node_matcher :valid_describe?, <<-PATTERN
- {(send {(const nil :RSpec) nil} :describe const ...) (send nil :describe)}
+ {(send {(const nil? :RSpec) nil?} :describe const ...) (send nil? :describe)}
PATTERN
def_node_matcher :describe_with_metadata, <<-PATTERN
- (send {(const nil :RSpec) nil} :describe
+ (send {(const nil? :RSpec) nil?} :describe
!const
...
(hash $...))
PATTERN
@@ -38,21 +38,21 @@
(sym :type)
(sym {:request :feature :routing :view}))
PATTERN
def_node_matcher :shared_group?, <<-PATTERN
- (block (send {(const nil :RSpec) nil} #{SharedGroups::ALL.node_pattern_union} ...) ...)
+ (block (send {(const nil? :RSpec) nil?} #{SharedGroups::ALL.node_pattern_union} ...) ...)
PATTERN
def on_top_level_describe(node, args)
return if shared_group?(root_node)
return if valid_describe?(node)
describe_with_metadata(node) do |pairs|
return if pairs.any?(&method(:rails_metadata?))
end
- add_offense(args.first, :expression)
+ add_offense(args.first, location: :expression)
end
end
end
end
end