config/style.yml in rubocop-govuk-3.9.0 vs config/style.yml in rubocop-govuk-3.10.0
- old
+ new
@@ -78,10 +78,20 @@
# syntax right for every occurrence of `%.2f` for example (taken from
# `smart-answers`) for not very much benefit."
Style/FormatStringToken:
Enabled: false
+# Using the default style leads to buggy auto-correct in several
+# repos that have their own 'format' method defined. While it's not
+# ideal to override a standard/Kernel method, it's also not practical
+# to change a term that's so deeply embedded within our domain.
+#
+# Related PR: https://github.com/alphagov/specialist-publisher/pull/1640
+# Related PR: https://github.com/alphagov/publisher/pull/1268
+Style/FormatString:
+ EnforcedStyle: sprintf
+
# This is a contentious issue, since 'alias_method' works in
# all circumstances, whereas 'alias' only works lexically. As
# with single vs. double quotes, it seems pointless to expend
# effort deciding between them. Our predominant style is to use
# 'alias_method', which always works.
@@ -120,16 +130,10 @@
Style/Documentation:
Description: 'Document classes and non-namespace modules.'
Enabled: false
# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/GlobalVars:
- Description: 'Do not introduce global variables.'
- Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
# This can lead to excessively long lines. Consistent with
# disabling "Layout/LineLength".
#
# "There are occasions where following this rule forces you to make the
# code less readable."
@@ -137,42 +141,11 @@
Description: 'Check for conditionals that can be replaced with guard clauses'
Enabled: false
# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
# TODO: unclear why this is here!
-Style/MethodDefParentheses:
- Description: >-
- Checks if the method definitions have or don't have
- parentheses.
- Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/NegatedIf:
- Description: >-
- Favor unless over if for negative conditions
- (or control flow or).
- Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
Style/Next:
Description: 'Use `next` to skip iteration instead of a condition at the end.'
- Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here!
-Style/NumericLiterals:
- Description: >-
- Add underscores to large numeric literals to improve their
- readability.
- Enabled: false
-
-# Introduced in: c69a7eb3af955d6c4c0cf0c3cec8e9f330c74429
-# TODO: unclear why this is here! Suggest enabling with
-# "EnforcedStyle: compact"
-Style/RaiseArgs:
- Description: 'Checks the arguments passed to raise/fail.'
Enabled: false
# Analog of: 736b3d295f88b9ba6676fc168b823535582388c2
# "Disable opinionated cops"
#