lib/roda.rb in roda-3.34.0 vs lib/roda.rb in roda-3.35.0

@@ -270,9 +270,15 @@
         #   Roda.plugin :csrf
         def plugin(plugin, *args, &block)
           raise RodaError, "Cannot add a plugin to a frozen Roda class" if frozen?
           plugin = RodaPlugins.load_plugin(plugin) if plugin.is_a?(Symbol)
           raise RodaError, "Invalid plugin type: #{plugin.class.inspect}" unless plugin.is_a?(Module)
+
+          if !plugin.respond_to?(:load_dependencies) && !plugin.respond_to?(:configure) && (!args.empty? || block)
+            # RODA4: switch from warning to error
+            RodaPlugins.warn("Plugin #{plugin} does not accept arguments or a block, but arguments or a block was passed when loading this. This will raise an error in Roda 4.")
+          end
+
           plugin.load_dependencies(self, *args, &block) if plugin.respond_to?(:load_dependencies)
           include(plugin::InstanceMethods) if defined?(plugin::InstanceMethods)
           extend(plugin::ClassMethods) if defined?(plugin::ClassMethods)
           self::RodaRequest.send(:include, plugin::RequestMethods) if defined?(plugin::RequestMethods)
           self::RodaRequest.extend(plugin::RequestClassMethods) if defined?(plugin::RequestClassMethods)