integration_spec.rb in roadie-rails-1.1.0

- old
+ new

@@ -6,25 +6,25 @@
   def parse_html_in_email(mail)
     Nokogiri::HTML.parse mail.html_part.body.decoded
   end
 
   [
-    RailsApp.new("Rails 3.0.x", 'rails_30', runner: :script, asset_pipeline: false),
+    RailsApp.new("Rails 3.0.x", 'rails_30', runner: :script, asset_pipeline: false, digests: false),
     ## We do not yet support live-compilation through asset pipeline
-    RailsApp.new("Rails 3.1.x", 'rails_31', runner: :script, asset_pipeline: true),
-    RailsApp.new("Rails 3.2.x", 'rails_32', runner: :script, asset_pipeline: true),
-    RailsApp.new("Rails 4.0.x", 'rails_40', runner: :bin, asset_pipeline: true),
-    RailsApp.new("Rails 4.0.x (without asset pipeline)", 'rails_40_no_pipeline', runner: :bin, asset_pipeline: false),
-    RailsApp.new("Rails 4.1.x", 'rails_41', runner: :bin, asset_pipeline: true),
-    RailsApp.new("Rails 4.2.x", 'rails_42', runner: :bin, asset_pipeline: true),
+    RailsApp.new("Rails 3.1.x", 'rails_31', runner: :script, asset_pipeline: true, digests: false),
+    RailsApp.new("Rails 3.2.x", 'rails_32', runner: :script, asset_pipeline: true, digests: false),
+    RailsApp.new("Rails 4.0.x", 'rails_40', runner: :bin, asset_pipeline: true, digests: false),
+    RailsApp.new("Rails 4.0.x (without asset pipeline)", 'rails_40_no_pipeline', runner: :bin, asset_pipeline: false, digests: false),
+    RailsApp.new("Rails 4.0.x (precompiled)", 'rails_40_precompiled', runner: :bin, asset_pipeline: true, digests: true),
+    RailsApp.new("Rails 4.1.x", 'rails_41', runner: :bin, asset_pipeline: true, digests: false),
+    RailsApp.new("Rails 4.2.x", 'rails_42', runner: :bin, asset_pipeline: true, digests: false),
+    RailsApp.new("Rails 4.2.x (with sprockets-rails 3)", 'rails_42_sprockets_rails_3', runner: :bin, asset_pipeline: true, digests: true, sprockets3: true),
   ].each do |app|
     describe "with #{app}" do
       before { app.reset }
 
-      it "inlines styles for multipart emails" do
-        email = app.read_email(:normal_email)
-
+      def validate_email(app, email)
         expect(email.to).to eq(['example@example.org'])
         expect(email.from).to eq(['john@example.com'])
         expect(email).to have(2).parts
 
         expect(email.text_part.body.decoded).not_to match(/<.*>/)
@@ -34,11 +34,17 @@
         expect(html).to include '<head'
 
         document = parse_html_in_email(email)
         expect(document).to have_selector('body h1')
 
-        if app.using_asset_pipeline?
+        if app.digested?
+          if app.sprockets3?
+            expected_image_url = 'https://example.app.org/assets/rails-322506f9917889126e81df2833a6eecdf2e394658d53dad347e9882dd4dbf28e.png'
+          else
+            expected_image_url = 'https://example.app.org/assets/rails-231a680f23887d9dd70710ea5efd3c62.png'
+          end
+        elsif app.using_asset_pipeline?
           expected_image_url = 'https://example.app.org/assets/rails.png'
         else
           expected_image_url = 'https://example.app.org/images/rails.png'
         end
         expect(document).to have_styling('background' => "url(#{expected_image_url})").at_selector('.image')
@@ -46,36 +52,20 @@
         # If we deliver mails we can catch weird problems with headers being invalid
         email.delivery_method :test
         email.deliver
       end
 
+      it "inlines styles for multipart emails" do
+        validate_email app, app.read_email(:normal_email)
+      end
+
       it "automatically inlines styles with automatic mailer" do
-        email = app.read_delivered_email(:normal_email)
+        validate_email app, app.read_delivered_email(:normal_email)
+      end
 
-        expect(email.to).to eq(['example@example.org'])
-        expect(email.from).to eq(['john@example.com'])
-        expect(email).to have(2).parts
-
-        expect(email.text_part.body.decoded).not_to match(/<.*>/)
-
-        html = email.html_part.body.decoded
-        expect(html).to include '<!DOCTYPE'
-        expect(html).to include '<head'
-
-        document = parse_html_in_email(email)
-        expect(document).to have_selector('body h1')
-
-        if app.using_asset_pipeline?
-          expected_image_url = 'https://example.app.org/assets/rails.png'
-        else
-          expected_image_url = 'https://example.app.org/images/rails.png'
-        end
-        expect(document).to have_styling('background' => "url(#{expected_image_url})").at_selector('.image')
-
-        # If we deliver mails we can catch weird problems with headers being invalid
-        email.delivery_method :test
-        email.deliver
+      it "automatically inlines styles with automatic mailer and forced delivery" do
+        validate_email app, app.read_delivered_email(:normal_email, force_delivery: true)
       end
 
       it "inlines no styles when roadie_options are nil" do
         email = app.read_delivered_email(:disabled_email)
 
@@ -89,47 +79,17 @@
         # If we deliver mails we can catch weird problems with headers being invalid
         email.delivery_method :test
         email.deliver
       end
 
-      if app.using_asset_pipeline?
+      if app.using_asset_pipeline? || app.digested?
         it "has a AssetPipelineProvider together with a FilesystemProvider" do
           expect(app.read_providers).to eq(%w[Roadie::FilesystemProvider Roadie::Rails::AssetPipelineProvider])
         end
       else
         it "only has a FilesystemProvider" do
           expect(app.read_providers).to eq(["Roadie::FilesystemProvider"])
         end
       end
-    end
-  end
-
-  describe "with precompiled assets" do
-    let(:app) {
-      RailsApp.new("Rails 4.0.x (precompiled)", 'rails_40_precompiled', runner: :bin, asset_pipeline: false)
-    }
-
-    before { app.reset }
-
-    let(:document) do
-      parse_html_in_email app.read_email(:normal_email)
-    end
-
-    # It still has an AssetPipelineProvider in case some asset isn't
-    # precompiled, or the user want to combine. As long as the user is using
-    # the correct asset helpers a precompiled asset will be picked up by the
-    # FilesystemProvider.
-    it "has a AssetPipelineProvider together with a FilesystemProvider" do
-      expect(app.read_providers).to eq(%w[Roadie::FilesystemProvider Roadie::Rails::AssetPipelineProvider])
-    end
-
-    it "inlines the precompiled stylesheet" do
-      # Precompiled version has green color; the file in app/assets have red
-      expect(document).to have_styling('background-color' => 'green').at_selector('body')
-    end
-
-    it "inlines images with digests" do
-      image_url = "https://example.app.org/assets/rails-231a680f23887d9dd70710ea5efd3c62.png"
-      expect(document).to have_styling('background' => "url(#{image_url})").at_selector('.image')
     end
   end
 end