.rubocop_todo.yml in rmagick-4.1.2 vs .rubocop_todo.yml in rmagick-4.2.0
- old
+ new
@@ -1,13 +1,21 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2020-02-09 10:55:21 -0800 using RuboCop version 0.68.1.
+# on 2020-10-10 21:34:21 +0900 using RuboCop version 0.81.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+ Exclude:
+ - 'rmagick.gemspec'
+
# Offense count: 12
# Cop supports --auto-correct.
# Configuration parameters: Categories, ExpectedOrder.
# ExpectedOrder: module_inclusion, constants, public_class_methods, initializer, public_methods, protected_methods, private_methods
Layout/ClassStructure:
@@ -47,20 +55,24 @@
- 'doc/ex/sparse_color.rb'
- 'examples/vignette.rb'
- 'lib/rmagick_internal.rb'
# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
+Layout/SpaceAroundOperators:
+ Exclude:
+ - 'rmagick.gemspec'
+
+# Offense count: 1
Lint/EmptyWhen:
Exclude:
- 'lib/rvg/misc.rb'
-# Offense count: 2
-Lint/HandleExceptions:
- Exclude:
- - 'lib/rmagick_internal.rb'
-
# Offense count: 94
+# Cop supports --auto-correct.
Lint/NumberConversion:
Exclude:
- 'doc/ex/get_pixels.rb'
- 'doc/ex/stegano.rb'
- 'examples/describe.rb'
@@ -72,25 +84,38 @@
- 'spec/rmagick/align_type/class_methods/values_spec.rb'
- 'spec/rmagick/enum/bitwise_or_spec.rb'
- 'spec/rmagick/enum/to_i_spec.rb'
- 'spec/rmagick/image/export_pixels_spec.rb'
+# Offense count: 2
+# Cop supports --auto-correct.
+Lint/RedundantStringCoercion:
+ Exclude:
+ - 'spec/rmagick/font/initialize_spec.rb'
+
# Offense count: 1
Lint/RescueException:
Exclude:
- 'lib/rmagick_internal.rb'
# Offense count: 1
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
+ Exclude:
+ - 'lib/rmagick_internal.rb'
+
+# Offense count: 1
Lint/UselessComparison:
Exclude:
- 'spec/rmagick/enum/case_equality_spec.rb'
-# Offense count: 44
+# Offense count: 45
+# Configuration parameters: IgnoredMethods.
Metrics/AbcSize:
Max: 537
-# Offense count: 75
+# Offense count: 77
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
Metrics/BlockLength:
Max: 155
@@ -100,27 +125,29 @@
Max: 4
# Offense count: 9
# Configuration parameters: CountComments.
Metrics/ClassLength:
- Max: 467
+ Max: 460
# Offense count: 21
+# Configuration parameters: IgnoredMethods.
Metrics/CyclomaticComplexity:
Max: 42
-# Offense count: 57
+# Offense count: 55
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength:
Max: 146
# Offense count: 14
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
Max: 8
# Offense count: 15
+# Configuration parameters: IgnoredMethods.
Metrics/PerceivedComplexity:
Max: 40
# Offense count: 4
Naming/AccessorMethodName:
@@ -167,66 +194,33 @@
- 'doc/ex/Use03.rb'
- 'doc/ex/ViewBox.rb'
- 'doc/ex/quantize-m.rb'
# Offense count: 4
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, IgnoredPatterns.
# SupportedStyles: snake_case, camelCase
Naming/MethodName:
Exclude:
- 'lib/rvg/misc.rb'
- 'lib/rvg/transformable.rb'
-# Offense count: 224
+# Offense count: 222
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
Enabled: false
-# Offense count: 439
+# Offense count: 421
# Configuration parameters: Max.
RSpec/ExampleLength:
Enabled: false
-# Offense count: 556
+# Offense count: 539
# Configuration parameters: AggregateFailuresByDefault.
RSpec/MultipleExpectations:
Max: 72
-# Offense count: 5
-RSpec/Pending:
- Exclude:
- - 'spec/rmagick/draw/marshal_dump_spec.rb'
- - 'spec/rmagick/image/changed_predicate_spec.rb'
- - 'spec/rmagick/image/liquid_rescale_spec.rb'
- - 'spec/rmagick/image/read_spec.rb'
-
-# Offense count: 2
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/Date:
- Exclude:
- - 'doc/ex/polaroid.rb'
- - 'rmagick.gemspec'
-
-# Offense count: 7
-# Configuration parameters: Include.
-# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
-Rails/Output:
- Exclude:
- - 'lib/rvg/deep_equal.rb'
- - 'lib/rvg/rvg.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
- Exclude:
- - 'Rakefile'
- - 'ext/RMagick/extconf.rb'
-
# Offense count: 4
Security/MarshalLoad:
Exclude:
- 'lib/rmagick_internal.rb'
- 'spec/rmagick/draw/marshal_dump_spec.rb'
@@ -247,66 +241,109 @@
# Offense count: 89
Style/CommentedKeyword:
Enabled: false
-# Offense count: 2
+# Offense count: 126
Style/ConstantVisibility:
Exclude:
+ - 'examples/histogram.rb'
+ - 'ext/RMagick/extconf.rb'
+ - 'lib/rmagick/version.rb'
- 'lib/rmagick_internal.rb'
+ - 'lib/rvg/misc.rb'
+ - 'lib/rvg/rvg.rb'
+ - 'lib/rvg/stylable.rb'
+ - 'spec/support/helpers.rb'
-# Offense count: 802
+# Offense count: 809
# Cop supports --auto-correct.
# Configuration parameters: Notice, AutocorrectNotice.
Style/Copyright:
Enabled: false
-# Offense count: 36
+# Offense count: 37
Style/Documentation:
Enabled: false
-# Offense count: 77
+# Offense count: 72
# Configuration parameters: RequireForNonPublicMethods.
Style/DocumentationMethod:
- Enabled: false
+ Exclude:
+ - 'spec/**/*'
+ - 'test/**/*'
+ - 'Rakefile'
+ - 'doc/ex/ViewBox.rb'
+ - 'doc/ex/sparse_color.rb'
+ - 'examples/histogram.rb'
+ - 'examples/pattern_fill.rb'
+ - 'ext/RMagick/extconf.rb'
+ - 'lib/rmagick_internal.rb'
+ - 'lib/rvg/container.rb'
+ - 'lib/rvg/deep_equal.rb'
+ - 'lib/rvg/embellishable.rb'
+ - 'lib/rvg/misc.rb'
+ - 'lib/rvg/stylable.rb'
+ - 'lib/rvg/transformable.rb'
+ - 'lib/rvg/units.rb'
-# Offense count: 192
+# Offense count: 208
# Configuration parameters: EnforcedStyle.
# SupportedStyles: annotated, template, unannotated
Style/FormatStringToken:
Exclude:
+ - 'doc/ex/colors.rb'
+ - 'doc/ex/fonts.rb'
+ - 'doc/ex/implode.rb'
+ - 'doc/ex/stegano.rb'
- 'examples/identify.rb'
- - 'ext/RMagick/extconf.rb'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/pathdata.rb'
-# Offense count: 801
+# Offense count: 808
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
-# SupportedStyles: when_needed, always, never
+# SupportedStyles: always, always_true, never
Style/FrozenStringLiteralComment:
Enabled: false
-# Offense count: 36
+# Offense count: 42
# Configuration parameters: AllowedVariables.
Style/GlobalVars:
Exclude:
- 'ext/RMagick/extconf.rb'
-# Offense count: 4
+# Offense count: 12
# Cop supports --auto-correct.
+Style/HashEachMethods:
+ Exclude:
+ - 'doc/ex/preview.rb'
+ - 'spec/rmagick/image/auto_orient_spec.rb'
+ - 'spec/rmagick/image/channel_spec.rb'
+ - 'spec/rmagick/image/colorspace_spec.rb'
+ - 'spec/rmagick/image/info/colorspace_spec.rb'
+ - 'spec/rmagick/image/info/compression_spec.rb'
+ - 'spec/rmagick/image/info/dispose_spec.rb'
+ - 'spec/rmagick/image/info/gravity_spec.rb'
+ - 'spec/rmagick/image/info/image_type_spec.rb'
+ - 'spec/rmagick/image/info/interlace_spec.rb'
+ - 'spec/rmagick/image/info/orientation_spec.rb'
+ - 'spec/rmagick/image/info/units_spec.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
Style/IfUnlessModifier:
Exclude:
- 'ext/RMagick/extconf.rb'
-# Offense count: 170
+# Offense count: 148
Style/InlineComment:
Enabled: false
-# Offense count: 4963
+# Offense count: 4804
# Cop supports --auto-correct.
-# Configuration parameters: IgnoreMacros, IgnoredMethods, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
+# Configuration parameters: IgnoreMacros, IgnoredMethods, IgnoredPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
# SupportedStyles: require_parentheses, omit_parentheses
Style/MethodCallWithArgsParentheses:
Enabled: false
# Offense count: 2
@@ -341,11 +378,11 @@
- 'examples/pattern_fill.rb'
- 'examples/rotating_text.rb'
- 'examples/thumbnail.rb'
- 'examples/vignette.rb'
-# Offense count: 151
+# Offense count: 152
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: literals, strict
Style/MutableConstant:
Enabled: false
@@ -358,14 +395,21 @@
Exclude:
- 'spec/**/*'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/embellishable.rb'
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+ Exclude:
+ - 'examples/histogram.rb'
+
# Offense count: 3
# Cop supports --auto-correct.
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
-# Whitelist: present?, blank?, presence, try, try!
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# AllowedMethods: present?, blank?, presence, try, try!
Style/SafeNavigation:
Exclude:
- 'lib/rmagick_internal.rb'
# Offense count: 5
@@ -388,18 +432,18 @@
- 'Rakefile'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/misc.rb'
- 'spec/rmagick/image/properties_spec.rb'
-# Offense count: 158
+# Offense count: 226
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiterals:
Enabled: false
-# Offense count: 884
+# Offense count: 975
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
-Metrics/LineLength:
- Max: 250
+Layout/LineLength:
+ Max: 217