.rubocop_todo.yml in rmagick-4.1.0.rc2 vs .rubocop_todo.yml in rmagick-4.1.0
- old
+ new
@@ -1,8 +1,8 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2019-03-08 22:06:23 -0800 using RuboCop version 0.64.0.
+# on 2020-02-09 10:55:21 -0800 using RuboCop version 0.68.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
@@ -18,35 +18,27 @@
- 'lib/rvg/misc.rb'
- 'lib/rvg/pathdata.rb'
- 'lib/rvg/rvg.rb'
- 'lib/rvg/to_c.rb'
-# Offense count: 8
+# Offense count: 2312
# Cop supports --auto-correct.
-Layout/FirstArrayElementLineBreak:
+Layout/MultilineArrayLineBreaks:
Exclude:
- 'doc/ex/add_noise.rb'
- 'doc/ex/clip_path.rb'
- 'doc/ex/crop_with_gravity.rb'
- 'doc/ex/polyline.rb'
+ - 'doc/ex/smile.rb'
- 'examples/crop_with_gravity.rb'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/stylable.rb'
- - 'test/Image3.rb'
-# Offense count: 5
+# Offense count: 192
# Cop supports --auto-correct.
-Layout/FirstHashElementLineBreak:
+Layout/MultilineMethodArgumentLineBreaks:
Exclude:
- - 'doc/ex/writing_mode01.rb'
- - 'doc/ex/writing_mode02.rb'
- - 'lib/rmagick_internal.rb'
-
-# Offense count: 23
-# Cop supports --auto-correct.
-Layout/FirstMethodArgumentLineBreak:
- Exclude:
- 'doc/ex/axes.rb'
- 'doc/ex/drawcomp.rb'
- 'doc/ex/fonts.rb'
- 'doc/ex/get_type_metrics.rb'
- 'doc/ex/polygon.rb'
@@ -54,114 +46,76 @@
- 'doc/ex/polyline01.rb'
- 'doc/ex/sparse_color.rb'
- 'examples/vignette.rb'
- 'lib/rmagick_internal.rb'
-# Offense count: 16
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
- Exclude:
- - 'Rakefile'
- - 'examples/describe.rb'
- - 'examples/histogram.rb'
- - 'examples/image_opacity.rb'
- - 'examples/import_export.rb'
- - 'examples/pattern_fill.rb'
- - 'examples/rotating_text.rb'
- - 'examples/spinner.rb'
- - 'examples/thumbnail.rb'
- - 'ext/RMagick/extconf.rb'
- - 'lib/rvg/to_c.rb'
-
-# Offense count: 95
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedTypes: block, case, class, if, kwbegin, module
-# SupportedStyles: same_line, new_line
-Layout/MultilineAssignmentLayout:
- Enabled: false
-
# Offense count: 1
Lint/EmptyWhen:
Exclude:
- 'lib/rvg/misc.rb'
# Offense count: 2
Lint/HandleExceptions:
Exclude:
- 'lib/rmagick_internal.rb'
-# Offense count: 88
+# Offense count: 94
Lint/NumberConversion:
Exclude:
- 'doc/ex/get_pixels.rb'
- 'doc/ex/stegano.rb'
- 'examples/describe.rb'
- 'examples/thumbnail.rb'
- - 'ext/RMagick/extconf.rb'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/misc.rb'
- 'lib/rvg/to_c.rb'
- - 'test/Import_Export.rb'
- - 'test/Enum.rb'
- - 'test/lib/internal/Geometry.rb'
+ - 'spec/magick_spec.rb'
+ - 'spec/rmagick/align_type/class_methods/values_spec.rb'
+ - 'spec/rmagick/enum/bitwise_or_spec.rb'
+ - 'spec/rmagick/enum/to_i_spec.rb'
+ - 'spec/rmagick/image/export_pixels_spec.rb'
# Offense count: 1
Lint/RescueException:
Exclude:
- 'lib/rmagick_internal.rb'
# Offense count: 1
-Lint/ReturnInVoidContext:
- Exclude:
- - 'lib/rmagick_internal.rb'
-
Lint/UselessComparison:
Exclude:
- - 'test/Enum.rb'
+ - 'spec/rmagick/enum/case_equality_spec.rb'
-# Offense count: 6
-# Configuration parameters: CheckForMethodsWithNoSideEffects.
-Lint/Void:
- Exclude:
- - 'lib/rmagick_internal.rb'
- - 'lib/rvg/embellishable.rb'
-
-# Offense count: 167
+# Offense count: 44
Metrics/AbcSize:
- Max: 559
+ Max: 537
-# Offense count: 22
+# Offense count: 75
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
Metrics/BlockLength:
Max: 155
# Offense count: 1
# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 4
-# Offense count: 17
+# Offense count: 9
# Configuration parameters: CountComments.
Metrics/ClassLength:
- Max: 500
- Exclude:
- - 'test/**/*.rb'
+ Max: 467
-# Offense count: 22
+# Offense count: 21
Metrics/CyclomaticComplexity:
Max: 42
-# Offense count: 167
+# Offense count: 57
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength:
Max: 146
-# Offense count: 13
+# Offense count: 14
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
Max: 8
# Offense count: 15
@@ -172,20 +126,16 @@
Naming/AccessorMethodName:
Exclude:
- 'lib/rmagick_internal.rb'
- 'lib/rvg/misc.rb'
-# Offense count: 6
+# Offense count: 2
Naming/ClassAndModuleCamelCase:
Exclude:
- 'lib/rmagick_internal.rb'
- - 'test/Image1.rb'
- - 'test/Image2.rb'
- - 'test/Image3.rb'
- - 'test/Image_attributes.rb'
-# Offense count: 122
+# Offense count: 120
Naming/ConstantName:
Exclude:
- 'doc/ex/arcs02.rb'
- 'doc/ex/cubic01.rb'
- 'doc/ex/cubic02.rb'
@@ -197,140 +147,62 @@
- 'doc/ex/rubyname.rb'
- 'doc/ex/smile.rb'
- 'doc/ex/tref01.rb'
- 'examples/demo.rb'
- 'lib/rmagick_internal.rb'
- - 'test/Image3.rb'
-# Offense count: 17
+# Offense count: 12
# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
Naming/FileName:
- Enabled: false
+ Exclude:
+ - 'deprecated/RMagick.rb'
+ - 'doc/ex/InitialCoords.rb'
+ - 'doc/ex/NewCoordSys.rb'
+ - 'doc/ex/OrigCoordSys.rb'
+ - 'doc/ex/PreserveAspectRatio.rb'
+ - 'doc/ex/RotateScale.rb'
+ - 'doc/ex/Skew.rb'
+ - 'doc/ex/Use01.rb'
+ - 'doc/ex/Use02.rb'
+ - 'doc/ex/Use03.rb'
+ - 'doc/ex/ViewBox.rb'
+ - 'doc/ex/quantize-m.rb'
# Offense count: 4
# Configuration parameters: EnforcedStyle.
# SupportedStyles: snake_case, camelCase
Naming/MethodName:
Exclude:
- 'lib/rvg/misc.rb'
- 'lib/rvg/transformable.rb'
-# Offense count: 4
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicateName:
- Exclude:
- - 'spec/**/*'
- - 'ext/RMagick/extconf.rb'
- - 'lib/rmagick_internal.rb'
-
-# Offense count: 222
+# Offense count: 224
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: io, id, to, by, on, in, at, ip, db
Naming/UncommunicativeMethodParamName:
Enabled: false
-# Offense count: 1
-Performance/ChainArrayAllocation:
- Exclude:
- - 'lib/rvg/embellishable.rb'
-
-# Offense count: 6
-Performance/FixedSize:
- Exclude:
- - 'test/Image2.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Performance/RedundantMatch:
- Exclude:
- - 'examples/demo.rb'
- - 'test/Image2.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-RSpec/AlignLeftLetBrace:
- Exclude:
- - 'spec/rmagick/image/constitute_spec.rb'
- - 'spec/rmagick/image/from_blob_spec.rb'
- - 'spec/rmagick/image/properties_spec.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-RSpec/AlignRightLetBrace:
- Exclude:
- - 'spec/rmagick/image/constitute_spec.rb'
- - 'spec/rmagick/image/from_blob_spec.rb'
- - 'spec/rmagick/image/properties_spec.rb'
-
-# Offense count: 6
+# Offense count: 439
# Configuration parameters: Max.
RSpec/ExampleLength:
- Exclude:
- - 'spec/rmagick/ImageList1_spec.rb'
- - 'spec/rmagick/draw_spec.rb'
- - 'spec/rmagick/image/composite_spec.rb'
- - 'spec/rmagick/image/dispatch_spec.rb'
- - 'spec/rmagick/image/ping_spec.rb'
+ Enabled: false
-# Offense count: 1
-# Configuration parameters: CustomTransform, IgnoreMethods.
-RSpec/FilePath:
- Exclude:
- - 'spec/rmagick/ImageList1_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, each, example
-RSpec/HookArgument:
- Exclude:
- - 'spec/rmagick/image/properties_spec.rb'
-
-# Offense count: 2
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
- Exclude:
- - 'spec/rmagick/image/read_spec.rb'
-
-# Offense count: 15
+# Offense count: 556
# Configuration parameters: AggregateFailuresByDefault.
RSpec/MultipleExpectations:
- Max: 6
+ Max: 72
-# Offense count: 3
+# Offense count: 5
RSpec/Pending:
Exclude:
- - 'spec/rmagick/draw_spec.rb'
+ - 'spec/rmagick/draw/marshal_dump_spec.rb'
+ - 'spec/rmagick/image/changed_predicate_spec.rb'
+ - 'spec/rmagick/image/liquid_rescale_spec.rb'
- 'spec/rmagick/image/read_spec.rb'
# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: Strict, EnforcedStyle.
-# SupportedStyles: inflected, explicit
-RSpec/PredicateMatcher:
- Exclude:
- - 'spec/rmagick/image/read_spec.rb'
-
-# Offense count: 13
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-# Include: **/test/**/*
-Rails/AssertNot:
- Exclude:
- - 'test/Image1.rb'
- - 'test/Image2.rb'
- - 'test/ImageList1.rb'
- - 'test/Image_attributes.rb'
- - 'test/Info.rb'
- - 'test/Pixel.rb'
-
-# Offense count: 2
# Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible
Rails/Date:
Exclude:
- 'doc/ex/polaroid.rb'
@@ -343,10 +215,11 @@
Exclude:
- 'lib/rvg/deep_equal.rb'
- 'lib/rvg/rvg.rb'
# Offense count: 3
+# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible
Rails/TimeZone:
Exclude:
- 'Rakefile'
@@ -354,145 +227,97 @@
# Offense count: 4
Security/MarshalLoad:
Exclude:
- 'lib/rmagick_internal.rb'
- - 'spec/rmagick/draw_spec.rb'
- - 'test/Image2.rb'
- - 'test/ImageList2.rb'
+ - 'spec/rmagick/draw/marshal_dump_spec.rb'
+ - 'spec/rmagick/image/marshal_spec.rb'
+ - 'spec/rmagick/image_list/marshal_spec.rb'
-# Offense count: 2
+# Offense count: 1
Style/AutoResourceCleanup:
Exclude:
- 'lib/rvg/to_c.rb'
- - 'test/ImageList2.rb'
+# Offense count: 7
Style/CaseEquality:
Exclude:
- - 'test/Enum.rb'
- - 'test/Pixel.rb'
+ - 'spec/rmagick/enum/case_equality_spec.rb'
+ - 'spec/rmagick/pixel/dup_spec.rb'
+ - 'spec/rmagick/pixel/threequals_spec.rb'
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
- Exclude:
- - 'doc/ex/composite_layers.rb'
- - 'lib/rvg/to_c.rb'
- - 'spec/rmagick/draw_spec.rb'
- - 'test/Magick.rb'
+# Offense count: 89
+Style/CommentedKeyword:
+ Enabled: false
-# Offense count: 24
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredMethods.
-Style/CollectionMethods:
+# Offense count: 2
+Style/ConstantVisibility:
Exclude:
- - 'doc/ex/composite_layers.rb'
- 'lib/rmagick_internal.rb'
- - 'lib/rvg/embellishable.rb'
- - 'lib/rvg/misc.rb'
- - 'lib/rvg/transformable.rb'
- - 'test/ImageList1.rb'
- - 'test/Import_Export.rb'
-# Offense count: 90
-Style/CommentedKeyword:
- Enabled: false
-
-# Offense count: 253
+# Offense count: 802
# Cop supports --auto-correct.
# Configuration parameters: Notice, AutocorrectNotice.
Style/Copyright:
Enabled: false
-# Offense count: 1
-# Configuration parameters: AllowCoercion.
-Style/DateTime:
- Exclude:
- - 'ext/RMagick/extconf.rb'
-
# Offense count: 36
Style/Documentation:
Enabled: false
-# Offense count: 74
+# Offense count: 77
# Configuration parameters: RequireForNonPublicMethods.
Style/DocumentationMethod:
Enabled: false
-# Offense count: 4
-Style/EvalWithLocation:
- Exclude:
- - 'lib/rmagick_internal.rb'
- - 'lib/rvg/units.rb'
-
-Style/FormatString:
- Exclude:
- - 'examples/identify.rb'
-
-# Offense count: 158
+# Offense count: 192
# Configuration parameters: EnforcedStyle.
# SupportedStyles: annotated, template, unannotated
Style/FormatStringToken:
Exclude:
- 'examples/identify.rb'
- 'ext/RMagick/extconf.rb'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/pathdata.rb'
-# Offense count: 253
+# Offense count: 801
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: when_needed, always, never
Style/FrozenStringLiteralComment:
Enabled: false
-# Offense count: 40
+# Offense count: 36
# Configuration parameters: AllowedVariables.
Style/GlobalVars:
Exclude:
- - 'examples/histogram.rb'
- 'ext/RMagick/extconf.rb'
-# Offense count: 2
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
- Exclude:
- - 'ext/RMagick/extconf.rb'
-
-# Offense count: 1
+# Offense count: 4
# Cop supports --auto-correct.
Style/IfUnlessModifier:
Exclude:
- 'ext/RMagick/extconf.rb'
-# Offense count: 163
+# Offense count: 170
Style/InlineComment:
Enabled: false
-# Offense count: 1051
+# Offense count: 4963
# Cop supports --auto-correct.
-# Configuration parameters: IgnoreMacros, IgnoredMethods, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
+# Configuration parameters: IgnoreMacros, IgnoredMethods, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
# SupportedStyles: require_parentheses, omit_parentheses
Style/MethodCallWithArgsParentheses:
Enabled: false
-# Offense count: 8
-Style/MethodCalledOnDoEndBlock:
- Exclude:
- - 'spec/rmagick/ImageList1_spec.rb'
- - 'spec/rmagick/image/composite_spec.rb'
- - 'spec/rmagick/image/dispatch_spec.rb'
-
# Offense count: 2
Style/MethodMissingSuper:
Exclude:
- 'lib/rmagick_internal.rb'
- 'lib/rvg/misc.rb'
-# Offense count: 68
+# Offense count: 64
# Configuration parameters: EnforcedStyle.
# SupportedStyles: if, case, both
Style/MissingElse:
Enabled: false
@@ -516,32 +341,27 @@
- 'examples/pattern_fill.rb'
- 'examples/rotating_text.rb'
- 'examples/thumbnail.rb'
- 'examples/vignette.rb'
-# Offense count: 162
+# Offense count: 151
# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
Style/MutableConstant:
Enabled: false
-# Offense count: 34
+# Offense count: 32
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
Exclude:
- 'spec/**/*'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/embellishable.rb'
- - 'test/Image2.rb'
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/RescueModifier:
- Exclude:
- - 'test/Image3.rb'
-
# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
# Whitelist: present?, blank?, presence, try, try!
Style/SafeNavigation:
@@ -550,11 +370,11 @@
# Offense count: 5
Style/Send:
Exclude:
- 'lib/rmagick_internal.rb'
- - 'test/Image2.rb'
+ - 'spec/rmagick/image/destroy_spec.rb'
# Offense count: 2
# Configuration parameters: Methods.
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Style/SingleLineBlockParams:
@@ -568,28 +388,18 @@
- 'Rakefile'
- 'lib/rmagick_internal.rb'
- 'lib/rvg/misc.rb'
- 'spec/rmagick/image/properties_spec.rb'
-# Offense count: 8
+# Offense count: 158
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiterals:
- Exclude:
- - 'Rakefile'
- - 'test/Image1.rb'
- - 'test/ImageList2.rb'
- - 'test/PolaroidOptions.rb'
+ Enabled: false
-# Offense count: 5
+# Offense count: 884
# Cop supports --auto-correct.
-# Configuration parameters: PreferredMethods.
-Style/StringMethods:
- Exclude:
- - 'lib/rvg/misc.rb'
-
-# Offense count: 640
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
- Max: 278
+ Max: 250