.rubocop_todo.yml in rmagick-3.0.0 vs .rubocop_todo.yml in rmagick-3.1.0

@@ -1,15 +1,65 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-08 19:33:24 +0300 using RuboCop version 0.59.2.
+# on 2019-03-08 22:06:23 -0800 using RuboCop version 0.64.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 18
+# Offense count: 12
 # Cop supports --auto-correct.
+# Configuration parameters: Categories, ExpectedOrder.
+# ExpectedOrder: module_inclusion, constants, public_class_methods, initializer, public_methods, protected_methods, private_methods
+Layout/ClassStructure:
+  Exclude:
+    - 'examples/histogram.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/embellishable.rb'
+    - 'lib/rvg/misc.rb'
+    - 'lib/rvg/pathdata.rb'
+    - 'lib/rvg/rvg.rb'
+    - 'lib/rvg/to_c.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Layout/FirstArrayElementLineBreak:
+  Exclude:
+    - 'doc/ex/add_noise.rb'
+    - 'doc/ex/clip_path.rb'
+    - 'doc/ex/crop_with_gravity.rb'
+    - 'doc/ex/polyline.rb'
+    - 'examples/crop_with_gravity.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/stylable.rb'
+    - 'test/Image3.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Layout/FirstHashElementLineBreak:
+  Exclude:
+    - 'doc/ex/writing_mode01.rb'
+    - 'doc/ex/writing_mode02.rb'
+    - 'lib/rmagick_internal.rb'
+
+# Offense count: 23
+# Cop supports --auto-correct.
+Layout/FirstMethodArgumentLineBreak:
+  Exclude:
+    - 'doc/ex/axes.rb'
+    - 'doc/ex/drawcomp.rb'
+    - 'doc/ex/fonts.rb'
+    - 'doc/ex/get_type_metrics.rb'
+    - 'doc/ex/polygon.rb'
+    - 'doc/ex/polygon01.rb'
+    - 'doc/ex/polyline01.rb'
+    - 'doc/ex/sparse_color.rb'
+    - 'examples/vignette.rb'
+    - 'lib/rmagick_internal.rb'
+
+# Offense count: 16
+# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
 Layout/IndentHeredoc:
   Exclude:
     - 'Rakefile'
@@ -22,60 +72,90 @@
     - 'examples/spinner.rb'
     - 'examples/thumbnail.rb'
     - 'ext/RMagick/extconf.rb'
     - 'lib/rvg/to_c.rb'
 
-# Offense count: 1
+# Offense count: 95
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineArrayBraceLayout:
-  Exclude:
-    - 'ext/RMagick/extconf.rb'
+# SupportedTypes: block, case, class, if, kwbegin, module
+# SupportedStyles: same_line, new_line
+Layout/MultilineAssignmentLayout:
+  Enabled: false
 
 # Offense count: 1
+Lint/EmptyWhen:
+  Exclude:
+    - 'lib/rvg/misc.rb'
+
+# Offense count: 2
 Lint/HandleExceptions:
   Exclude:
     - 'lib/rmagick_internal.rb'
 
+# Offense count: 88
+Lint/NumberConversion:
+  Exclude:
+    - 'doc/ex/get_pixels.rb'
+    - 'doc/ex/stegano.rb'
+    - 'examples/describe.rb'
+    - 'examples/thumbnail.rb'
+    - 'ext/RMagick/extconf.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/misc.rb'
+    - 'lib/rvg/to_c.rb'
+    - 'test/Import_Export.rb'
+    - 'test/Enum.rb'
+
 # Offense count: 1
 Lint/RescueException:
   Exclude:
     - 'lib/rmagick_internal.rb'
 
 # Offense count: 1
 Lint/ReturnInVoidContext:
   Exclude:
     - 'lib/rmagick_internal.rb'
 
+Lint/UselessComparison:
+  Exclude:
+    - 'test/Enum.rb'
+
 # Offense count: 6
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
   Exclude:
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/embellishable.rb'
 
-# Offense count: 170
+# Offense count: 167
 Metrics/AbcSize:
   Max: 559
 
-# Offense count: 21
+# Offense count: 22
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
   Max: 155
 
 # Offense count: 1
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 4
 
+# Offense count: 17
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 500
+  Exclude:
+    - 'test/**/*.rb'
+
 # Offense count: 22
 Metrics/CyclomaticComplexity:
   Max: 42
 
-# Offense count: 172
+# Offense count: 167
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 146
 
 # Offense count: 13
@@ -100,11 +180,11 @@
     - 'test/Image1.rb'
     - 'test/Image2.rb'
     - 'test/Image3.rb'
     - 'test/Image_attributes.rb'
 
-# Offense count: 123
+# Offense count: 122
 Naming/ConstantName:
   Exclude:
     - 'doc/ex/arcs02.rb'
     - 'doc/ex/cubic01.rb'
     - 'doc/ex/cubic02.rb'
@@ -117,13 +197,12 @@
     - 'doc/ex/smile.rb'
     - 'doc/ex/tref01.rb'
     - 'examples/demo.rb'
     - 'lib/rmagick_internal.rb'
     - 'test/Image3.rb'
-    - 'test/test_all_basic.rb'
 
-# Offense count: 16
+# Offense count: 17
 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
 # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
 Naming/FileName:
   Enabled: false
 
@@ -133,11 +212,11 @@
 Naming/MethodName:
   Exclude:
     - 'lib/rvg/misc.rb'
     - 'lib/rvg/transformable.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # NamePrefixBlacklist: is_, has_, have_
 # NameWhitelist: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
@@ -151,10 +230,15 @@
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
 Naming/UncommunicativeMethodParamName:
   Enabled: false
 
+# Offense count: 1
+Performance/ChainArrayAllocation:
+  Exclude:
+    - 'lib/rvg/embellishable.rb'
+
 # Offense count: 6
 Performance/FixedSize:
   Exclude:
     - 'test/Image2.rb'
 
@@ -163,18 +247,130 @@
 Performance/RedundantMatch:
   Exclude:
     - 'examples/demo.rb'
     - 'test/Image2.rb'
 
+# Offense count: 3
+# Cop supports --auto-correct.
+RSpec/AlignLeftLetBrace:
+  Exclude:
+    - 'spec/rmagick/image/constitute_spec.rb'
+    - 'spec/rmagick/image/from_blob_spec.rb'
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+RSpec/AlignRightLetBrace:
+  Exclude:
+    - 'spec/rmagick/image/constitute_spec.rb'
+    - 'spec/rmagick/image/from_blob_spec.rb'
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 6
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/rmagick/ImageList1_spec.rb'
+    - 'spec/rmagick/draw_spec.rb'
+    - 'spec/rmagick/image/composite_spec.rb'
+    - 'spec/rmagick/image/dispatch_spec.rb'
+    - 'spec/rmagick/image/ping_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/rmagick/ImageList1_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, each, example
+RSpec/HookArgument:
+  Exclude:
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/rmagick/image/read_spec.rb'
+
+# Offense count: 15
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 6
+
+# Offense count: 3
+RSpec/Pending:
+  Exclude:
+    - 'spec/rmagick/draw_spec.rb'
+    - 'spec/rmagick/image/read_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: Strict, EnforcedStyle.
+# SupportedStyles: inflected, explicit
+RSpec/PredicateMatcher:
+  Exclude:
+    - 'spec/rmagick/image/read_spec.rb'
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: Include.
+# Include: **/test/**/*
+Rails/AssertNot:
+  Exclude:
+    - 'test/Image1.rb'
+    - 'test/Image2.rb'
+    - 'test/ImageList1.rb'
+    - 'test/Image_attributes.rb'
+    - 'test/Info.rb'
+    - 'test/Pixel.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/Date:
+  Exclude:
+    - 'doc/ex/polaroid.rb'
+    - 'rmagick.gemspec'
+
+# Offense count: 7
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
+Rails/Output:
+  Exclude:
+    - 'lib/rvg/deep_equal.rb'
+    - 'lib/rvg/rvg.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
+  Exclude:
+    - 'Rakefile'
+    - 'ext/RMagick/extconf.rb'
+
 # Offense count: 4
 Security/MarshalLoad:
   Exclude:
     - 'lib/rmagick_internal.rb'
     - 'spec/rmagick/draw_spec.rb'
     - 'test/Image2.rb'
     - 'test/ImageList2.rb'
 
+# Offense count: 2
+Style/AutoResourceCleanup:
+  Exclude:
+    - 'lib/rvg/to_c.rb'
+    - 'test/ImageList2.rb'
+
+Style/CaseEquality:
+  Exclude:
+    - 'test/Enum.rb'
+
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
@@ -182,18 +378,48 @@
     - 'doc/ex/composite_layers.rb'
     - 'lib/rvg/to_c.rb'
     - 'spec/rmagick/draw_spec.rb'
     - 'test/Magick.rb'
 
+# Offense count: 24
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredMethods.
+Style/CollectionMethods:
+  Exclude:
+    - 'doc/ex/composite_layers.rb'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/embellishable.rb'
+    - 'lib/rvg/misc.rb'
+    - 'lib/rvg/transformable.rb'
+    - 'test/ImageList1.rb'
+    - 'test/Import_Export.rb'
+
 # Offense count: 90
 Style/CommentedKeyword:
   Enabled: false
 
+# Offense count: 253
+# Cop supports --auto-correct.
+# Configuration parameters: Notice, AutocorrectNotice.
+Style/Copyright:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: AllowCoercion.
+Style/DateTime:
+  Exclude:
+    - 'ext/RMagick/extconf.rb'
+
 # Offense count: 36
 Style/Documentation:
   Enabled: false
 
+# Offense count: 74
+# Configuration parameters: RequireForNonPublicMethods.
+Style/DocumentationMethod:
+  Enabled: false
+
 # Offense count: 4
 Style/EvalWithLocation:
   Exclude:
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/units.rb'
@@ -206,23 +432,66 @@
     - 'examples/identify.rb'
     - 'ext/RMagick/extconf.rb'
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/pathdata.rb'
 
-# Offense count: 65
+# Offense count: 253
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: when_needed, always, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 40
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
   Exclude:
     - 'examples/histogram.rb'
     - 'ext/RMagick/extconf.rb'
 
 # Offense count: 2
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'ext/RMagick/extconf.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'ext/RMagick/extconf.rb'
+
+# Offense count: 163
+Style/InlineComment:
+  Enabled: false
+
+# Offense count: 1051
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreMacros, IgnoredMethods, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, EnforcedStyle.
+# SupportedStyles: require_parentheses, omit_parentheses
+Style/MethodCallWithArgsParentheses:
+  Enabled: false
+
+# Offense count: 8
+Style/MethodCalledOnDoEndBlock:
+  Exclude:
+    - 'spec/rmagick/ImageList1_spec.rb'
+    - 'spec/rmagick/image/composite_spec.rb'
+    - 'spec/rmagick/image/dispatch_spec.rb'
+
+# Offense count: 2
 Style/MethodMissingSuper:
   Exclude:
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/misc.rb'
 
+# Offense count: 68
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: if, case, both
+Style/MissingElse:
+  Enabled: false
+
 # Offense count: 3
 Style/MissingRespondToMissing:
   Exclude:
     - 'lib/rmagick_internal.rb'
     - 'lib/rvg/misc.rb'
@@ -241,15 +510,80 @@
     - 'examples/pattern_fill.rb'
     - 'examples/rotating_text.rb'
     - 'examples/thumbnail.rb'
     - 'examples/vignette.rb'
 
-# Offense count: 158
+# Offense count: 162
 # Cop supports --auto-correct.
 Style/MutableConstant:
   Enabled: false
 
-# Offense count: 672
+# Offense count: 34
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/embellishable.rb'
+    - 'test/Image2.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Exclude:
+    - 'test/Image3.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
+# Whitelist: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/rmagick_internal.rb'
+
+# Offense count: 5
+Style/Send:
+  Exclude:
+    - 'lib/rmagick_internal.rb'
+    - 'test/Image2.rb'
+
+# Offense count: 2
+# Configuration parameters: Methods.
+# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
+Style/SingleLineBlockParams:
+  Exclude:
+    - 'lib/rvg/misc.rb'
+
+# Offense count: 20
+# Cop supports --auto-correct.
+Style/StringHashKeys:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/rmagick_internal.rb'
+    - 'lib/rvg/misc.rb'
+    - 'spec/rmagick/image/properties_spec.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'Rakefile'
+    - 'test/Image1.rb'
+    - 'test/ImageList2.rb'
+    - 'test/PolaroidOptions.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredMethods.
+Style/StringMethods:
+  Exclude:
+    - 'lib/rvg/misc.rb'
+
+# Offense count: 640
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 278