.rubocop_todo.yml in riiif-2.3.0 vs .rubocop_todo.yml in riiif-2.4.0

@@ -1,60 +1,105 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-02-23 11:28:05 -0600 using RuboCop version 0.52.1.
+# on 2022-02-28 10:01:41 -0800 using RuboCop version 0.85.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'spec/controllers/riiif/images_controller_spec.rb'
+
+# Offense count: 62
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: normal, indented_internal_methods
+Layout/IndentationConsistency:
+  Exclude:
+    - 'app/controllers/riiif/images_controller.rb'
+    - 'app/resolvers/riiif/file_system_file_resolver.rb'
+    - 'app/resolvers/riiif/http_file_resolver.rb'
+    - 'app/services/riiif/crop.rb'
+    - 'app/services/riiif/imagemagick_command_factory.rb'
+    - 'app/services/riiif/kakadu_command_factory.rb'
+    - 'app/services/riiif/resize.rb'
+    - 'app/transformers/riiif/kakadu_transformer.rb'
+
+# Offense count: 62
+# Cop supports --auto-correct.
+# Configuration parameters: Width, IgnoredPatterns.
+Layout/IndentationWidth:
+  Exclude:
+    - 'app/controllers/riiif/images_controller.rb'
+    - 'app/resolvers/riiif/file_system_file_resolver.rb'
+    - 'app/resolvers/riiif/http_file_resolver.rb'
+    - 'app/services/riiif/crop.rb'
+    - 'app/services/riiif/imagemagick_command_factory.rb'
+    - 'app/services/riiif/kakadu_command_factory.rb'
+    - 'app/services/riiif/resize.rb'
+    - 'app/transformers/riiif/kakadu_transformer.rb'
+
+# Offense count: 1
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
-    - 'app/models/riiif/file.rb'
     - 'app/resolvers/riiif/http_file_resolver.rb'
 
 # Offense count: 1
 Lint/DuplicateMethods:
   Exclude:
     - 'app/resolvers/riiif/http_file_resolver.rb'
 
-# Offense count: 1
-Lint/HandleExceptions:
+# Offense count: 2
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
   Exclude:
+    - 'app/controllers/riiif/images_controller.rb'
     - 'spec/models/riiif/http_file_resolver_spec.rb'
 
-# Offense count: 1
-Lint/UselessAssignment:
-  Exclude:
-    - 'app/models/riiif/file.rb'
-
 # Offense count: 21
 # Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 233
+  Max: 237
 
 # Offense count: 1
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 7
 
 # Offense count: 3
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 18
 
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 6
 
+# Offense count: 3
+# Cop supports --auto-correct.
+Performance/RegexpMatch:
+  Exclude:
+    - 'app/resolvers/riiif/file_system_file_resolver.rb'
+    - 'app/services/riiif/imagemagick_command_factory.rb'
+
 # Offense count: 1
 RSpec/DescribeClass:
   Exclude:
     - 'spec/routing/resize_routes_spec.rb'
 
 # Offense count: 2
+# Cop supports --auto-correct.
 # Configuration parameters: SkipBlocks, EnforcedStyle.
 # SupportedStyles: described_class, explicit
 RSpec/DescribedClass:
   Exclude:
     - 'spec/models/riiif/image_spec.rb'
@@ -65,22 +110,25 @@
   Exclude:
     - 'spec/controllers/riiif/images_controller_spec.rb'
     - 'spec/models/riiif/http_file_resolver_spec.rb'
     - 'spec/transformers/riiif/kakadu_transformer_spec.rb'
 
-# Offense count: 1
+# Offense count: 2
+# Cop supports --auto-correct.
 RSpec/LeadingSubject:
   Exclude:
+    - 'spec/controllers/riiif/images_controller_spec.rb'
     - 'spec/transformers/riiif/kakadu_transformer_spec.rb'
 
 # Offense count: 43
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 23
+# Offense count: 24
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Exclude:
     - 'spec/controllers/riiif/images_controller_spec.rb'
     - 'spec/models/riiif/akubra_system_file_resolver_spec.rb'
     - 'spec/models/riiif/file_system_file_resolver_spec.rb'
@@ -91,26 +139,71 @@
 RSpec/RepeatedExample:
   Exclude:
     - 'spec/controllers/riiif/images_controller_spec.rb'
 
 # Offense count: 7
-# Configuration parameters: IgnoreSymbolicNames.
+# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/controllers/riiif/images_controller_spec.rb'
     - 'spec/services/riiif/imagemagick_command_factory_spec.rb'
     - 'spec/services/riiif/kakadu_command_factory_spec.rb'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
+Rails/Blank:
+  Exclude:
+    - 'spec/controllers/riiif/images_controller_spec.rb'
+
 # Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
 Rails/FilePath:
   Exclude:
     - 'spec/models/riiif/akubra_system_file_resolver_spec.rb'
 
+# Offense count: 37
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/riiif/routes.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'app/services/riiif/imagemagick_command_factory.rb'
+
 # Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
     - 'app/models/riiif/image.rb'
     - 'app/resolvers/riiif/file_system_file_resolver.rb'
     - 'spec/controllers/riiif/images_controller_spec.rb'
     - 'spec/models/riiif/http_file_resolver_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'app/resolvers/riiif/http_file_resolver.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantFreeze:
+  Exclude:
+    - 'app/services/riiif/imagemagick_command_factory.rb'